mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 15:20:42 +01:00
971de07713
This CL corrects the bug that only looked at narrowband render signals above 900 Hz and only assumed that the influence of such lasted for 6 blocks, which resulted in filter divergence and echo leakage. Bug: webrtc:9008,chromium:821670 Change-Id: I9b2635d24b260e9d9a8c5c088ab663e03fb93c42 Reviewed-on: https://webrtc-review.googlesource.com/61800 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22434}
126 lines
4.7 KiB
C++
126 lines
4.7 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/audio_processing/aec3/suppression_gain.h"
|
|
|
|
#include "modules/audio_processing/aec3/aec_state.h"
|
|
#include "modules/audio_processing/aec3/render_delay_buffer.h"
|
|
#include "modules/audio_processing/aec3/subtractor.h"
|
|
#include "modules/audio_processing/logging/apm_data_dumper.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "system_wrappers/include/cpu_features_wrapper.h"
|
|
#include "test/gtest.h"
|
|
#include "typedefs.h" // NOLINT(build/include)
|
|
|
|
namespace webrtc {
|
|
namespace aec3 {
|
|
|
|
#if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
|
|
|
|
// Verifies that the check for non-null output gains works.
|
|
TEST(SuppressionGain, NullOutputGains) {
|
|
std::array<float, kFftLengthBy2Plus1> E2;
|
|
std::array<float, kFftLengthBy2Plus1> R2;
|
|
std::array<float, kFftLengthBy2Plus1> N2;
|
|
E2.fill(0.f);
|
|
R2.fill(0.f);
|
|
N2.fill(0.f);
|
|
float high_bands_gain;
|
|
AecState aec_state(EchoCanceller3Config{});
|
|
EXPECT_DEATH(
|
|
SuppressionGain(EchoCanceller3Config{}, DetectOptimization())
|
|
.GetGain(E2, R2, N2, RenderSignalAnalyzer((EchoCanceller3Config{})),
|
|
aec_state,
|
|
std::vector<std::vector<float>>(
|
|
3, std::vector<float>(kBlockSize, 0.f)),
|
|
&high_bands_gain, nullptr),
|
|
"");
|
|
}
|
|
|
|
#endif
|
|
|
|
// Does a sanity check that the gains are correctly computed.
|
|
TEST(SuppressionGain, BasicGainComputation) {
|
|
SuppressionGain suppression_gain(EchoCanceller3Config(),
|
|
DetectOptimization());
|
|
RenderSignalAnalyzer analyzer(EchoCanceller3Config{});
|
|
float high_bands_gain;
|
|
std::array<float, kFftLengthBy2Plus1> E2;
|
|
std::array<float, kFftLengthBy2Plus1> Y2;
|
|
std::array<float, kFftLengthBy2Plus1> R2;
|
|
std::array<float, kFftLengthBy2Plus1> N2;
|
|
std::array<float, kFftLengthBy2Plus1> g;
|
|
std::array<float, kBlockSize> s;
|
|
std::vector<std::vector<float>> x(1, std::vector<float>(kBlockSize, 0.f));
|
|
EchoCanceller3Config config;
|
|
AecState aec_state(config);
|
|
ApmDataDumper data_dumper(42);
|
|
Subtractor subtractor(config, &data_dumper, DetectOptimization());
|
|
std::unique_ptr<RenderDelayBuffer> render_delay_buffer(
|
|
RenderDelayBuffer::Create(config, 3));
|
|
rtc::Optional<DelayEstimate> delay_estimate;
|
|
|
|
// Ensure that a strong noise is detected to mask any echoes.
|
|
E2.fill(10.f);
|
|
Y2.fill(10.f);
|
|
R2.fill(0.1f);
|
|
N2.fill(100.f);
|
|
s.fill(10.f);
|
|
|
|
// Ensure that the gain is no longer forced to zero.
|
|
for (int k = 0; k <= kNumBlocksPerSecond / 5 + 1; ++k) {
|
|
aec_state.Update(delay_estimate, subtractor.FilterFrequencyResponse(),
|
|
subtractor.FilterImpulseResponse(),
|
|
subtractor.ConvergedFilter(),
|
|
*render_delay_buffer->GetRenderBuffer(), E2, Y2, s, false);
|
|
}
|
|
|
|
for (int k = 0; k < 100; ++k) {
|
|
aec_state.Update(delay_estimate, subtractor.FilterFrequencyResponse(),
|
|
subtractor.FilterImpulseResponse(),
|
|
subtractor.ConvergedFilter(),
|
|
*render_delay_buffer->GetRenderBuffer(), E2, Y2, s, false);
|
|
suppression_gain.GetGain(E2, R2, N2, analyzer, aec_state, x,
|
|
&high_bands_gain, &g);
|
|
}
|
|
std::for_each(g.begin(), g.end(),
|
|
[](float a) { EXPECT_NEAR(1.f, a, 0.001); });
|
|
|
|
// Ensure that a strong nearend is detected to mask any echoes.
|
|
E2.fill(100.f);
|
|
Y2.fill(100.f);
|
|
R2.fill(0.1f);
|
|
N2.fill(0.f);
|
|
for (int k = 0; k < 100; ++k) {
|
|
aec_state.Update(delay_estimate, subtractor.FilterFrequencyResponse(),
|
|
subtractor.FilterImpulseResponse(),
|
|
subtractor.ConvergedFilter(),
|
|
*render_delay_buffer->GetRenderBuffer(), E2, Y2, s, false);
|
|
suppression_gain.GetGain(E2, R2, N2, analyzer, aec_state, x,
|
|
&high_bands_gain, &g);
|
|
}
|
|
std::for_each(g.begin(), g.end(),
|
|
[](float a) { EXPECT_NEAR(1.f, a, 0.001); });
|
|
|
|
// Ensure that a strong echo is suppressed.
|
|
E2.fill(1000000000.f);
|
|
R2.fill(10000000000000.f);
|
|
N2.fill(0.f);
|
|
for (int k = 0; k < 10; ++k) {
|
|
suppression_gain.GetGain(E2, R2, N2, analyzer, aec_state, x,
|
|
&high_bands_gain, &g);
|
|
}
|
|
std::for_each(g.begin(), g.end(),
|
|
[](float a) { EXPECT_NEAR(0.f, a, 0.001); });
|
|
|
|
}
|
|
|
|
} // namespace aec3
|
|
} // namespace webrtc
|