mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-14 22:30:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_processing/aecm
History
Alex Loiko bc5c69f8e7 Use of unititialized value in AECM. 
The AecMobile struct contains a ::farendOld field. It's type is 'short [2][80]'.
The field was initialized by

  memset(&aecm->farendOld[0][0], 0, 160);

But sizeof(short) is not guaranteed to be 1. This causes use of
unititialized memory on some platforms. According to MSAN, it can
affect the output of the echo canceller.

The issue was found by the MSAN  fuzzer.

This change initializes the array properly.

Bug: chromium:805396
Change-Id: Ibcaca2185cfa153e8fd826e9addfc04d7b65e417
Reviewed-on: https://webrtc-review.googlesource.com/43860
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21764}
2018-01-25 15:09:14 +00:00
..
aecm_core.cc Undefined shifts. 2018-01-25 12:26:51 +00:00
aecm_core.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
aecm_core_c.cc Undefined shifts. 2018-01-25 12:26:51 +00:00
aecm_core_mips.cc Move some numeric utility code from rtc_base/ to rtc_base/numerics/ 2017-11-22 11:21:47 +00:00
aecm_core_neon.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
aecm_defines.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
echo_control_mobile.cc Use of unititialized value in AECM. 2018-01-25 15:09:14 +00:00
echo_control_mobile.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00