mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
1ab4e873e4
The tests are sometimes hiting timeouts on msan runs: https://chromium-swarm.appspot.com/task?id=5d02a893ec864210 Change-Id: I16f15f3ab5750bdcc37a1cd1e32846adb2fb7602 Bug: webrtc:11607 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273343 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#37935}
71 lines
2.4 KiB
Python
71 lines
2.4 KiB
Python
#!/usr/bin/env vpython3
|
|
|
|
# Copyright (c) 2022 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import os
|
|
|
|
# Runs PRESUBMIT.py in py3 mode by git cl presubmit.
|
|
USE_PYTHON3 = True
|
|
|
|
|
|
def _HasLocalChanges(input_api):
|
|
ret = input_api.subprocess.call(['git', 'diff', '--quiet'])
|
|
return ret != 0
|
|
|
|
|
|
def CheckPatchFormatted(input_api, output_api):
|
|
results = []
|
|
file_filter = lambda x: x.LocalPath().endswith('.pyl')
|
|
affected_files = input_api.AffectedFiles(include_deletes=False,
|
|
file_filter=file_filter)
|
|
|
|
for f in affected_files:
|
|
cmd = ['yapf', '-i', f.AbsoluteLocalPath()]
|
|
if input_api.subprocess.call(cmd):
|
|
results.append(output_api.PresubmitError('Error calling "' + cmd + '"'))
|
|
|
|
if _HasLocalChanges(input_api):
|
|
msg = ('Diff found after running "yapf -i" on modified .pyl files.\n'
|
|
'Please commit or discard the new changes.')
|
|
results.append(output_api.PresubmitError(msg))
|
|
|
|
return results
|
|
|
|
|
|
def CheckSourceSideSpecs(input_api, output_api):
|
|
d = os.path.dirname
|
|
webrtc_root = d(d(input_api.PresubmitLocalPath()))
|
|
gen_script = os.path.join(webrtc_root, 'testing', 'buildbot',
|
|
'generate_buildbot_json.py')
|
|
|
|
commands = [
|
|
input_api.Command(name='generate_buildbot_json',
|
|
cmd=[
|
|
input_api.python3_executable, gen_script, '--check',
|
|
'--verbose', '--pyl-files-dir',
|
|
input_api.PresubmitLocalPath()
|
|
],
|
|
kwargs={},
|
|
message=output_api.PresubmitError),
|
|
]
|
|
return input_api.RunTests(commands)
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
results = []
|
|
results.extend(CheckPatchFormatted(input_api, output_api))
|
|
results.extend(CheckSourceSideSpecs(input_api, output_api))
|
|
return results
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
results = []
|
|
results.extend(CheckPatchFormatted(input_api, output_api))
|
|
results.extend(CheckSourceSideSpecs(input_api, output_api))
|
|
return results
|