mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 05:40:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_processing/agc
History
Alessio Bazzica b190ca9e70 Disable Analog AGC based on the APM config 
Fixing a bug due to which the analog controller could not be disabled.
AudioProcessing::Config::GainController1::AnalogGainController::enabled
was ignored and therefore `recommended_stream_analog_level_locked()` in
APM was returning the level recommended by `AgcManagerDirect`.

When the analog controller is disabled, `stream_analog_level()` now
returns the last value set via `set_stream_analog_level()`.
However, the analog controller code is still running and, in particular,
the existing metrics are reported as if the controller were enabled.
This choice was made to reduce the risks of adding bugs in the digital
compression gain selection part, which is tied to the analog
controller. The metric drawback will be solved in a follow-up CL.

Additional changes:
- log `WebRTC.Audio.GainController.Analog.Enabled` when
AGC1 is created or when its config changes
- first step to replace "analog level" with "input volume"

Bug: webrtc:7909, b/180019868
Change-Id: I28ce9556dd98f3dd9ad546799406c55478730435
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270663
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38044}
2022-09-09 10:34:58 +00:00
..
legacy Use backticks not vertical bars to denote variables in comments for /modules/audio_processing 2021-08-09 21:49:02 +00:00
agc.cc Improve code quality in modules/audio_processing/agc/ 2022-02-04 15:37:21 +00:00
agc.h Improve code quality in modules/audio_processing/agc/ 2022-02-04 15:37:21 +00:00
agc_manager_direct.cc Disable Analog AGC based on the APM config 2022-09-09 10:34:58 +00:00
agc_manager_direct.h Disable Analog AGC based on the APM config 2022-09-09 10:34:58 +00:00
agc_manager_direct_unittest.cc Disable Analog AGC based on the APM config 2022-09-09 10:34:58 +00:00
analog_gain_stats_reporter.cc Add AnalogGainStatsReporter to compute and report analog gain statistics 2021-11-03 06:32:33 +00:00
analog_gain_stats_reporter.h Add AnalogGainStatsReporter to compute and report analog gain statistics 2021-11-03 06:32:33 +00:00
analog_gain_stats_reporter_unittest.cc Fix flakiness of CheckLogLevelUpdateStatsEmpty. 2022-05-17 11:57:35 +00:00
BUILD.gn Disable Analog AGC based on the APM config 2022-09-09 10:34:58 +00:00
clipping_predictor.cc Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED 2021-11-15 21:44:59 +00:00
clipping_predictor.h AGC analog ClippingPredictor refactoring 1/2 2021-06-14 12:21:31 +00:00
clipping_predictor_evaluator.cc ClippingPredictorEvaluator: predictions only match future detections 2021-09-07 15:26:27 +00:00
clipping_predictor_evaluator.h ClippingPredictorEvaluator: predictions only match future detections 2021-09-07 15:26:27 +00:00
clipping_predictor_evaluator_unittest.cc ClippingPredictorEvaluator: predictions only match future detections 2021-09-07 15:26:27 +00:00
clipping_predictor_level_buffer.cc Add ClippingPredictorLevelBuffer circular buffer. 2021-05-31 14:04:54 +00:00
clipping_predictor_level_buffer.h Add ClippingPredictorLevelBuffer circular buffer. 2021-05-31 14:04:54 +00:00
clipping_predictor_level_buffer_unittest.cc Add ClippingPredictorLevelBuffer circular buffer. 2021-05-31 14:04:54 +00:00
clipping_predictor_unittest.cc AGC analog ClippingPredictor refactoring 2/2 2021-06-16 10:28:57 +00:00
gain_control.h Use backticks not vertical bars to denote variables in comments for /modules/audio_processing 2021-08-09 21:49:02 +00:00
gain_map_internal.h Ensured that all files in APM are using the webrtc namespace 2020-03-20 17:33:28 +00:00
loudness_histogram.cc Use backticks not vertical bars to denote variables in comments for /modules/audio_processing 2021-08-09 21:49:02 +00:00
loudness_histogram.h Use backticks not vertical bars to denote variables in comments for /modules/audio_processing 2021-08-09 21:49:02 +00:00
loudness_histogram_unittest.cc Adopt absl::string_view in modules/audio_processing/ 2022-08-16 13:49:14 +00:00
mock_agc.h Improve code quality in modules/audio_processing/agc/ 2022-02-04 15:37:21 +00:00
utility.cc Ensured that all files in APM are using the webrtc namespace 2020-03-20 17:33:28 +00:00
utility.h Ensured that all files in APM are using the webrtc namespace 2020-03-20 17:33:28 +00:00