mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 22:00:47 +01:00
d122464b6a
When they are unset, internally same defaults will be created by Environment, i.e., creating them in CreatePeerConnectionFactory is redundant (https://webrtc.googlesource.com/src/+/refs/heads/main/api/environment/environment_factory.cc#96) This would simplify changing the default in the future, and demonstrates that by default it is better to leave these dependencies unset. Bug: webrtc:42226001 Change-Id: I8bf8614b9e8ca4062939e71d45e67cf2da1558c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350742 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42322}
67 lines
2.7 KiB
C++
67 lines
2.7 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/create_peerconnection_factory.h"
|
|
|
|
#include <memory>
|
|
#include <utility>
|
|
|
|
#include "api/audio/audio_device.h"
|
|
#include "api/audio/audio_processing.h"
|
|
#include "api/enable_media.h"
|
|
#include "api/peer_connection_interface.h"
|
|
#include "api/rtc_event_log/rtc_event_log_factory.h"
|
|
#include "api/scoped_refptr.h"
|
|
#include "rtc_base/thread.h"
|
|
|
|
namespace webrtc {
|
|
|
|
rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
|
|
rtc::Thread* network_thread,
|
|
rtc::Thread* worker_thread,
|
|
rtc::Thread* signaling_thread,
|
|
rtc::scoped_refptr<AudioDeviceModule> default_adm,
|
|
rtc::scoped_refptr<AudioEncoderFactory> audio_encoder_factory,
|
|
rtc::scoped_refptr<AudioDecoderFactory> audio_decoder_factory,
|
|
std::unique_ptr<VideoEncoderFactory> video_encoder_factory,
|
|
std::unique_ptr<VideoDecoderFactory> video_decoder_factory,
|
|
rtc::scoped_refptr<AudioMixer> audio_mixer,
|
|
rtc::scoped_refptr<AudioProcessing> audio_processing,
|
|
std::unique_ptr<AudioFrameProcessor> audio_frame_processor,
|
|
std::unique_ptr<FieldTrialsView> field_trials) {
|
|
PeerConnectionFactoryDependencies dependencies;
|
|
dependencies.network_thread = network_thread;
|
|
dependencies.worker_thread = worker_thread;
|
|
dependencies.signaling_thread = signaling_thread;
|
|
dependencies.event_log_factory = std::make_unique<RtcEventLogFactory>();
|
|
dependencies.trials = std::move(field_trials);
|
|
|
|
if (network_thread) {
|
|
// TODO(bugs.webrtc.org/13145): Add an rtc::SocketFactory* argument.
|
|
dependencies.socket_factory = network_thread->socketserver();
|
|
}
|
|
dependencies.adm = std::move(default_adm);
|
|
dependencies.audio_encoder_factory = std::move(audio_encoder_factory);
|
|
dependencies.audio_decoder_factory = std::move(audio_decoder_factory);
|
|
dependencies.audio_frame_processor = std::move(audio_frame_processor);
|
|
if (audio_processing) {
|
|
dependencies.audio_processing = std::move(audio_processing);
|
|
} else {
|
|
dependencies.audio_processing = AudioProcessingBuilder().Create();
|
|
}
|
|
dependencies.audio_mixer = std::move(audio_mixer);
|
|
dependencies.video_encoder_factory = std::move(video_encoder_factory);
|
|
dependencies.video_decoder_factory = std::move(video_decoder_factory);
|
|
EnableMedia(dependencies);
|
|
|
|
return CreateModularPeerConnectionFactory(std::move(dependencies));
|
|
}
|
|
|
|
} // namespace webrtc
|