mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 06:10:40 +01:00
2849146823
Matlab files extension is the same as ObjC, which is .m This makes clang-format think that those files are ObjC and then it wrongly formats them, leading to output that doesn't compile at all. It's a known issue and the solution is to disable it in Matlab files. I don't want to disable ObjC in whole folders, because of 2 reasons: 1) I want ObjC to be properly formatted if new files are added in the future 2) C++ header files are interpreted as ObjC and it will disable their formatting According to clang documentation (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code), we can disable formatting inline. However, comments in Matlab are prefixed with `%` and not `//`, so I thought of a kinda hacky solution, which is `% // clang-format off`, and it works perfectly. No-Iwyu: Includes didn't change and it isn't related to formatting Bug: webrtc:42225392 Change-Id: I281462fd1aecd3ff0428e6ee974514ebabc696ec Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/374060 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43700} |
||
|---|---|---|
| .. | ||
| maxUnwrap.m | ||
| parseLog.m | ||
| rtpAnalyze.m | ||