mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-19 16:47:50 +01:00
![]() PlatformThread's API is using old style function pointers, causes casting, is unintuitive and forces artificial call sequences, and is additionally possible to misuse in release mode. Fix this by an API face lift: 1. The class is turned into a handle, which can be empty. 2. The only way of getting a non-empty PlatformThread is by calling SpawnJoinable or SpawnDetached, clearly conveying the semantics to the code reader. 3. Handles can be Finalized, which works differently for joinable and detached threads: a) Handles for detached threads are simply closed where applicable. b) Joinable threads are joined before handles are closed. 4. The destructor finalizes handles. No explicit call is needed. Fixed: webrtc:12727 Change-Id: Id00a0464edf4fc9e552b6a1fbb5d2e1280e88811 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215075 Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33923} |
||
---|---|---|
.. | ||
api/org/webrtc | ||
instrumentationtests | ||
native_api | ||
native_unittests | ||
src | ||
tests | ||
AndroidManifest.xml | ||
BUILD.gn | ||
OWNERS | ||
PRESUBMIT.py | ||
README |
This directory holds a Java implementation of the webrtc::PeerConnection API, as well as the JNI glue C++ code that lets the Java implementation reuse the C++ implementation of the same API. To build the Java API and related tests, make sure you have a WebRTC checkout with Android specific parts. This can be used for linux development as well by configuring gn appropriately, as it is a superset of the webrtc checkout: fetch --nohooks webrtc_android gclient sync You also must generate GN projects with: --args='target_os="android" target_cpu="arm"' More information on getting the code, compiling and running the AppRTCMobile app can be found at: https://webrtc.org/native-code/android/ To use the Java API, start by looking at the public interface of org.webrtc.PeerConnection{,Factory} and the org.webrtc.PeerConnectionTest. To understand the implementation of the API, see the native code in src/jni/pc/.