mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 06:40:43 +01:00
ab009c27b4
This change refactors existing self-assignments within if clauses across the WebRTC codebase. *Why:* - Bug Prevention: Assignments within conditionals are frequently unintended errors, often mistaken for equality checks. - Clearer Code: Separating assignments from conditionals improves code readability and reduces the risk of misinterpretation. Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b Bug: chromium:361594695 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460 Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42850}
83 lines
2.4 KiB
Text
83 lines
2.4 KiB
Text
/*
|
|
* Copyright 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCMediaSource+Private.h"
|
|
|
|
#include "rtc_base/checks.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCMediaSource) {
|
|
RTC_OBJC_TYPE(RTCPeerConnectionFactory) * _factory;
|
|
RTCMediaSourceType _type;
|
|
}
|
|
|
|
@synthesize nativeMediaSource = _nativeMediaSource;
|
|
|
|
- (instancetype)initWithFactory:(RTC_OBJC_TYPE(RTCPeerConnectionFactory) *)factory
|
|
nativeMediaSource:(rtc::scoped_refptr<webrtc::MediaSourceInterface>)nativeMediaSource
|
|
type:(RTCMediaSourceType)type {
|
|
RTC_DCHECK(factory);
|
|
RTC_DCHECK(nativeMediaSource);
|
|
self = [super init];
|
|
if (self) {
|
|
_factory = factory;
|
|
_nativeMediaSource = nativeMediaSource;
|
|
_type = type;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (RTCSourceState)state {
|
|
return [[self class] sourceStateForNativeState:_nativeMediaSource->state()];
|
|
}
|
|
|
|
#pragma mark - Private
|
|
|
|
+ (webrtc::MediaSourceInterface::SourceState)nativeSourceStateForState:
|
|
(RTCSourceState)state {
|
|
switch (state) {
|
|
case RTCSourceStateInitializing:
|
|
return webrtc::MediaSourceInterface::kInitializing;
|
|
case RTCSourceStateLive:
|
|
return webrtc::MediaSourceInterface::kLive;
|
|
case RTCSourceStateEnded:
|
|
return webrtc::MediaSourceInterface::kEnded;
|
|
case RTCSourceStateMuted:
|
|
return webrtc::MediaSourceInterface::kMuted;
|
|
}
|
|
}
|
|
|
|
+ (RTCSourceState)sourceStateForNativeState:
|
|
(webrtc::MediaSourceInterface::SourceState)nativeState {
|
|
switch (nativeState) {
|
|
case webrtc::MediaSourceInterface::kInitializing:
|
|
return RTCSourceStateInitializing;
|
|
case webrtc::MediaSourceInterface::kLive:
|
|
return RTCSourceStateLive;
|
|
case webrtc::MediaSourceInterface::kEnded:
|
|
return RTCSourceStateEnded;
|
|
case webrtc::MediaSourceInterface::kMuted:
|
|
return RTCSourceStateMuted;
|
|
}
|
|
}
|
|
|
|
+ (NSString *)stringForState:(RTCSourceState)state {
|
|
switch (state) {
|
|
case RTCSourceStateInitializing:
|
|
return @"Initializing";
|
|
case RTCSourceStateLive:
|
|
return @"Live";
|
|
case RTCSourceStateEnded:
|
|
return @"Ended";
|
|
case RTCSourceStateMuted:
|
|
return @"Muted";
|
|
}
|
|
}
|
|
|
|
@end
|