mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 06:40:43 +01:00
ab009c27b4
This change refactors existing self-assignments within if clauses across the WebRTC codebase. *Why:* - Bug Prevention: Assignments within conditionals are frequently unintended errors, often mistaken for equality checks. - Clearer Code: Separating assignments from conditionals improves code readability and reduces the risk of misinterpretation. Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b Bug: chromium:361594695 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460 Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42850}
61 lines
2.2 KiB
Text
61 lines
2.2 KiB
Text
/*
|
|
* Copyright 2024 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCRtpCapabilities+Private.h"
|
|
|
|
#import "RTCRtpCodecCapability+Private.h"
|
|
#import "RTCRtpHeaderExtensionCapability+Private.h"
|
|
|
|
#import "base/RTCLogging.h"
|
|
#import "helpers/NSString+StdString.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCRtpCapabilities)
|
|
|
|
@synthesize codecs = _codecs;
|
|
@synthesize headerExtensions = _headerExtensions;
|
|
|
|
- (instancetype)init {
|
|
webrtc::RtpCapabilities nativeRtpCapabilities;
|
|
return [self initWithNativeRtpCapabilities:nativeRtpCapabilities];
|
|
}
|
|
|
|
- (instancetype)initWithNativeRtpCapabilities:
|
|
(const webrtc::RtpCapabilities &)nativeRtpCapabilities {
|
|
self = [super init];
|
|
if (self) {
|
|
NSMutableArray *codecs = [[NSMutableArray alloc] init];
|
|
for (const auto &codec : nativeRtpCapabilities.codecs) {
|
|
[codecs addObject:[[RTC_OBJC_TYPE(RTCRtpCodecCapability) alloc]
|
|
initWithNativeRtpCodecCapability:codec]];
|
|
}
|
|
_codecs = codecs;
|
|
|
|
NSMutableArray *headerExtensions = [[NSMutableArray alloc] init];
|
|
for (const auto &headerExtension : nativeRtpCapabilities.header_extensions) {
|
|
[headerExtensions addObject:[[RTC_OBJC_TYPE(RTCRtpHeaderExtensionCapability) alloc]
|
|
initWithNativeRtpHeaderExtensionCapability:headerExtension]];
|
|
}
|
|
_headerExtensions = headerExtensions;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (webrtc::RtpCapabilities)nativeRtpCapabilities {
|
|
webrtc::RtpCapabilities rtpCapabilities;
|
|
for (RTC_OBJC_TYPE(RTCRtpCodecCapability) * codec in _codecs) {
|
|
rtpCapabilities.codecs.push_back(codec.nativeRtpCodecCapability);
|
|
}
|
|
for (RTC_OBJC_TYPE(RTCRtpHeaderExtensionCapability) * headerExtension in _headerExtensions) {
|
|
rtpCapabilities.header_extensions.push_back(headerExtension.nativeRtpHeaderExtensionCapability);
|
|
}
|
|
return rtpCapabilities;
|
|
}
|
|
|
|
@end
|