mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 07:10:38 +01:00
fc52b912a3
Since there is no way to enable/disable these diagnostics at runtime, this CL moves the suppression into the rtc_* templates in order to remove the need to explicitly add the snippet of code needed to suppress it (currently copy/pasted in 144 locations). The diagnostic that causes the most problems is the one about "complex class/struct explicit ctor/dtor" [1] because WebRTC doesn't find it useful enough. Other diagnostics are good (for example the one that warns about using "virtual" instead of "override", but that will be covered by this clang-tidy check [2]) while others are Chromium related so they have never triggered. [1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a [2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Bug: webrtc:163 Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34 Reviewed-on: https://webrtc-review.googlesource.com/c/125088 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26918} |
||
|---|---|---|
| .. | ||
| bitrate_controller.cc | ||
| bitrate_controller.h | ||
| bitrate_controller_unittest.cc | ||
| BUILD.gn | ||
| monitor_interval.cc | ||
| monitor_interval.h | ||
| monitor_interval_unittest.cc | ||
| pcc_factory.cc | ||
| pcc_factory.h | ||
| pcc_network_controller.cc | ||
| pcc_network_controller.h | ||
| pcc_network_controller_unittest.cc | ||
| rtt_tracker.cc | ||
| rtt_tracker.h | ||
| rtt_tracker_unittest.cc | ||
| utility_function.cc | ||
| utility_function.h | ||
| utility_function_unittest.cc | ||