mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
8d2c5a810f
The eventual goal is to allow PlatformThread to use SequencedTaskChecker, but getting to that point will require some more detangling. Here are (roughly) the steps taken in this CL: * Make constructormagic a separate target. * Move atomicops and arraysize to separate targets * Move platform_thread_types to a separate target * Move criticalsection to a separate target * Move thread_checker to separate target * Make sequenced_task_checker not depend on base_approved * Move ptr_util to a separate target * Move scoped_ptr to ptr_util * Make rtc_task_queue_api not depend on base_approved * Make sequenced_task_checker depend on rtc_task_queue_api * Move rtc::Event to its own target * Move basictypes.h to constructormagic * Move format_macros and stringize_macros into constructormagic * Rename constructormagic target to... macromagic * Move stringencode to stringutils * New target for safe_conversions * Move timeutils to a new target. * Move logging to a new target. * Move platform_thread to a new target. * Make refcount a new target (refcount, refcountedobject, refcounter). * Remove rtc_base_approved from deps of TQ * Remove a circular dependency between event tracer and platform thread. Further steps will probably be to factor TaskQueue::Current() to not be a part of the TaskQueue class itself and have it declared+implemented in a target that's lower level than TQ itself. SequencedTaskChecker can then depend on that target and avoid the TQ dependency. Once we're there, PlatformThread will be able to depend on SequencedTaskChecker. Attempted but eventually removed from this CL: * Make TQ a part of rtc_base_approved * Remove direct dependencies on sequenced_task_checker. * Profit. A few include-what-you-use updates along the way. Fix a few targets that were depending on rtc_task_queue_api Change-Id: Iee79aa2e81d978444c51b3005db9df7dc12d92a9 Bug: webrtc:8957 Reviewed-on: https://webrtc-review.googlesource.com/58480 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22487}
49 lines
1.5 KiB
C++
49 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef RTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_
|
|
#define RTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_
|
|
|
|
#include "rtc_base/criticalsection.h"
|
|
#include "rtc_base/thread_checker.h"
|
|
|
|
namespace rtc {
|
|
|
|
class TaskQueue;
|
|
// Real implementation of SequencedTaskChecker, for use in debug mode, or
|
|
// for temporary use in release mode.
|
|
//
|
|
// Note: You should almost always use the SequencedTaskChecker class to get the
|
|
// right version for your build configuration.
|
|
class SequencedTaskCheckerImpl {
|
|
public:
|
|
SequencedTaskCheckerImpl();
|
|
~SequencedTaskCheckerImpl();
|
|
|
|
bool CalledSequentially() const;
|
|
|
|
// Changes the task queue or thread that is checked for in IsCurrent. This
|
|
// may be useful when an object may be created on one task queue / thread and
|
|
// then used exclusively on another thread.
|
|
void Detach();
|
|
|
|
private:
|
|
friend class internal::AnnounceOnThread;
|
|
bool IsCurrent() const { return CalledSequentially(); }
|
|
|
|
typedef const void* QueueId;
|
|
CriticalSection lock_;
|
|
ThreadChecker thread_checker_;
|
|
mutable bool attached_;
|
|
mutable QueueId valid_queue_;
|
|
};
|
|
|
|
} // namespace rtc
|
|
#endif // RTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_
|