mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 06:40:43 +01:00
f70fbc8411
This change introduces a new non-reentrant mutex to WebRTC. It enables eventual migration to Abseil's mutex. The mutex types supportable by webrtc::Mutex are - absl::Mutex - CriticalSection (Windows only) - pthread_mutex (POSIX only) In addition to introducing the mutexes, the CL also changes PacketBuffer to use the new mutex instead of rtc::CriticalSection. The method of yielding from critical_section.cc was given a mini-cleanup and YieldCurrentThread() was added to rtc_base/synchronization/yield.h/cc. Additionally, google_benchmark benchmarks for the mutexes were added (test courtesy of danilchap@), and some results from a pthread/Abseil shootout were added showing Abseil has the advantage in higher contention. Bug: webrtc:11567, webrtc:11634 Change-Id: Iaec324ccb32ec3851bf6db3fd290f5ea5dee4c81 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176230 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31443}
54 lines
1.7 KiB
C++
54 lines
1.7 KiB
C++
/*
|
|
* Copyright 2020 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef RTC_BASE_SYNCHRONIZATION_MUTEX_CRITICAL_SECTION_H_
|
|
#define RTC_BASE_SYNCHRONIZATION_MUTEX_CRITICAL_SECTION_H_
|
|
|
|
#if defined(WEBRTC_WIN)
|
|
// clang-format off
|
|
// clang formating would change include order.
|
|
|
|
// Include winsock2.h before including <windows.h> to maintain consistency with
|
|
// win32.h. To include win32.h directly, it must be broken out into its own
|
|
// build target.
|
|
#include <winsock2.h>
|
|
#include <windows.h>
|
|
#include <sal.h> // must come after windows headers.
|
|
// clang-format on
|
|
|
|
#include "rtc_base/thread_annotations.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class RTC_LOCKABLE MutexImpl final {
|
|
public:
|
|
MutexImpl() { InitializeCriticalSection(&critical_section_); }
|
|
MutexImpl(const MutexImpl&) = delete;
|
|
MutexImpl& operator=(const MutexImpl&) = delete;
|
|
~MutexImpl() { DeleteCriticalSection(&critical_section_); }
|
|
|
|
void Lock() RTC_EXCLUSIVE_LOCK_FUNCTION() {
|
|
EnterCriticalSection(&critical_section_);
|
|
}
|
|
RTC_WARN_UNUSED_RESULT bool TryLock() RTC_EXCLUSIVE_TRYLOCK_FUNCTION(true) {
|
|
return TryEnterCriticalSection(&critical_section_) != FALSE;
|
|
}
|
|
void Unlock() RTC_UNLOCK_FUNCTION() {
|
|
LeaveCriticalSection(&critical_section_);
|
|
}
|
|
|
|
private:
|
|
CRITICAL_SECTION critical_section_;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // #if defined(WEBRTC_WIN)
|
|
#endif // RTC_BASE_SYNCHRONIZATION_MUTEX_CRITICAL_SECTION_H_
|