mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 15:20:42 +01:00

Various places are using "memset(ptr, 0, size)" which might get optimized away by the compiler if "ptr" is not used afterwards. The new functions can be used to securely clear memory instead. Bug: None Change-Id: I067a51d17ff84d95dc4934d46a24027fbcb4825d Reviewed-on: https://webrtc-review.googlesource.com/35500 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Joachim Bauch <jbauch@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21706}
36 lines
1.1 KiB
C++
36 lines
1.1 KiB
C++
/*
|
|
* Copyright 2017 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#if defined(WEBRTC_WIN)
|
|
#include <windows.h>
|
|
#else
|
|
#include <string.h>
|
|
#endif
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/zero_memory.h"
|
|
|
|
namespace rtc {
|
|
|
|
// Code and comment taken from "OPENSSL_cleanse" of BoringSSL.
|
|
void ExplicitZeroMemory(void* ptr, size_t len) {
|
|
RTC_DCHECK(ptr || !len);
|
|
#if defined(WEBRTC_WIN)
|
|
SecureZeroMemory(ptr, len);
|
|
#else
|
|
memset(ptr, 0, len);
|
|
/* As best as we can tell, this is sufficient to break any optimisations that
|
|
might try to eliminate "superfluous" memsets. If there's an easy way to
|
|
detect memset_s, it would be better to use that. */
|
|
__asm__ __volatile__("" : : "r"(ptr) : "memory"); // NOLINT
|
|
#endif
|
|
}
|
|
|
|
} // namespace rtc
|