mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-15 23:01:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/rtc_tools
History
Mirko Bonadei 317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
..
converter Add usage message to rgba_to_i420_converter. 2019-07-19 11:17:04 +00:00
frame_analyzer Add usage message to reference_less_video_analysis. 2019-07-19 09:16:00 +00:00
loopback_test Moving src/webrtc into src/. 2017-09-15 04:25:06 +00:00
network_tester Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
psnr_ssim_analyzer Add usage message to psnr_ssim_analyzer. 2019-07-19 09:11:40 +00:00
py_event_log_analyzer Fix rtp_analyzer tool 2019-07-24 15:15:54 +00:00
rtc_event_log_visualizer Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
rtp_generator Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
testing Revert "Always create output_dir in setup_apprtc.py." 2019-09-04 18:19:12 +00:00
unpack_aecdump Add RTC_ prefix to non-standard format specifier macro "PRIdNS" 2019-08-07 13:36:05 +00:00
author_line_count.sh author_line_count.sh: Move user arguments last 2019-04-01 08:03:05 +00:00
BUILD.gn Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
class_usage.sh Moving src/webrtc into src/. 2017-09-15 04:25:06 +00:00
compare_videos.py Use print() instead of print in rtc_tools/ python scripts. 2019-07-26 06:46:41 +00:00
DEPS Remove +absl/flags exceptions from non root DEPS files. 2019-07-16 16:52:41 +00:00
header_usage.sh header_usage.sh: Keep leading directory for grep. 2017-10-19 13:46:51 +00:00
metrics_plotter.py Fix time units in plotted charts 2019-09-13 13:04:32 +00:00
OWNERS Add magjed as owner of rtc_tools. 2018-11-26 11:30:34 +00:00
sanitizers_unittest.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
video_file_reader.cc Fix -Wunused-result warnings 2019-02-13 09:24:08 +00:00
video_file_reader.h Format almost everything. 2019-07-08 13:45:15 +00:00
video_file_reader_unittest.cc Format almost everything. 2019-07-08 13:45:15 +00:00
video_file_writer.cc Format almost everything. 2019-07-08 13:45:15 +00:00
video_file_writer.h Fix VideoFileWriterTest flakiness by using unique file path. 2019-03-21 11:21:15 +00:00
video_file_writer_unittest.cc Format almost everything. 2019-07-08 13:45:15 +00:00