mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-19 08:37:54 +01:00
492296cc3c
Instead there are direct member variables for the various relevant states, some weren't needed, some can be const but the `id` member in particular needs special handling and can't be const. For dealing with the stream id, we now have SctpSid. A class that does range validation, checks thread safety, handles the special `-1` case (for what's essentially an unsigned 16 bit int). Using a special type for this also has the effect that range checking happens more consistently (although I'm not modifying the structs in api/). With upcoming steps of avoiding thread hops, the ID may need to migrate to the network thread, which the thread checks will help with. Along the way, update SctpSidAllocator to use flat_set instead of std::set and moving some of the sctp data channel code to the cc file to help with more accurately tracking code coverage. Bug: webrtc:11547 Change-Id: Iea6e7647ab8f93052044c5afbcc449115206b4e9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296444 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39539}
242 lines
8.1 KiB
C++
242 lines
8.1 KiB
C++
/*
|
|
* Copyright 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "pc/sctp_utils.h"
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <limits>
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/priority.h"
|
|
#include "media/sctp/sctp_transport_internal.h"
|
|
#include "rtc_base/byte_buffer.h"
|
|
#include "rtc_base/copy_on_write_buffer.h"
|
|
#include "test/gtest.h"
|
|
|
|
using webrtc::StreamId;
|
|
|
|
class SctpUtilsTest : public ::testing::Test {
|
|
public:
|
|
void VerifyOpenMessageFormat(const rtc::CopyOnWriteBuffer& packet,
|
|
const std::string& label,
|
|
const webrtc::DataChannelInit& config) {
|
|
uint8_t message_type;
|
|
uint8_t channel_type;
|
|
uint32_t reliability;
|
|
uint16_t priority;
|
|
uint16_t label_length;
|
|
uint16_t protocol_length;
|
|
|
|
rtc::ByteBufferReader buffer(packet.data<char>(), packet.size());
|
|
ASSERT_TRUE(buffer.ReadUInt8(&message_type));
|
|
EXPECT_EQ(0x03, message_type);
|
|
|
|
ASSERT_TRUE(buffer.ReadUInt8(&channel_type));
|
|
if (config.ordered) {
|
|
EXPECT_EQ(
|
|
config.maxRetransmits ? 0x01 : (config.maxRetransmitTime ? 0x02 : 0),
|
|
channel_type);
|
|
} else {
|
|
EXPECT_EQ(config.maxRetransmits
|
|
? 0x81
|
|
: (config.maxRetransmitTime ? 0x82 : 0x80),
|
|
channel_type);
|
|
}
|
|
|
|
ASSERT_TRUE(buffer.ReadUInt16(&priority));
|
|
if (config.priority) {
|
|
// Exact values are checked by round-trip conversion, but
|
|
// all values defined are greater than zero.
|
|
EXPECT_GT(priority, 0);
|
|
} else {
|
|
EXPECT_EQ(priority, 0);
|
|
}
|
|
|
|
ASSERT_TRUE(buffer.ReadUInt32(&reliability));
|
|
if (config.maxRetransmits || config.maxRetransmitTime) {
|
|
EXPECT_EQ(config.maxRetransmits ? *config.maxRetransmits
|
|
: *config.maxRetransmitTime,
|
|
static_cast<int>(reliability));
|
|
}
|
|
|
|
ASSERT_TRUE(buffer.ReadUInt16(&label_length));
|
|
ASSERT_TRUE(buffer.ReadUInt16(&protocol_length));
|
|
EXPECT_EQ(label.size(), label_length);
|
|
EXPECT_EQ(config.protocol.size(), protocol_length);
|
|
|
|
std::string label_output;
|
|
ASSERT_TRUE(buffer.ReadString(&label_output, label_length));
|
|
EXPECT_EQ(label, label_output);
|
|
std::string protocol_output;
|
|
ASSERT_TRUE(buffer.ReadString(&protocol_output, protocol_length));
|
|
EXPECT_EQ(config.protocol, protocol_output);
|
|
}
|
|
};
|
|
|
|
TEST_F(SctpUtilsTest, WriteParseOpenMessageWithOrderedReliable) {
|
|
webrtc::DataChannelInit config;
|
|
std::string label = "abc";
|
|
config.protocol = "y";
|
|
|
|
rtc::CopyOnWriteBuffer packet;
|
|
ASSERT_TRUE(webrtc::WriteDataChannelOpenMessage(label, config, &packet));
|
|
|
|
VerifyOpenMessageFormat(packet, label, config);
|
|
|
|
std::string output_label;
|
|
webrtc::DataChannelInit output_config;
|
|
ASSERT_TRUE(webrtc::ParseDataChannelOpenMessage(packet, &output_label,
|
|
&output_config));
|
|
|
|
EXPECT_EQ(label, output_label);
|
|
EXPECT_EQ(config.protocol, output_config.protocol);
|
|
EXPECT_EQ(config.ordered, output_config.ordered);
|
|
EXPECT_EQ(config.maxRetransmitTime, output_config.maxRetransmitTime);
|
|
EXPECT_EQ(config.maxRetransmits, output_config.maxRetransmits);
|
|
}
|
|
|
|
TEST_F(SctpUtilsTest, WriteParseOpenMessageWithMaxRetransmitTime) {
|
|
webrtc::DataChannelInit config;
|
|
std::string label = "abc";
|
|
config.ordered = false;
|
|
config.maxRetransmitTime = 10;
|
|
config.protocol = "y";
|
|
|
|
rtc::CopyOnWriteBuffer packet;
|
|
ASSERT_TRUE(webrtc::WriteDataChannelOpenMessage(label, config, &packet));
|
|
|
|
VerifyOpenMessageFormat(packet, label, config);
|
|
|
|
std::string output_label;
|
|
webrtc::DataChannelInit output_config;
|
|
ASSERT_TRUE(webrtc::ParseDataChannelOpenMessage(packet, &output_label,
|
|
&output_config));
|
|
|
|
EXPECT_EQ(label, output_label);
|
|
EXPECT_EQ(config.protocol, output_config.protocol);
|
|
EXPECT_EQ(config.ordered, output_config.ordered);
|
|
EXPECT_EQ(*config.maxRetransmitTime, *output_config.maxRetransmitTime);
|
|
EXPECT_FALSE(output_config.maxRetransmits);
|
|
}
|
|
|
|
TEST_F(SctpUtilsTest, WriteParseOpenMessageWithMaxRetransmits) {
|
|
webrtc::DataChannelInit config;
|
|
std::string label = "abc";
|
|
config.maxRetransmits = 10;
|
|
config.protocol = "y";
|
|
|
|
rtc::CopyOnWriteBuffer packet;
|
|
ASSERT_TRUE(webrtc::WriteDataChannelOpenMessage(label, config, &packet));
|
|
|
|
VerifyOpenMessageFormat(packet, label, config);
|
|
|
|
std::string output_label;
|
|
webrtc::DataChannelInit output_config;
|
|
ASSERT_TRUE(webrtc::ParseDataChannelOpenMessage(packet, &output_label,
|
|
&output_config));
|
|
|
|
EXPECT_EQ(label, output_label);
|
|
EXPECT_EQ(config.protocol, output_config.protocol);
|
|
EXPECT_EQ(config.ordered, output_config.ordered);
|
|
EXPECT_EQ(config.maxRetransmits, output_config.maxRetransmits);
|
|
EXPECT_FALSE(output_config.maxRetransmitTime);
|
|
}
|
|
|
|
TEST_F(SctpUtilsTest, WriteParseOpenMessageWithPriority) {
|
|
webrtc::DataChannelInit config;
|
|
std::string label = "abc";
|
|
config.protocol = "y";
|
|
config.priority = webrtc::Priority::kVeryLow;
|
|
|
|
rtc::CopyOnWriteBuffer packet;
|
|
ASSERT_TRUE(webrtc::WriteDataChannelOpenMessage(label, config, &packet));
|
|
|
|
VerifyOpenMessageFormat(packet, label, config);
|
|
|
|
std::string output_label;
|
|
webrtc::DataChannelInit output_config;
|
|
ASSERT_TRUE(webrtc::ParseDataChannelOpenMessage(packet, &output_label,
|
|
&output_config));
|
|
|
|
EXPECT_EQ(label, output_label);
|
|
ASSERT_TRUE(output_config.priority);
|
|
EXPECT_EQ(*config.priority, *output_config.priority);
|
|
}
|
|
|
|
TEST_F(SctpUtilsTest, WriteParseAckMessage) {
|
|
rtc::CopyOnWriteBuffer packet;
|
|
webrtc::WriteDataChannelOpenAckMessage(&packet);
|
|
|
|
uint8_t message_type;
|
|
rtc::ByteBufferReader buffer(packet.data<char>(), packet.size());
|
|
ASSERT_TRUE(buffer.ReadUInt8(&message_type));
|
|
EXPECT_EQ(0x02, message_type);
|
|
|
|
EXPECT_TRUE(webrtc::ParseDataChannelOpenAckMessage(packet));
|
|
}
|
|
|
|
TEST_F(SctpUtilsTest, TestIsOpenMessage) {
|
|
rtc::CopyOnWriteBuffer open(1);
|
|
open.MutableData()[0] = 0x03;
|
|
EXPECT_TRUE(webrtc::IsOpenMessage(open));
|
|
|
|
rtc::CopyOnWriteBuffer openAck(1);
|
|
openAck.MutableData()[0] = 0x02;
|
|
EXPECT_FALSE(webrtc::IsOpenMessage(openAck));
|
|
|
|
rtc::CopyOnWriteBuffer invalid(1);
|
|
invalid.MutableData()[0] = 0x01;
|
|
EXPECT_FALSE(webrtc::IsOpenMessage(invalid));
|
|
|
|
rtc::CopyOnWriteBuffer empty;
|
|
EXPECT_FALSE(webrtc::IsOpenMessage(empty));
|
|
}
|
|
|
|
TEST(SctpSidTest, Basics) {
|
|
// These static asserts are mostly here to aid with readability (i.e. knowing
|
|
// what these constants represent).
|
|
static_assert(cricket::kMinSctpSid == 0, "Min stream id should be 0");
|
|
static_assert(cricket::kMaxSctpSid <= cricket::kSpecMaxSctpSid, "");
|
|
static_assert(
|
|
cricket::kSpecMaxSctpSid == std::numeric_limits<uint16_t>::max(),
|
|
"Max legal sctp stream value should be 0xffff");
|
|
|
|
// cricket::kMaxSctpSid is a chosen value in the webrtc implementation,
|
|
// the highest generated `sid` value chosen for resource reservation reasons.
|
|
// It's one less than kMaxSctpStreams (1024) or 1023 since sid values are
|
|
// zero based.
|
|
|
|
EXPECT_TRUE(!StreamId(-1).HasValue());
|
|
EXPECT_TRUE(!StreamId(-2).HasValue());
|
|
EXPECT_TRUE(StreamId(cricket::kMinSctpSid).HasValue());
|
|
EXPECT_TRUE(StreamId(cricket::kMinSctpSid + 1).HasValue());
|
|
EXPECT_TRUE(StreamId(cricket::kSpecMaxSctpSid).HasValue());
|
|
EXPECT_TRUE(StreamId(cricket::kMaxSctpSid).HasValue());
|
|
|
|
// Two illegal values are equal (both not valid).
|
|
EXPECT_EQ(StreamId(-1), StreamId(-2));
|
|
// Two different, but legal, values, are not equal.
|
|
EXPECT_NE(StreamId(1), StreamId(2));
|
|
// Test operator<() for container compatibility.
|
|
EXPECT_LT(StreamId(1), StreamId(2));
|
|
|
|
// Test assignment, value() and reset().
|
|
StreamId sid1;
|
|
StreamId sid2(cricket::kMaxSctpSid);
|
|
EXPECT_NE(sid1, sid2);
|
|
sid1 = sid2;
|
|
EXPECT_EQ(sid1, sid2);
|
|
|
|
EXPECT_EQ(sid1.stream_id_int(), cricket::kMaxSctpSid);
|
|
EXPECT_TRUE(sid1.HasValue());
|
|
sid1.reset();
|
|
EXPECT_FALSE(sid1.HasValue());
|
|
}
|