mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-15 14:50:39 +01:00
efc9a14a2b
Make AddKnownId() return a value to indicate whether the ID was known before, or has only been made known now. This allows users of the class to RTC_DCHECK that no collisions existed in their seed set, for instance. This change is done for the following classes: 1. UniqueNumberGenerator 2. UniqueRandomIdGenerator 3. UniqueStringGenerator Bug: None Change-Id: I627d2821cb76aa333075e36575088d76dbeb3665 Reviewed-on: https://webrtc-review.googlesource.com/c/121780 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Amit Hilbuch <amithi@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26621}
65 lines
2 KiB
C++
65 lines
2 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/unique_id_generator.h"
|
|
|
|
#include <limits>
|
|
#include <vector>
|
|
|
|
#include "rtc_base/helpers.h"
|
|
#include "rtc_base/string_encode.h"
|
|
#include "rtc_base/string_to_number.h"
|
|
|
|
namespace rtc {
|
|
|
|
UniqueRandomIdGenerator::UniqueRandomIdGenerator() : known_ids_() {}
|
|
UniqueRandomIdGenerator::UniqueRandomIdGenerator(ArrayView<uint32_t> known_ids)
|
|
: known_ids_(known_ids.begin(), known_ids.end()) {}
|
|
|
|
UniqueRandomIdGenerator::~UniqueRandomIdGenerator() = default;
|
|
|
|
uint32_t UniqueRandomIdGenerator::GenerateId() {
|
|
RTC_CHECK_LT(known_ids_.size(), std::numeric_limits<uint32_t>::max() - 1);
|
|
while (true) {
|
|
auto pair = known_ids_.insert(CreateRandomNonZeroId());
|
|
if (pair.second) {
|
|
return *pair.first;
|
|
}
|
|
}
|
|
}
|
|
|
|
bool UniqueRandomIdGenerator::AddKnownId(uint32_t value) {
|
|
return known_ids_.insert(value).second;
|
|
}
|
|
|
|
UniqueStringGenerator::UniqueStringGenerator() : unique_number_generator_() {}
|
|
UniqueStringGenerator::UniqueStringGenerator(ArrayView<std::string> known_ids) {
|
|
for (const std::string& str : known_ids) {
|
|
AddKnownId(str);
|
|
}
|
|
}
|
|
|
|
UniqueStringGenerator::~UniqueStringGenerator() = default;
|
|
|
|
std::string UniqueStringGenerator::GenerateString() {
|
|
return ToString(unique_number_generator_.GenerateNumber());
|
|
}
|
|
|
|
bool UniqueStringGenerator::AddKnownId(const std::string& value) {
|
|
absl::optional<uint32_t> int_value = StringToNumber<uint32_t>(value);
|
|
// The underlying generator works for uint32_t values, so if the provided
|
|
// value is not a uint32_t it will never be generated anyway.
|
|
if (int_value.has_value()) {
|
|
return unique_number_generator_.AddKnownId(int_value.value());
|
|
}
|
|
return false;
|
|
}
|
|
|
|
} // namespace rtc
|