mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 22:00:47 +01:00
6866dc7806
This reverts commit28685dc08c. Reason for revert: Speculative reland after looking into downstream failures. It's possible that carryover state from unrelated tests running in parallel was causing failures. Original change's description: > Revert "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase." > > This reverts commit46b3bc6c24. > > Reason for revert: Speculative revert. Breaks downstream project > > Original change's description: > > Make sure that "current" rtc::Thread instances are always current for TaskQueueBase. > > > > This is a necessary part of fulfilling the TaskQueueBase > > interface. If a thread does not register as the current TQ, yet offers > > the TQ interface, TQ 'current' checks will not work as expected and > > code that relies them (TaskQueueBase::Current() and IsCurrent()) > > will run in unexpected ways. > > > > Bug: webrtc:11572 > > Change-Id: Iab747bc474e74e6ce4f9e914cfd5b0578b19d19c > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175080 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Tommi <tommi@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#31254} > > TBR=mbonadei@webrtc.org,tommi@webrtc.org > > Change-Id: I69ff3355f0ec447b25604bd95fdacbdb4d4f3f27 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:11572 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175104 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31259} TBR=mbonadei@webrtc.org,tommi@webrtc.org,titovartem@webrtc.org # Not skipping CQ checks because this is a reland. Bug: webrtc:11572 Change-Id: I00c82d99af8e05851769e09cb682b5b73895a6f3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175133 Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31273}
60 lines
1.4 KiB
C++
60 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2020 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "test/run_loop.h"
|
|
|
|
#include "rtc_base/task_queue.h"
|
|
#include "rtc_base/task_utils/to_queued_task.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(RunLoopTest, TaskQueueOnThread) {
|
|
test::RunLoop loop;
|
|
EXPECT_EQ(TaskQueueBase::Current(), loop.task_queue());
|
|
EXPECT_TRUE(loop.task_queue()->IsCurrent());
|
|
}
|
|
|
|
TEST(RunLoopTest, Flush) {
|
|
test::RunLoop loop;
|
|
int counter = 0;
|
|
loop.PostTask([&counter]() { ++counter; });
|
|
EXPECT_EQ(counter, 0);
|
|
loop.Flush();
|
|
EXPECT_EQ(counter, 1);
|
|
}
|
|
|
|
TEST(RunLoopTest, Delayed) {
|
|
test::RunLoop loop;
|
|
bool ran = false;
|
|
loop.PostDelayedTask(
|
|
[&ran, &loop]() {
|
|
ran = true;
|
|
loop.Quit();
|
|
},
|
|
100);
|
|
loop.Flush();
|
|
EXPECT_FALSE(ran);
|
|
loop.Run();
|
|
EXPECT_TRUE(ran);
|
|
}
|
|
|
|
TEST(RunLoopTest, PostAndQuit) {
|
|
test::RunLoop loop;
|
|
bool ran = false;
|
|
loop.PostTask([&ran, &loop]() {
|
|
ran = true;
|
|
loop.Quit();
|
|
});
|
|
loop.Run();
|
|
EXPECT_TRUE(ran);
|
|
}
|
|
|
|
} // namespace webrtc
|