webrtc/test/testsupport/video_frame_writer.cc
Mirko Bonadei 317a1f09ed Use std::make_unique instead of absl::make_unique.
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00

111 lines
4.1 KiB
C++

/*
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "test/testsupport/video_frame_writer.h"
#include <cmath>
#include <cstdlib>
#include <limits>
#include <memory>
#include <utility>
#include "api/scoped_refptr.h"
#include "api/video/i420_buffer.h"
#include "common_video/libyuv/include/webrtc_libyuv.h"
#include "rtc_base/logging.h"
namespace webrtc {
namespace test {
namespace {
rtc::Buffer ExtractI420BufferWithSize(const VideoFrame& frame,
int width,
int height) {
if (frame.width() != width || frame.height() != height) {
RTC_CHECK_LE(std::abs(static_cast<double>(width) / height -
static_cast<double>(frame.width()) / frame.height()),
2 * std::numeric_limits<double>::epsilon());
// Same aspect ratio, no cropping needed.
rtc::scoped_refptr<I420Buffer> scaled(I420Buffer::Create(width, height));
scaled->ScaleFrom(*frame.video_frame_buffer()->ToI420());
size_t length =
CalcBufferSize(VideoType::kI420, scaled->width(), scaled->height());
rtc::Buffer buffer(length);
RTC_CHECK_NE(ExtractBuffer(scaled, length, buffer.data()), -1);
return buffer;
}
// No resize.
size_t length =
CalcBufferSize(VideoType::kI420, frame.width(), frame.height());
rtc::Buffer buffer(length);
RTC_CHECK_NE(ExtractBuffer(frame, length, buffer.data()), -1);
return buffer;
}
} // namespace
Y4mVideoFrameWriterImpl::Y4mVideoFrameWriterImpl(std::string output_file_name,
int width,
int height,
int fps)
// We will move string here to prevent extra copy. We won't use const ref
// to not corrupt caller variable with move and don't assume that caller's
// variable won't be destructed before writer.
: width_(width),
height_(height),
frame_writer_(
std::make_unique<Y4mFrameWriterImpl>(std::move(output_file_name),
width_,
height_,
fps)) {
// Init underlying frame writer and ensure that it is operational.
RTC_CHECK(frame_writer_->Init());
}
bool Y4mVideoFrameWriterImpl::WriteFrame(const webrtc::VideoFrame& frame) {
rtc::Buffer frame_buffer = ExtractI420BufferWithSize(frame, width_, height_);
RTC_CHECK_EQ(frame_buffer.size(), frame_writer_->FrameLength());
return frame_writer_->WriteFrame(frame_buffer.data());
}
void Y4mVideoFrameWriterImpl::Close() {
frame_writer_->Close();
}
YuvVideoFrameWriterImpl::YuvVideoFrameWriterImpl(std::string output_file_name,
int width,
int height)
// We will move string here to prevent extra copy. We won't use const ref
// to not corrupt caller variable with move and don't assume that caller's
// variable won't be destructed before writer.
: width_(width),
height_(height),
frame_writer_(
std::make_unique<YuvFrameWriterImpl>(std::move(output_file_name),
width_,
height_)) {
// Init underlying frame writer and ensure that it is operational.
RTC_CHECK(frame_writer_->Init());
}
bool YuvVideoFrameWriterImpl::WriteFrame(const webrtc::VideoFrame& frame) {
rtc::Buffer frame_buffer = ExtractI420BufferWithSize(frame, width_, height_);
RTC_CHECK_EQ(frame_buffer.size(), frame_writer_->FrameLength());
return frame_writer_->WriteFrame(frame_buffer.data());
}
void YuvVideoFrameWriterImpl::Close() {
frame_writer_->Close();
}
} // namespace test
} // namespace webrtc