mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
c14a2cb9cc
which needs to be added to the remote codecs a=fmtp: This also forces SimulcastCastEncoderAdapter to avoid issues with codecs that have native simulcast capability but do require synchronized keyframes. This parameter allows for large-scale experimentation and A/B testing whether the new behavior has advantages. It is to be considered transitional and may be removed again in the future. BUG=webrtc:10107 Change-Id: I81f496c987b2fed7ff3089efb746e7e89e89c033 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333560 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41805}
158 lines
6 KiB
C++
158 lines
6 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "media/base/sdp_video_format_utils.h"
|
|
|
|
#include <string.h>
|
|
|
|
#include <map>
|
|
#include <utility>
|
|
|
|
#include "rtc_base/string_to_number.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
// Max frame rate for VP8 and VP9 video.
|
|
const char kVPxFmtpMaxFrameRate[] = "max-fr";
|
|
// Max frame size for VP8 and VP9 video.
|
|
const char kVPxFmtpMaxFrameSize[] = "max-fs";
|
|
// Nonstandard per-layer PLI for video.
|
|
const char kCodecParamPerLayerPictureLossIndication[] =
|
|
"x-google-per-layer-pli";
|
|
} // namespace
|
|
|
|
TEST(SdpVideoFormatUtilsTest, TestH264GenerateProfileLevelIdForAnswerEmpty) {
|
|
CodecParameterMap answer_params;
|
|
H264GenerateProfileLevelIdForAnswer(CodecParameterMap(), CodecParameterMap(),
|
|
&answer_params);
|
|
EXPECT_TRUE(answer_params.empty());
|
|
}
|
|
|
|
TEST(SdpVideoFormatUtilsTest,
|
|
TestH264GenerateProfileLevelIdForAnswerLevelSymmetryCapped) {
|
|
CodecParameterMap low_level;
|
|
low_level["profile-level-id"] = "42e015";
|
|
CodecParameterMap high_level;
|
|
high_level["profile-level-id"] = "42e01f";
|
|
|
|
// Level asymmetry is not allowed; test that answer level is the lower of the
|
|
// local and remote levels.
|
|
CodecParameterMap answer_params;
|
|
H264GenerateProfileLevelIdForAnswer(low_level /* local_supported */,
|
|
high_level /* remote_offered */,
|
|
&answer_params);
|
|
EXPECT_EQ("42e015", answer_params["profile-level-id"]);
|
|
|
|
CodecParameterMap answer_params2;
|
|
H264GenerateProfileLevelIdForAnswer(high_level /* local_supported */,
|
|
low_level /* remote_offered */,
|
|
&answer_params2);
|
|
EXPECT_EQ("42e015", answer_params2["profile-level-id"]);
|
|
}
|
|
|
|
TEST(SdpVideoFormatUtilsTest,
|
|
TestH264GenerateProfileLevelIdForAnswerConstrainedBaselineLevelAsymmetry) {
|
|
CodecParameterMap local_params;
|
|
local_params["profile-level-id"] = "42e01f";
|
|
local_params["level-asymmetry-allowed"] = "1";
|
|
CodecParameterMap remote_params;
|
|
remote_params["profile-level-id"] = "42e015";
|
|
remote_params["level-asymmetry-allowed"] = "1";
|
|
CodecParameterMap answer_params;
|
|
H264GenerateProfileLevelIdForAnswer(local_params, remote_params,
|
|
&answer_params);
|
|
// When level asymmetry is allowed, we can answer a higher level than what was
|
|
// offered.
|
|
EXPECT_EQ("42e01f", answer_params["profile-level-id"]);
|
|
}
|
|
|
|
#ifdef RTC_ENABLE_H265
|
|
// Answer should not include explicit PTL info if neither local nor remote set
|
|
// any of them.
|
|
TEST(SdpVideoFormatUtilsTest, H265GenerateProfileTierLevelEmpty) {
|
|
CodecParameterMap answer_params;
|
|
H265GenerateProfileTierLevelForAnswer(CodecParameterMap(),
|
|
CodecParameterMap(), &answer_params);
|
|
EXPECT_TRUE(answer_params.empty());
|
|
}
|
|
|
|
// Answer must use the minimum level as supported by both local and remote.
|
|
TEST(SdpVideoFormatUtilsTest, H265GenerateProfileTierLevelNoEmpty) {
|
|
constexpr char kLocallySupportedLevelId[] = "93";
|
|
constexpr char kRemoteOfferedLevelId[] = "120";
|
|
|
|
CodecParameterMap local_params;
|
|
local_params["profile-id"] = "1";
|
|
local_params["tier-flag"] = "0";
|
|
local_params["level-id"] = kLocallySupportedLevelId;
|
|
CodecParameterMap remote_params;
|
|
remote_params["profile-id"] = "1";
|
|
remote_params["tier-flag"] = "0";
|
|
remote_params["level-id"] = kRemoteOfferedLevelId;
|
|
CodecParameterMap answer_params;
|
|
H265GenerateProfileTierLevelForAnswer(local_params, remote_params,
|
|
&answer_params);
|
|
EXPECT_EQ(kLocallySupportedLevelId, answer_params["level-id"]);
|
|
}
|
|
#endif
|
|
|
|
TEST(SdpVideoFormatUtilsTest, MaxFrameRateIsMissingOrInvalid) {
|
|
CodecParameterMap params;
|
|
absl::optional<int> empty = ParseSdpForVPxMaxFrameRate(params);
|
|
EXPECT_FALSE(empty);
|
|
params[kVPxFmtpMaxFrameRate] = "-1";
|
|
EXPECT_FALSE(ParseSdpForVPxMaxFrameRate(params));
|
|
params[kVPxFmtpMaxFrameRate] = "0";
|
|
EXPECT_FALSE(ParseSdpForVPxMaxFrameRate(params));
|
|
params[kVPxFmtpMaxFrameRate] = "abcde";
|
|
EXPECT_FALSE(ParseSdpForVPxMaxFrameRate(params));
|
|
}
|
|
|
|
TEST(SdpVideoFormatUtilsTest, MaxFrameRateIsSpecified) {
|
|
CodecParameterMap params;
|
|
params[kVPxFmtpMaxFrameRate] = "30";
|
|
EXPECT_EQ(ParseSdpForVPxMaxFrameRate(params), 30);
|
|
params[kVPxFmtpMaxFrameRate] = "60";
|
|
EXPECT_EQ(ParseSdpForVPxMaxFrameRate(params), 60);
|
|
}
|
|
|
|
TEST(SdpVideoFormatUtilsTest, MaxFrameSizeIsMissingOrInvalid) {
|
|
CodecParameterMap params;
|
|
absl::optional<int> empty = ParseSdpForVPxMaxFrameSize(params);
|
|
EXPECT_FALSE(empty);
|
|
params[kVPxFmtpMaxFrameSize] = "-1";
|
|
EXPECT_FALSE(ParseSdpForVPxMaxFrameSize(params));
|
|
params[kVPxFmtpMaxFrameSize] = "0";
|
|
EXPECT_FALSE(ParseSdpForVPxMaxFrameSize(params));
|
|
params[kVPxFmtpMaxFrameSize] = "abcde";
|
|
EXPECT_FALSE(ParseSdpForVPxMaxFrameSize(params));
|
|
}
|
|
|
|
TEST(SdpVideoFormatUtilsTest, MaxFrameSizeIsSpecified) {
|
|
CodecParameterMap params;
|
|
params[kVPxFmtpMaxFrameSize] = "8100"; // 1920 x 1080 / (16^2)
|
|
EXPECT_EQ(ParseSdpForVPxMaxFrameSize(params), 1920 * 1080);
|
|
params[kVPxFmtpMaxFrameSize] = "32400"; // 3840 x 2160 / (16^2)
|
|
EXPECT_EQ(ParseSdpForVPxMaxFrameSize(params), 3840 * 2160);
|
|
}
|
|
|
|
TEST(SdpVideoFormatUtilsTest, PerLayerPictureLossIndication) {
|
|
CodecParameterMap params;
|
|
EXPECT_FALSE(SupportsPerLayerPictureLossIndication(params));
|
|
params[kCodecParamPerLayerPictureLossIndication] = "wrong";
|
|
EXPECT_FALSE(SupportsPerLayerPictureLossIndication(params));
|
|
params[kCodecParamPerLayerPictureLossIndication] = "0";
|
|
EXPECT_FALSE(SupportsPerLayerPictureLossIndication(params));
|
|
params[kCodecParamPerLayerPictureLossIndication] = "1";
|
|
EXPECT_TRUE(SupportsPerLayerPictureLossIndication(params));
|
|
}
|
|
|
|
} // namespace webrtc
|