mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-18 08:07:56 +01:00

Failing a DCHECK on a ChannelReceiver having its encoded transform set more than once contradicts the comment above - this can happen when reconfiguring a channel, eg as in the web platform test webrtc/recvonly-transceiver-can-become-sendrecv.https.html. It was added after the original code by a different author, and indeed the video side doesn't have such a check. Bug: chromium:1502781 Change-Id: Id36e52601da34ebc194ff058e4672046379f576e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328560 Commit-Queue: Tony Herre <herre@google.com> Auto-Submit: Tony Herre <herre@google.com> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41246}
81 lines
3.1 KiB
C++
81 lines
3.1 KiB
C++
/*
|
|
* Copyright (c) 2020 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef AUDIO_CHANNEL_RECEIVE_FRAME_TRANSFORMER_DELEGATE_H_
|
|
#define AUDIO_CHANNEL_RECEIVE_FRAME_TRANSFORMER_DELEGATE_H_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "api/frame_transformer_interface.h"
|
|
#include "api/sequence_checker.h"
|
|
#include "rtc_base/system/no_unique_address.h"
|
|
#include "rtc_base/task_queue.h"
|
|
#include "rtc_base/thread.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Delegates calls to FrameTransformerInterface to transform frames, and to
|
|
// ChannelReceive to receive the transformed frames using the
|
|
// `receive_frame_callback_` on the `channel_receive_thread_`.
|
|
class ChannelReceiveFrameTransformerDelegate : public TransformedFrameCallback {
|
|
public:
|
|
using ReceiveFrameCallback =
|
|
std::function<void(rtc::ArrayView<const uint8_t> packet,
|
|
const RTPHeader& header)>;
|
|
ChannelReceiveFrameTransformerDelegate(
|
|
ReceiveFrameCallback receive_frame_callback,
|
|
rtc::scoped_refptr<FrameTransformerInterface> frame_transformer,
|
|
TaskQueueBase* channel_receive_thread);
|
|
|
|
// Registers `this` as callback for `frame_transformer_`, to get the
|
|
// transformed frames.
|
|
void Init();
|
|
|
|
// Unregisters and releases the `frame_transformer_` reference, and resets
|
|
// `receive_frame_callback_` on `channel_receive_thread_`. Called from
|
|
// ChannelReceive destructor to prevent running the callback on a dangling
|
|
// channel.
|
|
void Reset();
|
|
|
|
// Delegates the call to FrameTransformerInterface::Transform, to transform
|
|
// the frame asynchronously.
|
|
void Transform(rtc::ArrayView<const uint8_t> packet,
|
|
const RTPHeader& header,
|
|
uint32_t ssrc,
|
|
const std::string& codec_mime_type);
|
|
|
|
// Implements TransformedFrameCallback. Can be called on any thread.
|
|
void OnTransformedFrame(
|
|
std::unique_ptr<TransformableFrameInterface> frame) override;
|
|
|
|
void StartShortCircuiting() override;
|
|
|
|
// Delegates the call to ChannelReceive::OnReceivedPayloadData on the
|
|
// `channel_receive_thread_`, by calling `receive_frame_callback_`.
|
|
void ReceiveFrame(std::unique_ptr<TransformableFrameInterface> frame) const;
|
|
|
|
rtc::scoped_refptr<FrameTransformerInterface> FrameTransformer();
|
|
|
|
protected:
|
|
~ChannelReceiveFrameTransformerDelegate() override = default;
|
|
|
|
private:
|
|
RTC_NO_UNIQUE_ADDRESS SequenceChecker sequence_checker_;
|
|
ReceiveFrameCallback receive_frame_callback_
|
|
RTC_GUARDED_BY(sequence_checker_);
|
|
rtc::scoped_refptr<FrameTransformerInterface> frame_transformer_
|
|
RTC_GUARDED_BY(sequence_checker_);
|
|
TaskQueueBase* const channel_receive_thread_;
|
|
bool short_circuit_ RTC_GUARDED_BY(sequence_checker_) = false;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
#endif // AUDIO_CHANNEL_RECEIVE_FRAME_TRANSFORMER_DELEGATE_H_
|