mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 22:00:47 +01:00

This CL: - makes it easier to understand the (nontrivial) metric interpretation - corrects the computation of BufferDelay to use 0 for absent delay - deletes metric MaxSkewShiftCount, unused since https://webrtc-review.googlesource.com/c/src/+/119701 - updates the unit test to directly test metric reporting Corresponding update to histograms.xml: https://crrev.com/c/3944909 Previous revert: https://webrtc-review.googlesource.com/c/src/+/279040 This CL is identical to the original, except: - the test is updated to spam fewer EXPECT_EQ failures on failure (EXPECT_EQs moved out of inner loop) - the test not resets metrics (metrics::Reset()) at the beginning, like other histogram tests Bug: webrtc:8671, chromium:1349051 Change-Id: Ie802e1f9d03a22ff7018f522a63b19e0b6eec2e8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279046 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38376}
49 lines
1.5 KiB
C++
49 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef MODULES_AUDIO_PROCESSING_AEC3_RENDER_DELAY_CONTROLLER_METRICS_H_
|
|
#define MODULES_AUDIO_PROCESSING_AEC3_RENDER_DELAY_CONTROLLER_METRICS_H_
|
|
|
|
#include <stddef.h>
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "modules/audio_processing/aec3/clockdrift_detector.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Handles the reporting of metrics for the render delay controller.
|
|
class RenderDelayControllerMetrics {
|
|
public:
|
|
RenderDelayControllerMetrics();
|
|
|
|
RenderDelayControllerMetrics(const RenderDelayControllerMetrics&) = delete;
|
|
RenderDelayControllerMetrics& operator=(const RenderDelayControllerMetrics&) =
|
|
delete;
|
|
|
|
// Updates the metric with new data.
|
|
void Update(absl::optional<size_t> delay_samples,
|
|
absl::optional<size_t> buffer_delay_blocks,
|
|
ClockdriftDetector::Level clockdrift);
|
|
|
|
private:
|
|
// Resets the metrics.
|
|
void ResetMetrics();
|
|
|
|
size_t delay_blocks_ = 0;
|
|
int reliable_delay_estimate_counter_ = 0;
|
|
int delay_change_counter_ = 0;
|
|
int call_counter_ = 0;
|
|
int initial_call_counter_ = 0;
|
|
bool initial_update = true;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // MODULES_AUDIO_PROCESSING_AEC3_RENDER_DELAY_CONTROLLER_METRICS_H_
|