mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 06:10:40 +01:00
80f53b785b
The experiment was extended to support per-codec minimum bitrates for the following codecs: * VP8 * VP9 * H.264 The old semantic meaning for the field trial is retained, in that specifying "br:" applies a minimum bitrate to all codecs. If "br:" is not specified, the per-codec minimum config is consulted. Bug: webrtc:11024 Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Reviewed-by: Ying Wang <yinwa@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29450}
161 lines
6.6 KiB
C++
161 lines
6.6 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/experiments/min_video_bitrate_experiment.h"
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/units/data_rate.h"
|
|
#include "api/video/video_codec_type.h"
|
|
#include "test/field_trial.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
NulloptForAllCodecsIfFieldTrialUndefined) {
|
|
test::ScopedFieldTrials field_trials("");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::nullopt);
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
NulloptForAllCodecsIfFieldTrialDisabled) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/Disabled,br:123kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::nullopt);
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest, BrForAllCodecsIfDefined) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/Enabled,br:123kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest, BrTrumpsSpecificCodecConfigs) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,br:123kbps,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::make_optional(DataRate::kbps(123)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
SpecificCodecConfigsIgnoredIfExpDisabled) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Disabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::nullopt);
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest, SpecificCodecConfigsUsedIfExpEnabled) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::kbps(100)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::kbps(200)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::kbps(300)));
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::nullopt);
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
Vp8BitrateValueTakenFromFallbackIfAvailable) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/"
|
|
"WebRTC-VP8-Forced-Fallback-Encoder-v2/"
|
|
"Enabled-444444,555555,666666/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP8),
|
|
absl::make_optional(DataRate::bps(666666)));
|
|
}
|
|
|
|
TEST(GetExperimentalMinVideoBitrateTest,
|
|
NonVp8BitrateValuesTakenFromMinVideoBitrate) {
|
|
test::ScopedFieldTrials field_trials(
|
|
"WebRTC-Video-MinVideoBitrate/"
|
|
"Enabled,vp8_br:100kbps,vp9_br:200kbps,h264_br:300kbps/"
|
|
"WebRTC-VP8-Forced-Fallback-Encoder-v2/"
|
|
"Enabled-444444,555555,666666/");
|
|
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecGeneric),
|
|
absl::nullopt);
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecVP9),
|
|
absl::make_optional(DataRate::kbps(200)));
|
|
EXPECT_EQ(GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecH264),
|
|
absl::make_optional(DataRate::kbps(300)));
|
|
EXPECT_EQ(
|
|
GetExperimentalMinVideoBitrate(VideoCodecType::kVideoCodecMultiplex),
|
|
absl::nullopt);
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace webrtc
|