mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-19 16:47:50 +01:00
c35333d1fd
This CL adds macros to correctly export template instantiation declarations and definitions. These macros have been borrowed from Chromium's //base/export_template.h [1] and are supposed to be used together with RTC_EXPORT [2]. The goal is to start using explicit template instatiation declarations (introduced in C++11) [3] and remove workarounds that are not compatible with all the compilers. An example can be found in [4], where in order to workaround crbug.com/1018579, another workaround was almost created before being stopped at code review time. [1] - https://cs.chromium.org/chromium/src/base/export_template.h [2] - https://cs.chromium.org/chromium/src/third_party/webrtc/rtc_base/system/rtc_export.h [3] - https://en.cppreference.com/w/cpp/language/class_template#Explicit_instantiation [4] - https://webrtc-review.googlesource.com/c/src/+/158674 Bug: webrtc:9419 Change-Id: I2e9287a15e28f619462e0b9a5deb0b672be248c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158742 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29661} |
||
|---|---|---|
| .. | ||
| arch.h | ||
| asm_defines.h | ||
| BUILD.gn | ||
| cocoa_threading.h | ||
| cocoa_threading.mm | ||
| DEPS | ||
| fallthrough.h | ||
| file_wrapper.cc | ||
| file_wrapper.h | ||
| ignore_warnings.h | ||
| inline.h | ||
| rtc_export.h | ||
| rtc_export_template.h | ||
| thread_registry.cc | ||
| thread_registry.h | ||
| unused.h | ||
| warn_current_thread_is_deadlocked.cc | ||
| warn_current_thread_is_deadlocked.h | ||