mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00

This patch is a follow up to https://webrtc-review.googlesource.com/c/src/+/260943 which made it possible to destroy a Port before a Connection (on that port). This patch "reverses" this, by adding RTC_DHECK, and fixes the Port destructor to release the Connections before invalidating the WeakPtr<>. Currently there are no known occurrences where a Connection is destroyed after it's Port is. But prior to the change in Port destructor, a bunch unit tests failed on the newly added DCHECKs. In addition: a) modify StunReqquestManager to remove entry from hash before calling callback. This makes it possible for callback to modify (clear) hash. b) clear pending requests when disconnecting from port, "should not be needed", depends on a) c) add a getter for pending_delete() Bug: webrtc:13892, webrtc:13865 Change-Id: I5d18f2db8d93b7cc25d18bd620063589ee9257c9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322861 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40907}
257 lines
7.7 KiB
C++
257 lines
7.7 KiB
C++
/*
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "p2p/base/stun_request.h"
|
|
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "rtc_base/fake_clock.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "rtc_base/helpers.h"
|
|
#include "rtc_base/logging.h"
|
|
#include "rtc_base/time_utils.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace cricket {
|
|
namespace {
|
|
std::unique_ptr<StunMessage> CreateStunMessage(
|
|
StunMessageType type,
|
|
const StunMessage* req = nullptr) {
|
|
std::unique_ptr<StunMessage> msg = std::make_unique<StunMessage>(
|
|
type, req ? req->transaction_id() : StunMessage::GenerateTransactionId());
|
|
return msg;
|
|
}
|
|
|
|
int TotalDelay(int sends) {
|
|
std::vector<int> delays = {0, 250, 750, 1750, 3750,
|
|
7750, 15750, 23750, 31750, 39750};
|
|
return delays[sends];
|
|
}
|
|
} // namespace
|
|
|
|
class StunRequestTest : public ::testing::Test {
|
|
public:
|
|
StunRequestTest()
|
|
: manager_(rtc::Thread::Current(),
|
|
[this](const void* data, size_t size, StunRequest* request) {
|
|
OnSendPacket(data, size, request);
|
|
}),
|
|
request_count_(0),
|
|
response_(NULL),
|
|
success_(false),
|
|
failure_(false),
|
|
timeout_(false) {}
|
|
|
|
void OnSendPacket(const void* data, size_t size, StunRequest* req) {
|
|
request_count_++;
|
|
}
|
|
|
|
virtual void OnResponse(StunMessage* res) {
|
|
response_ = res;
|
|
success_ = true;
|
|
}
|
|
virtual void OnErrorResponse(StunMessage* res) {
|
|
response_ = res;
|
|
failure_ = true;
|
|
}
|
|
virtual void OnTimeout() { timeout_ = true; }
|
|
|
|
protected:
|
|
rtc::AutoThread main_thread_;
|
|
StunRequestManager manager_;
|
|
int request_count_;
|
|
StunMessage* response_;
|
|
bool success_;
|
|
bool failure_;
|
|
bool timeout_;
|
|
};
|
|
|
|
// Forwards results to the test class.
|
|
class StunRequestThunker : public StunRequest {
|
|
public:
|
|
StunRequestThunker(StunRequestManager& manager, StunRequestTest* test)
|
|
: StunRequest(manager, CreateStunMessage(STUN_BINDING_REQUEST)),
|
|
test_(test) {}
|
|
|
|
std::unique_ptr<StunMessage> CreateResponseMessage(StunMessageType type) {
|
|
return CreateStunMessage(type, msg());
|
|
}
|
|
|
|
private:
|
|
virtual void OnResponse(StunMessage* res) { test_->OnResponse(res); }
|
|
virtual void OnErrorResponse(StunMessage* res) {
|
|
test_->OnErrorResponse(res);
|
|
}
|
|
virtual void OnTimeout() { test_->OnTimeout(); }
|
|
|
|
StunRequestTest* test_;
|
|
};
|
|
|
|
// Test handling of a normal binding response.
|
|
TEST_F(StunRequestTest, TestSuccess) {
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_RESPONSE);
|
|
manager_.Send(request);
|
|
EXPECT_TRUE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == res.get());
|
|
EXPECT_TRUE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
// Test handling of an error binding response.
|
|
TEST_F(StunRequestTest, TestError) {
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_ERROR_RESPONSE);
|
|
manager_.Send(request);
|
|
EXPECT_TRUE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == res.get());
|
|
EXPECT_FALSE(success_);
|
|
EXPECT_TRUE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
// Test handling of a binding response with the wrong transaction id.
|
|
TEST_F(StunRequestTest, TestUnexpected) {
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res = CreateStunMessage(STUN_BINDING_RESPONSE);
|
|
|
|
manager_.Send(request);
|
|
EXPECT_FALSE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == NULL);
|
|
EXPECT_FALSE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
// Test that requests are sent at the right times.
|
|
TEST_F(StunRequestTest, TestBackoff) {
|
|
rtc::ScopedFakeClock fake_clock;
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_RESPONSE);
|
|
|
|
int64_t start = rtc::TimeMillis();
|
|
manager_.Send(request);
|
|
for (int i = 0; i < 9; ++i) {
|
|
EXPECT_TRUE_SIMULATED_WAIT(request_count_ != i, STUN_TOTAL_TIMEOUT,
|
|
fake_clock);
|
|
int64_t elapsed = rtc::TimeMillis() - start;
|
|
RTC_DLOG(LS_INFO) << "STUN request #" << (i + 1) << " sent at " << elapsed
|
|
<< " ms";
|
|
EXPECT_EQ(TotalDelay(i), elapsed);
|
|
}
|
|
EXPECT_TRUE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == res.get());
|
|
EXPECT_TRUE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
// Test that we timeout properly if no response is received.
|
|
TEST_F(StunRequestTest, TestTimeout) {
|
|
rtc::ScopedFakeClock fake_clock;
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_RESPONSE);
|
|
|
|
manager_.Send(request);
|
|
SIMULATED_WAIT(false, cricket::STUN_TOTAL_TIMEOUT, fake_clock);
|
|
|
|
EXPECT_FALSE(manager_.CheckResponse(res.get()));
|
|
EXPECT_TRUE(response_ == NULL);
|
|
EXPECT_FALSE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_TRUE(timeout_);
|
|
}
|
|
|
|
// Regression test for specific crash where we receive a response with the
|
|
// same id as a request that doesn't have an underlying StunMessage yet.
|
|
TEST_F(StunRequestTest, TestNoEmptyRequest) {
|
|
StunRequestThunker* request = new StunRequestThunker(manager_, this);
|
|
|
|
manager_.SendDelayed(request, 100);
|
|
|
|
StunMessage dummy_req(0, request->id());
|
|
std::unique_ptr<StunMessage> res =
|
|
CreateStunMessage(STUN_BINDING_RESPONSE, &dummy_req);
|
|
|
|
EXPECT_TRUE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == res.get());
|
|
EXPECT_TRUE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
// If the response contains an attribute in the "comprehension required" range
|
|
// which is not recognized, the transaction should be considered a failure and
|
|
// the response should be ignored.
|
|
TEST_F(StunRequestTest, TestUnrecognizedComprehensionRequiredAttribute) {
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_ERROR_RESPONSE);
|
|
|
|
manager_.Send(request);
|
|
res->AddAttribute(StunAttribute::CreateUInt32(0x7777));
|
|
EXPECT_FALSE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_EQ(nullptr, response_);
|
|
EXPECT_FALSE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
class StunRequestReentranceTest : public StunRequestTest {
|
|
public:
|
|
void OnResponse(StunMessage* res) override {
|
|
manager_.Clear();
|
|
StunRequestTest::OnResponse(res);
|
|
}
|
|
void OnErrorResponse(StunMessage* res) override {
|
|
manager_.Clear();
|
|
StunRequestTest::OnErrorResponse(res);
|
|
}
|
|
};
|
|
|
|
TEST_F(StunRequestReentranceTest, TestSuccess) {
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_RESPONSE);
|
|
manager_.Send(request);
|
|
EXPECT_TRUE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == res.get());
|
|
EXPECT_TRUE(success_);
|
|
EXPECT_FALSE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
TEST_F(StunRequestReentranceTest, TestError) {
|
|
auto* request = new StunRequestThunker(manager_, this);
|
|
std::unique_ptr<StunMessage> res =
|
|
request->CreateResponseMessage(STUN_BINDING_ERROR_RESPONSE);
|
|
manager_.Send(request);
|
|
EXPECT_TRUE(manager_.CheckResponse(res.get()));
|
|
|
|
EXPECT_TRUE(response_ == res.get());
|
|
EXPECT_FALSE(success_);
|
|
EXPECT_TRUE(failure_);
|
|
EXPECT_FALSE(timeout_);
|
|
}
|
|
|
|
} // namespace cricket
|