mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-16 07:10:38 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/remote_bitrate_estimator/packet_arrival_map_test.cc
Victor Boivie ae1f8f59ac Use a std::deque in RemoteEstimatorProxy 
Before this CL, the RemoteEstimatorProxy used a std::map to track which
arrival time a packet with a certain sequence number was received at.
While this works, it's fairly slow as most manipulations and insertions
are O(log(N)) and there were quite many of them.

By taking advantage that sequence numbers generally are received in
sequence, recording a packet is now amortized O(1). Also other
operations such as creating the periodic feedback reports, are also
much faster as it previously was done by searching quite a few times
in that map.

In highly loaded Media Servers, RemoteEstimatorProxy's usage of
std::map attributes to around 0.52% CPU.

Bug: webrtc:12689
Change-Id: I3dd58105f9fbfb111f176833cd4aa6b040c0e01d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217388
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33979}
2021-05-11 10:19:06 +00:00

252 lines
6.8 KiB
C++
Raw Blame History

/*
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "modules/remote_bitrate_estimator/packet_arrival_map.h"
#include "test/gmock.h"
#include "test/gtest.h"
namespace webrtc {
namespace {
TEST(PacketArrivalMapTest, IsConsistentWhenEmpty) {
PacketArrivalTimeMap map;
EXPECT_EQ(map.begin_sequence_number(), map.end_sequence_number());
EXPECT_FALSE(map.has_received(0));
EXPECT_EQ(map.clamp(-5), 0);
EXPECT_EQ(map.clamp(5), 0);
}
TEST(PacketArrivalMapTest, InsertsFirstItemIntoMap) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
EXPECT_EQ(map.begin_sequence_number(), 42);
EXPECT_EQ(map.end_sequence_number(), 43);
EXPECT_FALSE(map.has_received(41));
EXPECT_TRUE(map.has_received(42));
EXPECT_FALSE(map.has_received(44));
EXPECT_EQ(map.clamp(-100), 42);
EXPECT_EQ(map.clamp(42), 42);
EXPECT_EQ(map.clamp(100), 43);
}
TEST(PacketArrivalMapTest, InsertsWithGaps) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
map.AddPacket(45, 11);
EXPECT_EQ(map.begin_sequence_number(), 42);
EXPECT_EQ(map.end_sequence_number(), 46);
EXPECT_FALSE(map.has_received(41));
EXPECT_TRUE(map.has_received(42));
EXPECT_FALSE(map.has_received(43));
EXPECT_FALSE(map.has_received(44));
EXPECT_TRUE(map.has_received(45));
EXPECT_FALSE(map.has_received(46));
EXPECT_EQ(map.get(42), 10);
EXPECT_EQ(map.get(43), 0);
EXPECT_EQ(map.get(44), 0);
EXPECT_EQ(map.get(45), 11);
EXPECT_EQ(map.clamp(-100), 42);
EXPECT_EQ(map.clamp(44), 44);
EXPECT_EQ(map.clamp(100), 46);
}
TEST(PacketArrivalMapTest, InsertsWithinBuffer) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
map.AddPacket(45, 11);
map.AddPacket(43, 12);
map.AddPacket(44, 13);
EXPECT_EQ(map.begin_sequence_number(), 42);
EXPECT_EQ(map.end_sequence_number(), 46);
EXPECT_FALSE(map.has_received(41));
EXPECT_TRUE(map.has_received(42));
EXPECT_TRUE(map.has_received(43));
EXPECT_TRUE(map.has_received(44));
EXPECT_TRUE(map.has_received(45));
EXPECT_FALSE(map.has_received(46));
EXPECT_EQ(map.get(42), 10);
EXPECT_EQ(map.get(43), 12);
EXPECT_EQ(map.get(44), 13);
EXPECT_EQ(map.get(45), 11);
}
TEST(PacketArrivalMapTest, GrowsBufferAndRemoveOld) {
PacketArrivalTimeMap map;
constexpr int64_t kLargeSeq = 42 + PacketArrivalTimeMap::kMaxNumberOfPackets;
map.AddPacket(42, 10);
map.AddPacket(43, 11);
map.AddPacket(44, 12);
map.AddPacket(45, 13);
map.AddPacket(kLargeSeq, 12);
EXPECT_EQ(map.begin_sequence_number(), 43);
EXPECT_EQ(map.end_sequence_number(), kLargeSeq + 1);
EXPECT_EQ(static_cast<size_t>(map.end_sequence_number() -
map.begin_sequence_number()),
PacketArrivalTimeMap::kMaxNumberOfPackets);
EXPECT_FALSE(map.has_received(41));
EXPECT_FALSE(map.has_received(42));
EXPECT_TRUE(map.has_received(43));
EXPECT_TRUE(map.has_received(44));
EXPECT_TRUE(map.has_received(45));
EXPECT_FALSE(map.has_received(46));
EXPECT_TRUE(map.has_received(kLargeSeq));
EXPECT_FALSE(map.has_received(kLargeSeq + 1));
}
TEST(PacketArrivalMapTest, GrowsBufferAndRemoveOldTrimsBeginning) {
PacketArrivalTimeMap map;
constexpr int64_t kLargeSeq = 42 + PacketArrivalTimeMap::kMaxNumberOfPackets;
map.AddPacket(42, 10);
// Missing: 43, 44
map.AddPacket(45, 13);
map.AddPacket(kLargeSeq, 12);
EXPECT_EQ(map.begin_sequence_number(), 45);
EXPECT_EQ(map.end_sequence_number(), kLargeSeq + 1);
EXPECT_FALSE(map.has_received(44));
EXPECT_TRUE(map.has_received(45));
EXPECT_FALSE(map.has_received(46));
EXPECT_TRUE(map.has_received(kLargeSeq));
EXPECT_FALSE(map.has_received(kLargeSeq + 1));
}
TEST(PacketArrivalMapTest, SequenceNumberJumpsDeletesAll) {
PacketArrivalTimeMap map;
constexpr int64_t kLargeSeq =
42 + 2 * PacketArrivalTimeMap::kMaxNumberOfPackets;
map.AddPacket(42, 10);
map.AddPacket(kLargeSeq, 12);
EXPECT_EQ(map.begin_sequence_number(), kLargeSeq);
EXPECT_EQ(map.end_sequence_number(), kLargeSeq + 1);
EXPECT_FALSE(map.has_received(42));
EXPECT_TRUE(map.has_received(kLargeSeq));
EXPECT_FALSE(map.has_received(kLargeSeq + 1));
}
TEST(PacketArrivalMapTest, ExpandsBeforeBeginning) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
map.AddPacket(-1000, 13);
EXPECT_EQ(map.begin_sequence_number(), -1000);
EXPECT_EQ(map.end_sequence_number(), 43);
EXPECT_FALSE(map.has_received(-1001));
EXPECT_TRUE(map.has_received(-1000));
EXPECT_FALSE(map.has_received(-999));
EXPECT_TRUE(map.has_received(42));
EXPECT_FALSE(map.has_received(43));
}
TEST(PacketArrivalMapTest, ExpandingBeforeBeginningKeepsReceived) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
constexpr int64_t kSmallSeq =
static_cast<int64_t>(42) - 2 * PacketArrivalTimeMap::kMaxNumberOfPackets;
map.AddPacket(kSmallSeq, 13);
EXPECT_EQ(map.begin_sequence_number(), 42);
EXPECT_EQ(map.end_sequence_number(), 43);
}
TEST(PacketArrivalMapTest, ErasesToRemoveElements) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
map.AddPacket(43, 11);
map.AddPacket(44, 12);
map.AddPacket(45, 13);
map.EraseTo(44);
EXPECT_EQ(map.begin_sequence_number(), 44);
EXPECT_EQ(map.end_sequence_number(), 46);
EXPECT_FALSE(map.has_received(43));
EXPECT_TRUE(map.has_received(44));
EXPECT_TRUE(map.has_received(45));
EXPECT_FALSE(map.has_received(46));
}
TEST(PacketArrivalMapTest, ErasesInEmptyMap) {
PacketArrivalTimeMap map;
EXPECT_EQ(map.begin_sequence_number(), map.end_sequence_number());
map.EraseTo(map.end_sequence_number());
EXPECT_EQ(map.begin_sequence_number(), map.end_sequence_number());
}
TEST(PacketArrivalMapTest, IsTolerantToWrongArgumentsForErase) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
map.AddPacket(43, 11);
map.EraseTo(1);
EXPECT_EQ(map.begin_sequence_number(), 42);
EXPECT_EQ(map.end_sequence_number(), 44);
map.EraseTo(100);
EXPECT_EQ(map.begin_sequence_number(), 44);
EXPECT_EQ(map.end_sequence_number(), 44);
}
TEST(PacketArrivalMapTest, EraseAllRemembersBeginningSeqNbr) {
PacketArrivalTimeMap map;
map.AddPacket(42, 10);
map.AddPacket(43, 11);
map.AddPacket(44, 12);
map.AddPacket(45, 13);
map.EraseTo(46);
map.AddPacket(50, 10);
EXPECT_EQ(map.begin_sequence_number(), 46);
EXPECT_EQ(map.end_sequence_number(), 51);
EXPECT_FALSE(map.has_received(45));
EXPECT_FALSE(map.has_received(46));
EXPECT_FALSE(map.has_received(47));
EXPECT_FALSE(map.has_received(48));
EXPECT_FALSE(map.has_received(49));
EXPECT_TRUE(map.has_received(50));
EXPECT_FALSE(map.has_received(51));
}
} // namespace
} // namespace webrtc
Reference in a new issue View git blame Copy permalink