mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-14 14:20:45 +01:00
1df1bf8551
This exposes the stats selection algorithm[1] on the PeerConnection. Per-spec, there are four flavors of getStats(): 1. RTCPeerConnection.getStats(). 2. RTCPeerConnection.getStats(MediaStreamTrack selector). 3. RTCRtpSender.getStats(). 4. RTCRtpReceiver.getStats(). 1) is the parameterless getStats() which is already shipped. 2) is the same as 3) and 4) except the track is used to look up the corresponding sender/receiver to use as the selector. 3) and 4) perform stats collection with a filter, which is implemented in RTCStatsCollector.GetStatsReport(selector). For technical reasons, it is easier to place GetStats() on the PeerConnection where the RTCStatsCollector lives than to place it on the sender/receiver. Passing the selector as an argument or as a "this" makes little difference other than style. Wiring Chrome up such that the JavaScript APIs is like the spec is trivial after GetStats() is added to PeerConnectionInterface. This CL also adds comments documenting our intent to deprecate and remove the legacy GetStats() APIs some time in the future. [1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm Bug: chromium:680172 Change-Id: I09316ba6f20b25d4f9c11785d0a1a1262d6062a1 Reviewed-on: https://webrtc-review.googlesource.com/62900 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22602} |
||
|---|---|---|
| .. | ||
| OWNERS | ||
| rtcstats.h | ||
| rtcstats_objects.h | ||
| rtcstatscollectorcallback.h | ||
| rtcstatsreport.h | ||