mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 23:30:48 +01:00
9253240305
This is a reland of commit 97ba853295
This cl did not cause the regression in Chrome rolls https://chromium-review.googlesource.com/c/chromium/src/+/4132644?tab=checks. Real culprit reverted in https://webrtc-review.googlesource.com/c/src/+/290502.
Original change's description:
> Remove use of ReceiveStreamRtpConfig:transport_cc
>
> With this change, webrtc will send RTCP transport feedback for all received packets that have a transport sequence number, if the header extension
> http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions is negotiated.
> I.e the SDP attribute a=rtcp-fb:96 transport-cc is ignored.
>
>
> Change-Id: I95d8d4405dc86a2f872f7883b7bafd623d5f7841
>
> Bug: webrtc:14802
> Change-Id: I95d8d4405dc86a2f872f7883b7bafd623d5f7841
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290403
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38980}
Bug: webrtc:14802
Change-Id: Ib98e61413161d462da60144942cdb0140e12bc42
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290503
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38997}
64 lines
2.7 KiB
C++
64 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "test/call_config_utils.h"
|
|
|
|
#include "call/video_receive_stream.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
TEST(CallConfigUtils, MarshalUnmarshalProcessSameObject) {
|
|
VideoReceiveStreamInterface::Config recv_config(nullptr);
|
|
|
|
VideoReceiveStreamInterface::Decoder decoder;
|
|
decoder.payload_type = 10;
|
|
decoder.video_format.name = "test";
|
|
decoder.video_format.parameters["99"] = "b";
|
|
recv_config.decoders.push_back(decoder);
|
|
recv_config.render_delay_ms = 10;
|
|
recv_config.rtp.remote_ssrc = 100;
|
|
recv_config.rtp.local_ssrc = 101;
|
|
recv_config.rtp.rtcp_mode = RtcpMode::kCompound;
|
|
recv_config.rtp.lntf.enabled = false;
|
|
recv_config.rtp.nack.rtp_history_ms = 150;
|
|
recv_config.rtp.red_payload_type = 50;
|
|
recv_config.rtp.rtx_ssrc = 1000;
|
|
recv_config.rtp.rtx_associated_payload_types[10] = 10;
|
|
recv_config.rtp.extensions.emplace_back("uri", 128, true);
|
|
|
|
VideoReceiveStreamInterface::Config unmarshaled_config =
|
|
ParseVideoReceiveStreamJsonConfig(
|
|
nullptr, GenerateVideoReceiveStreamJsonConfig(recv_config));
|
|
|
|
EXPECT_EQ(recv_config.decoders[0].payload_type,
|
|
unmarshaled_config.decoders[0].payload_type);
|
|
EXPECT_EQ(recv_config.decoders[0].video_format.name,
|
|
unmarshaled_config.decoders[0].video_format.name);
|
|
EXPECT_EQ(recv_config.decoders[0].video_format.parameters,
|
|
unmarshaled_config.decoders[0].video_format.parameters);
|
|
EXPECT_EQ(recv_config.render_delay_ms, unmarshaled_config.render_delay_ms);
|
|
EXPECT_EQ(recv_config.rtp.remote_ssrc, unmarshaled_config.rtp.remote_ssrc);
|
|
EXPECT_EQ(recv_config.rtp.local_ssrc, unmarshaled_config.rtp.local_ssrc);
|
|
EXPECT_EQ(recv_config.rtp.rtcp_mode, unmarshaled_config.rtp.rtcp_mode);
|
|
EXPECT_EQ(recv_config.rtp.lntf.enabled, unmarshaled_config.rtp.lntf.enabled);
|
|
EXPECT_EQ(recv_config.rtp.nack.rtp_history_ms,
|
|
unmarshaled_config.rtp.nack.rtp_history_ms);
|
|
EXPECT_EQ(recv_config.rtp.red_payload_type,
|
|
unmarshaled_config.rtp.red_payload_type);
|
|
EXPECT_EQ(recv_config.rtp.rtx_ssrc, unmarshaled_config.rtp.rtx_ssrc);
|
|
EXPECT_EQ(recv_config.rtp.rtx_associated_payload_types,
|
|
unmarshaled_config.rtp.rtx_associated_payload_types);
|
|
EXPECT_EQ(recv_config.rtp.extensions, recv_config.rtp.extensions);
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|