mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 15:47:53 +01:00
d4089cae47
BACKGROUND When SLD is invoked with SetSessionDescriptionObserver, the observer is called by posting a message back to the execution thread, delaying the call. This delay is "artificial" - it's not necessary; the operation is already complete. It's a post from the signaling thread to the signaling thread. The rationale for the post was to avoid the observer making recursive calls back into the PeerConnection. The problem with this is that by the time the observer is called, the PeerConnection could already have executed other operations and modified its states. This causes the referenced bug: one can have a race where SLD is resolved "too late" (after a pending SRD is executed) and the signaling state observed when SLD resolves doesn't make sense. When implementing Unified Plan, we fixed similar issues for SRD by adding a version that takes SetRemoteDescriptionObserverInterface as argument instead of SetSessionDescriptionObserver. The new version did not have the delay. The old version had to be kept around not to break downstream projects that had dependencies both on he delay and on allowing the PC to be destroyed midst-operation without informing its observers. THIS CL This does the old SRD fix for SLD as well: A new observer interface is added, SetLocalDescriptionObserverInterface, and PeerConnection::SetLocalDescription() is overloaded. If you call it with the old observer, you get the delay, but if you call it with the new observer, you don't get a delay. - SetLocalDescriptionObserverInterface is added. - SetLocalDescription is overloaded. - The adapter for SetSessionDescriptionObserver that causes the delay previously only used for SRD is updated to handle both SLD and SRD. - FakeSetLocalDescriptionObserver is added and MockSetRemoteDescriptionObserver is renamed "Fake...". Bug: chromium:1071733 Change-Id: I920368e648bede481058ac22f5b8794752a220b3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31798} |
||
|---|---|---|
| .. | ||
| adaptation | ||
| audio | ||
| audio_codecs | ||
| call | ||
| crypto | ||
| neteq | ||
| rtc_event_log | ||
| stats | ||
| task_queue | ||
| test | ||
| transport | ||
| units | ||
| video | ||
| video_codecs | ||
| voip | ||
| array_view.h | ||
| array_view_unittest.cc | ||
| async_resolver_factory.h | ||
| audio_options.cc | ||
| audio_options.h | ||
| BUILD.gn | ||
| candidate.cc | ||
| candidate.h | ||
| create_peerconnection_factory.cc | ||
| create_peerconnection_factory.h | ||
| crypto_params.h | ||
| data_channel_interface.cc | ||
| data_channel_interface.h | ||
| DEPS | ||
| DESIGN.md | ||
| dtls_transport_interface.cc | ||
| dtls_transport_interface.h | ||
| dtmf_sender_interface.h | ||
| fec_controller.h | ||
| fec_controller_override.h | ||
| frame_transformer_interface.h | ||
| function_view.h | ||
| function_view_unittest.cc | ||
| ice_transport_factory.cc | ||
| ice_transport_factory.h | ||
| ice_transport_interface.h | ||
| jsep.cc | ||
| jsep.h | ||
| jsep_ice_candidate.cc | ||
| jsep_ice_candidate.h | ||
| jsep_session_description.h | ||
| media_stream_interface.cc | ||
| media_stream_interface.h | ||
| media_stream_proxy.h | ||
| media_stream_track_proxy.h | ||
| media_types.cc | ||
| media_types.h | ||
| network_state_predictor.h | ||
| notifier.h | ||
| OWNERS | ||
| packet_socket_factory.h | ||
| peer_connection_factory_proxy.h | ||
| peer_connection_interface.cc | ||
| peer_connection_interface.h | ||
| peer_connection_proxy.h | ||
| priority.h | ||
| proxy.cc | ||
| proxy.h | ||
| README.md | ||
| ref_counted_base.h | ||
| rtc_error.cc | ||
| rtc_error.h | ||
| rtc_error_unittest.cc | ||
| rtc_event_log_output.h | ||
| rtc_event_log_output_file.cc | ||
| rtc_event_log_output_file.h | ||
| rtc_event_log_output_file_unittest.cc | ||
| rtp_headers.cc | ||
| rtp_headers.h | ||
| rtp_packet_info.cc | ||
| rtp_packet_info.h | ||
| rtp_packet_info_unittest.cc | ||
| rtp_packet_infos.h | ||
| rtp_packet_infos_unittest.cc | ||
| rtp_parameters.cc | ||
| rtp_parameters.h | ||
| rtp_parameters_unittest.cc | ||
| rtp_receiver_interface.cc | ||
| rtp_receiver_interface.h | ||
| rtp_sender_interface.cc | ||
| rtp_sender_interface.h | ||
| rtp_transceiver_direction.h | ||
| rtp_transceiver_interface.cc | ||
| rtp_transceiver_interface.h | ||
| scoped_refptr.h | ||
| scoped_refptr_unittest.cc | ||
| sctp_transport_interface.cc | ||
| sctp_transport_interface.h | ||
| set_local_description_observer_interface.h | ||
| set_remote_description_observer_interface.h | ||
| stats_types.cc | ||
| stats_types.h | ||
| turn_customizer.h | ||
| uma_metrics.h | ||
| video_track_source_proxy.h | ||
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.