mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-15 06:40:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_device
History
henrika bb55e0bc72 Clarifies identification of default communication device in ADM2 
ADM2 for Windows is based on the CoreAudioUtil class in Chrome.
CoreAudioUtil in Chrome does not use a special string to identify
the Default Communication device but instead a combination of a
string (Default) and a role parameter [1].

When CoreAudioUtil was ported to WebRTC, I accidentally added an
invalid usage of a unique string to identify the default comm device
and it can lead to errors since there are then two different ways to
identify this device. It will also complicate life when we want to
merge changes from Chrome into WebRTC.

This CL removes usage of AudioDeviceName::kDefaultCommunicationsDeviceId
in WebRTC to reduce the risk of errors.

[1] https://cs.chromium.org/chromium/src/media/audio/win/core_audio_util_win.cc?q=core_audio_ut&sq=package:chromium&g=0&l=464

Excluding flaky bot win_x86_msvc_dbg and using Tbr.

Tbr: thaloun@chromium.org
No-Try: True
Bug: webrtc:11107
Change-Id: Ie6687adbe9c3940a217456e4025967f71d86214c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160047
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29848}
2019-11-20 15:02:06 +00:00
..
android Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
dummy Format almost everything. 2019-07-08 13:45:15 +00:00
include Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
linux [tsan] Guard audio_device_pulse_linux members from concurrent access. 2019-08-12 11:55:52 +00:00
mac Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
win Clarifies identification of default communication device in ADM2 2019-11-20 15:02:06 +00:00
audio_device_buffer.cc Format almost everything. 2019-07-08 13:45:15 +00:00
audio_device_buffer.h Format almost everything. 2019-07-08 13:45:15 +00:00
audio_device_config.h Reformat the WebRTC code base 2018-06-19 14:00:39 +00:00
audio_device_data_observer.cc Reporting audio device underrun counter 2019-08-16 11:49:55 +00:00
audio_device_generic.cc Reporting audio device underrun counter 2019-08-16 11:49:55 +00:00
audio_device_generic.h Reporting audio device underrun counter 2019-08-16 11:49:55 +00:00
audio_device_impl.cc Reporting audio device underrun counter 2019-08-16 11:49:55 +00:00
audio_device_impl.h Reporting audio device underrun counter 2019-08-16 11:49:55 +00:00
audio_device_name.cc Clarifies identification of default communication device in ADM2 2019-11-20 15:02:06 +00:00
audio_device_name.h Clarifies identification of default communication device in ADM2 2019-11-20 15:02:06 +00:00
audio_device_unittest.cc Tests that all available audio devices can be selected and used by the ADM. 2019-11-18 17:47:31 +00:00
BUILD.gn Move rtc_base/ignore_wundef.h to its own target. 2019-10-19 10:50:36 +00:00
DEPS Reland "Remove old audio device implementation." 2019-04-10 06:44:42 +00:00
fine_audio_buffer.cc [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
fine_audio_buffer.h Adds stereo support to FineAudioBuffer for mobile platforms. 2018-04-24 11:58:54 +00:00
fine_audio_buffer_unittest.cc Format almost everything. 2019-07-08 13:45:15 +00:00
mock_audio_device_buffer.h Propagate TaskQueueFactory to AudioDeviceBuffer 2019-04-01 08:00:49 +00:00
OWNERS Moving src/webrtc into src/. 2017-09-15 04:25:06 +00:00