mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-20 00:57:49 +01:00
![]() In the legacy C part of AGC, an audio level 'cur_level' is represented as (1+frac) * 2^(31 - zeros) The 'zeros' exponent part is used for looking up a gain value in a table, and 'frac' is used for interpolating between two nearby table values. Code snippet below: zeros = WebRtcSpl_NormU32((uint32_t)cur_level); tmp32 = (cur_level << zeros) & 0x7FFFFFFF; frac = (int16_t)(tmp32 >> 19); In the second line, 'cur_level' is shifted upwards so that the leading bit is '1', after which the leading bit is cleared. The result is 'frac' in Q31. The compiler type of 'cur_level << zeros' is 'int32_t'. This is a fuzzer error 'Left shift cannot be represented in int32_t', because the leading sign bit is 1. This CL changes the compiler type to uint32_t. Bug: chromium:776286 Change-Id: Ie29552b75e690057bd76fc88e747841b531e3802 Reviewed-on: https://webrtc-review.googlesource.com/14841 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20405} |
||
---|---|---|
.. | ||
legacy | ||
agc.cc | ||
agc.h | ||
agc_manager_direct.cc | ||
agc_manager_direct.h | ||
agc_manager_direct_unittest.cc | ||
gain_map_internal.h | ||
loudness_histogram.cc | ||
loudness_histogram.h | ||
loudness_histogram_unittest.cc | ||
mock_agc.h | ||
utility.cc | ||
utility.h |