mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00

This reverts commit 066b5b6ed7
.
Reason for revert: Regressions on iOS testbots.
Original change's description:
> Enable Video-QualityScaling experiment by default
>
> Bug: webrtc:12401
> Change-Id: Iebf3130e785892bb9fddf1012bc46027a21085a4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204000
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Reviewed-by: Åsa Persson <asapersson@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#33091}
TBR=ilnik@webrtc.org,asapersson@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:12401
Change-Id: I489b805c7741b63c22c16cfce03347179a3e2602
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205001
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33123}
272 lines
8.5 KiB
C++
272 lines
8.5 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/video_coding/utility/quality_scaler.h"
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/event.h"
|
|
#include "rtc_base/task_queue_for_test.h"
|
|
#include "test/field_trial.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
static const int kFramerate = 30;
|
|
static const int kLowQp = 15;
|
|
static const int kHighQp = 40;
|
|
static const int kMinFramesNeededToScale = 60; // From quality_scaler.cc.
|
|
static const size_t kDefaultTimeoutMs = 150;
|
|
} // namespace
|
|
|
|
class FakeQpUsageHandler : public QualityScalerQpUsageHandlerInterface {
|
|
public:
|
|
~FakeQpUsageHandler() override = default;
|
|
|
|
// QualityScalerQpUsageHandlerInterface implementation.
|
|
void OnReportQpUsageHigh() override {
|
|
adapt_down_events_++;
|
|
event.Set();
|
|
}
|
|
|
|
void OnReportQpUsageLow() override {
|
|
adapt_up_events_++;
|
|
event.Set();
|
|
}
|
|
|
|
rtc::Event event;
|
|
int adapt_up_events_ = 0;
|
|
int adapt_down_events_ = 0;
|
|
};
|
|
|
|
// Pass a lower sampling period to speed up the tests.
|
|
class QualityScalerUnderTest : public QualityScaler {
|
|
public:
|
|
explicit QualityScalerUnderTest(QualityScalerQpUsageHandlerInterface* handler,
|
|
VideoEncoder::QpThresholds thresholds)
|
|
: QualityScaler(handler, thresholds, 5) {}
|
|
};
|
|
|
|
class QualityScalerTest : public ::testing::Test,
|
|
public ::testing::WithParamInterface<std::string> {
|
|
protected:
|
|
enum ScaleDirection {
|
|
kKeepScaleAboveLowQp,
|
|
kKeepScaleAtHighQp,
|
|
kScaleDown,
|
|
kScaleDownAboveHighQp,
|
|
kScaleUp
|
|
};
|
|
|
|
QualityScalerTest()
|
|
: scoped_field_trial_(GetParam()),
|
|
task_queue_("QualityScalerTestQueue"),
|
|
handler_(std::make_unique<FakeQpUsageHandler>()) {
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
qs_ = std::unique_ptr<QualityScaler>(new QualityScalerUnderTest(
|
|
handler_.get(), VideoEncoder::QpThresholds(kLowQp, kHighQp)));
|
|
},
|
|
RTC_FROM_HERE);
|
|
}
|
|
|
|
~QualityScalerTest() override {
|
|
task_queue_.SendTask([this] { qs_ = nullptr; }, RTC_FROM_HERE);
|
|
}
|
|
|
|
void TriggerScale(ScaleDirection scale_direction) {
|
|
for (int i = 0; i < kFramerate * 5; ++i) {
|
|
switch (scale_direction) {
|
|
case kKeepScaleAboveLowQp:
|
|
qs_->ReportQp(kLowQp + 1, 0);
|
|
break;
|
|
case kScaleUp:
|
|
qs_->ReportQp(kLowQp, 0);
|
|
break;
|
|
case kScaleDown:
|
|
qs_->ReportDroppedFrameByMediaOpt();
|
|
break;
|
|
case kKeepScaleAtHighQp:
|
|
qs_->ReportQp(kHighQp, 0);
|
|
break;
|
|
case kScaleDownAboveHighQp:
|
|
qs_->ReportQp(kHighQp + 1, 0);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
test::ScopedFieldTrials scoped_field_trial_;
|
|
TaskQueueForTest task_queue_;
|
|
std::unique_ptr<QualityScaler> qs_;
|
|
std::unique_ptr<FakeQpUsageHandler> handler_;
|
|
};
|
|
|
|
INSTANTIATE_TEST_SUITE_P(
|
|
FieldTrials,
|
|
QualityScalerTest,
|
|
::testing::Values(
|
|
"WebRTC-Video-QualityScaling/Enabled-1,2,3,4,5,6,7,8,0.9,0.99,1/",
|
|
""));
|
|
|
|
TEST_P(QualityScalerTest, DownscalesAfterContinuousFramedrop) {
|
|
task_queue_.SendTask([this] { TriggerScale(kScaleDown); }, RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, KeepsScaleAtHighQp) {
|
|
task_queue_.SendTask([this] { TriggerScale(kKeepScaleAtHighQp); },
|
|
RTC_FROM_HERE);
|
|
EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, DownscalesAboveHighQp) {
|
|
task_queue_.SendTask([this] { TriggerScale(kScaleDownAboveHighQp); },
|
|
RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, DownscalesAfterTwoThirdsFramedrop) {
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
for (int i = 0; i < kFramerate * 5; ++i) {
|
|
qs_->ReportDroppedFrameByMediaOpt();
|
|
qs_->ReportDroppedFrameByMediaOpt();
|
|
qs_->ReportQp(kHighQp, 0);
|
|
}
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, DoesNotDownscaleAfterHalfFramedrop) {
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
for (int i = 0; i < kFramerate * 5; ++i) {
|
|
qs_->ReportDroppedFrameByMediaOpt();
|
|
qs_->ReportQp(kHighQp, 0);
|
|
}
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, DownscalesAfterTwoThirdsIfFieldTrialEnabled) {
|
|
const bool kDownScaleExpected = !GetParam().empty();
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
for (int i = 0; i < kFramerate * 5; ++i) {
|
|
qs_->ReportDroppedFrameByMediaOpt();
|
|
qs_->ReportDroppedFrameByEncoder();
|
|
qs_->ReportQp(kHighQp, 0);
|
|
}
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_EQ(kDownScaleExpected, handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(kDownScaleExpected ? 1 : 0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, KeepsScaleOnNormalQp) {
|
|
task_queue_.SendTask([this] { TriggerScale(kKeepScaleAboveLowQp); },
|
|
RTC_FROM_HERE);
|
|
EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, UpscalesAfterLowQp) {
|
|
task_queue_.SendTask([this] { TriggerScale(kScaleUp); }, RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(1, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, ScalesDownAndBackUp) {
|
|
task_queue_.SendTask([this] { TriggerScale(kScaleDown); }, RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
task_queue_.SendTask([this] { TriggerScale(kScaleUp); }, RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(1, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, DoesNotScaleUntilEnoughFramesObserved) {
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
// Not enough frames to make a decision.
|
|
for (int i = 0; i < kMinFramesNeededToScale - 1; ++i) {
|
|
qs_->ReportQp(kLowQp, 0);
|
|
}
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
// Send 1 more. Enough frames observed, should result in an adapt
|
|
// request.
|
|
qs_->ReportQp(kLowQp, 0);
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(1, handler_->adapt_up_events_);
|
|
|
|
// Samples should be cleared after an adapt request.
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
// Not enough frames to make a decision.
|
|
qs_->ReportQp(kLowQp, 0);
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(0, handler_->adapt_down_events_);
|
|
EXPECT_EQ(1, handler_->adapt_up_events_);
|
|
}
|
|
|
|
TEST_P(QualityScalerTest, ScalesDownAndBackUpWithMinFramesNeeded) {
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
for (int i = 0; i < kMinFramesNeededToScale; ++i) {
|
|
qs_->ReportQp(kHighQp + 1, 0);
|
|
}
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(0, handler_->adapt_up_events_);
|
|
// Samples cleared.
|
|
task_queue_.SendTask(
|
|
[this] {
|
|
for (int i = 0; i < kMinFramesNeededToScale; ++i) {
|
|
qs_->ReportQp(kLowQp, 0);
|
|
}
|
|
},
|
|
RTC_FROM_HERE);
|
|
EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
|
|
EXPECT_EQ(1, handler_->adapt_down_events_);
|
|
EXPECT_EQ(1, handler_->adapt_up_events_);
|
|
}
|
|
|
|
} // namespace webrtc
|