mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
![]() Chromium requires that all code that waits on a sync primitive be annotated with ScopedAllowBaseSyncPrimitives(ForTesting). Webrtc already imports ScopedAllowBaseSyncPrimitives. ScopedAllowBaseSyncPrimitivesForTesting is equivalent but can only be used in tests and doesn't required adding a friend declaration to thread_restrictions.h. Previously, the code that is annotated with ScopedAllowBaseSyncPrimitivesForTesting in this CL didn't fail because it ran on a TaskRunner annotated with the deprecated WithBaseSyncPrimitives() trait (cf. https://cs.chromium.org/chromium/src/content/renderer/media/webrtc/task_queue_factory_unittest.cc?l=23&rcl=362f3723ac358d932ea2e3af65512a1243697a31). Change-Id: Id7cfa2ea108870de86dc887458ae783c807791cc Bug: chromium:889029 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128823 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27339} |
||
---|---|---|
.. | ||
BUILD.gn | ||
default_task_queue_factory.h | ||
default_task_queue_factory_gcd.cc | ||
default_task_queue_factory_libevent.cc | ||
default_task_queue_factory_stdlib.cc | ||
default_task_queue_factory_unittest.cc | ||
default_task_queue_factory_win.cc | ||
DEPS | ||
global_task_queue_factory.cc | ||
global_task_queue_factory.h | ||
queued_task.h | ||
task_queue_base.cc | ||
task_queue_base.h | ||
task_queue_factory.h | ||
task_queue_test.cc | ||
task_queue_test.h |