mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-16 15:20:42 +01:00
918f50c5d1
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
122 lines
2.6 KiB
C++
122 lines
2.6 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
#include <random>
|
|
|
|
#include "absl/memory/memory.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/nullsocketserver.h"
|
|
#include "rtc_base/thread.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace rtc {
|
|
|
|
namespace {
|
|
|
|
#if defined(MEMORY_SANITIZER)
|
|
void UseOfUninitializedValue() {
|
|
int* buf = new int[2];
|
|
std::random_device engine;
|
|
if (buf[engine() % 2]) { // Non-deterministic conditional.
|
|
printf("Externally visible action.");
|
|
}
|
|
delete[] buf;
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, MemorySanitizer) {
|
|
EXPECT_DEATH(UseOfUninitializedValue(), "use-of-uninitialized-value");
|
|
}
|
|
#endif
|
|
|
|
#if defined(ADDRESS_SANITIZER)
|
|
void HeapUseAfterFree() {
|
|
char* buf = new char[2];
|
|
delete[] buf;
|
|
buf[0] = buf[1];
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, AddressSanitizer) {
|
|
EXPECT_DEATH(HeapUseAfterFree(), "heap-use-after-free");
|
|
}
|
|
#endif
|
|
|
|
#if defined(UNDEFINED_SANITIZER)
|
|
// For ubsan:
|
|
void SignedIntegerOverflow() {
|
|
int32_t x = 1234567890;
|
|
x *= 2;
|
|
}
|
|
|
|
// For ubsan_vptr:
|
|
struct Base {
|
|
virtual void f() {}
|
|
virtual ~Base() {}
|
|
};
|
|
struct Derived : public Base {};
|
|
|
|
void InvalidVptr() {
|
|
Base b;
|
|
auto* d = static_cast<Derived*>(&b); // Bad downcast.
|
|
d->f(); // Virtual function call with object of wrong dynamic type.
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, UndefinedSanitizer) {
|
|
EXPECT_DEATH(
|
|
{
|
|
SignedIntegerOverflow();
|
|
InvalidVptr();
|
|
},
|
|
"runtime error");
|
|
}
|
|
#endif
|
|
|
|
#if defined(THREAD_SANITIZER)
|
|
class IncrementThread : public Thread {
|
|
public:
|
|
explicit IncrementThread(int* value)
|
|
: Thread(absl::make_unique<NullSocketServer>()), value_(value) {}
|
|
|
|
void Run() override {
|
|
++*value_;
|
|
Thread::Current()->SleepMs(100);
|
|
}
|
|
|
|
// Un-protect Thread::Join for the test.
|
|
void Join() { Thread::Join(); }
|
|
|
|
private:
|
|
int* value_;
|
|
|
|
RTC_DISALLOW_COPY_AND_ASSIGN(IncrementThread);
|
|
};
|
|
|
|
void DataRace() {
|
|
int value = 0;
|
|
IncrementThread thread1(&value);
|
|
IncrementThread thread2(&value);
|
|
thread1.Start();
|
|
thread2.Start();
|
|
thread1.Join();
|
|
thread2.Join();
|
|
// TSan seems to mess with gtest's death detection.
|
|
// Fail intentionally, and rely on detecting the error message.
|
|
RTC_CHECK(false);
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, ThreadSanitizer) {
|
|
EXPECT_DEATH(DataRace(), "data race");
|
|
}
|
|
#endif
|
|
|
|
} // namespace
|
|
|
|
} // namespace rtc
|