webrtc/modules/rtp_rtcp/source/rtp_header_extension_map_unittest.cc
Harald Alvestrand b62ee8ce94 Detect and reject illegal RTP header extension modifications.
This is somewhat klugey, because it does the same checks at two
different layers in the stack, in different functions, which runs
the risk of making them out of sync. But it solves the immediate
problem.

Bug: chromium:1249753
Change-Id: I2ad96f0cc9499c15540ff6946a409b40df3e3925
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235826
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35259}
2021-10-22 11:52:02 +00:00

115 lines
3.6 KiB
C++

/*
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
#include <vector>
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
#include "test/gtest.h"
namespace webrtc {
TEST(RtpHeaderExtensionTest, RegisterByType) {
RtpHeaderExtensionMap map;
EXPECT_FALSE(map.IsRegistered(TransmissionOffset::kId));
EXPECT_TRUE(map.RegisterByType(3, TransmissionOffset::kId));
EXPECT_TRUE(map.IsRegistered(TransmissionOffset::kId));
EXPECT_EQ(3, map.GetId(TransmissionOffset::kId));
EXPECT_EQ(TransmissionOffset::kId, map.GetType(3));
}
TEST(RtpHeaderExtensionTest, RegisterByUri) {
RtpHeaderExtensionMap map;
EXPECT_TRUE(map.RegisterByUri(3, TransmissionOffset::Uri()));
EXPECT_TRUE(map.IsRegistered(TransmissionOffset::kId));
EXPECT_EQ(3, map.GetId(TransmissionOffset::kId));
EXPECT_EQ(TransmissionOffset::kId, map.GetType(3));
}
TEST(RtpHeaderExtensionTest, RegisterWithTrait) {
RtpHeaderExtensionMap map;
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
EXPECT_TRUE(map.IsRegistered(TransmissionOffset::kId));
EXPECT_EQ(3, map.GetId(TransmissionOffset::kId));
EXPECT_EQ(TransmissionOffset::kId, map.GetType(3));
}
TEST(RtpHeaderExtensionTest, RegisterDuringContruction) {
const std::vector<RtpExtension> config = {{TransmissionOffset::Uri(), 1},
{AbsoluteSendTime::Uri(), 3}};
const RtpHeaderExtensionMap map(config);
EXPECT_EQ(1, map.GetId(TransmissionOffset::kId));
EXPECT_EQ(3, map.GetId(AbsoluteSendTime::kId));
}
TEST(RtpHeaderExtensionTest, RegisterTwoByteHeaderExtensions) {
RtpHeaderExtensionMap map;
// Two-byte header extension needed for id: [15-255].
EXPECT_TRUE(map.Register<TransmissionOffset>(18));
EXPECT_TRUE(map.Register<AbsoluteSendTime>(255));
}
TEST(RtpHeaderExtensionTest, RegisterIllegalArg) {
RtpHeaderExtensionMap map;
// Valid range for id: [1-255].
EXPECT_FALSE(map.Register<TransmissionOffset>(0));
EXPECT_FALSE(map.Register<TransmissionOffset>(256));
}
TEST(RtpHeaderExtensionTest, Idempotent) {
RtpHeaderExtensionMap map;
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
map.Deregister(TransmissionOffset::Uri());
map.Deregister(TransmissionOffset::Uri());
}
TEST(RtpHeaderExtensionTest, NonUniqueId) {
RtpHeaderExtensionMap map;
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
EXPECT_FALSE(map.Register<AudioLevel>(3));
EXPECT_TRUE(map.Register<AudioLevel>(4));
}
TEST(RtpHeaderExtensionTest, GetType) {
RtpHeaderExtensionMap map;
EXPECT_EQ(RtpHeaderExtensionMap::kInvalidType, map.GetType(3));
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
EXPECT_EQ(TransmissionOffset::kId, map.GetType(3));
}
TEST(RtpHeaderExtensionTest, GetId) {
RtpHeaderExtensionMap map;
EXPECT_EQ(RtpHeaderExtensionMap::kInvalidId,
map.GetId(TransmissionOffset::kId));
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
EXPECT_EQ(3, map.GetId(TransmissionOffset::kId));
}
TEST(RtpHeaderExtensionTest, RemapFails) {
RtpHeaderExtensionMap map;
EXPECT_TRUE(map.Register<TransmissionOffset>(3));
EXPECT_FALSE(map.Register<TransmissionOffset>(4));
}
} // namespace webrtc