mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 23:57:59 +01:00
e630a3d7ad
Web Spec and C++ version of setCodecPreferences are failable, as they return an RTCError (in C++) or throw an InvalidModificationError (in Web Spec). However, current Objective-C version of setCodecPreferences is not failable, so callers cannot know if the operation succeeded or not. Also, the current Objective-C version does not accept nil, which is not spec-compliant. (Web Spec says if codecs is an empty list, set transceiver.PreferredCodecs to codecs and abort these steps.) Bug: webrtc:42226103, webrtc:42226230 Change-Id: Ib90f3e5b45fc959eeb92f623cf50efcb458a7478 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42789} |
||
|---|---|---|
| .. | ||
| audio_short16.pcm | ||
| audio_short44.pcm | ||
| audio_short48.pcm | ||
| avformatmappertests.mm | ||
| foreman.mp4 | ||
| frame_buffer_helpers.h | ||
| frame_buffer_helpers.mm | ||
| main.mm | ||
| nalu_rewriter_xctest.mm | ||
| objc_video_decoder_factory_tests.mm | ||
| objc_video_encoder_factory_tests.mm | ||
| ObjCVideoTrackSource_xctest.mm | ||
| RTCAudioDevice_xctest.mm | ||
| RTCAudioDeviceModule_xctest.mm | ||
| RTCAudioSessionTest.mm | ||
| RTCCallbackLogger_xctest.m | ||
| RTCCameraVideoCapturerTests.mm | ||
| RTCCertificateTest.mm | ||
| RTCConfigurationTest.mm | ||
| RTCCVPixelBuffer_xctest.mm | ||
| RTCDataChannelConfigurationTest.mm | ||
| RTCDoNotPutCPlusPlusInFrameworkHeaders_xctest.m | ||
| RTCEncodedImage_xctest.mm | ||
| RTCFileVideoCapturer_xctest.mm | ||
| RTCH264ProfileLevelId_xctest.m | ||
| RTCIceCandidateTest.mm | ||
| RTCIceServerTest.mm | ||
| RTCMediaConstraintsTest.mm | ||
| RTCMTLVideoView_xctest.m | ||
| RTCNV12TextureCache_xctest.m | ||
| RTCPeerConnectionFactory_xctest.m | ||
| RTCPeerConnectionFactoryBuilderTest.mm | ||
| RTCPeerConnectionTest.mm | ||
| RTCSessionDescriptionTest.mm | ||
| RTCTracingTest.mm | ||
| scoped_cftyperef_tests.mm | ||