mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 07:37:51 +01:00
edab3011fa
This is done to solve a problem where a string literal is implicitly cast to a temporary std::string when calling webrtc::test::InitFieldTrialsFromString which passes a pointer to the internal representation to webrtc::field_trial::InitFieldTrialFromString(char*). This pointer is stored for later use, but the temporary std::string is destroyed as soon as the function returns. Using webrtc::field_trial::InitFieldTrialFromString(char*) instead, avoids the implicit casts (but the caller still needs to ensure that the char* outlives the program). The validation previously done by webrtc::test::InitFieldTrialsFromString can now be done by manually calling webrtc::test::ValidateFieldTrialsStringOrDie(const std::string&). Add system_wrappers:field_trial_default as a direct dependency to various targets to allow including the field_trials_default.h header. Bug: webrtc:8812 Change-Id: Ib5a641ea255b1c16a8f7f35e1fe67f6c38a61da6 Reviewed-on: https://webrtc-review.googlesource.com/46141 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21856} |
||
|---|---|---|
| .. | ||
| agc | ||
| barcode_tools | ||
| converter | ||
| event_log_visualizer | ||
| force_mic_volume_max | ||
| frame_analyzer | ||
| frame_editing | ||
| loopback_test | ||
| network_tester | ||
| psnr_ssim_analyzer | ||
| py_event_log_analyzer | ||
| rtcbot | ||
| testing | ||
| unpack_aecdump | ||
| author_line_count.sh | ||
| BUILD.gn | ||
| class_usage.sh | ||
| compare_videos.py | ||
| DEPS | ||
| header_usage.sh | ||
| OWNERS | ||
| sanitizers_unittest.cc | ||
| simple_command_line_parser.cc | ||
| simple_command_line_parser.h | ||
| simple_command_line_parser_unittest.cc | ||
| video_analysis.py | ||
| video_analysis_test.py | ||