mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-17 07:37:51 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_processing/aec_dump
History
Mirko Bonadei 317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
..
aec_dump_factory.h Change StartAecDump methods to work with FILE* and FileWrapper 2019-06-11 13:43:36 +00:00
aec_dump_impl.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
aec_dump_impl.h Delete almost all includes of platform_file.h 2019-06-28 07:30:15 +00:00
aec_dump_integration_test.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
aec_dump_unittest.cc Format almost everything. 2019-07-08 13:45:15 +00:00
BUILD.gn Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
capture_stream_info.cc Add FixedGainController and move GainController2 in APM. 2018-02-16 10:56:38 +00:00
capture_stream_info.h Remove dependencies on modules:module_api from AudioProcessing. 2018-04-12 22:05:27 +00:00
mock_aec_dump.cc Reformat the WebRTC code base 2018-06-19 14:00:39 +00:00
mock_aec_dump.h Store RuntimeSetting in Aec Dumps. 2018-09-10 11:40:28 +00:00
null_aec_dump_factory.cc Change StartAecDump methods to work with FILE* and FileWrapper 2019-06-11 13:43:36 +00:00
write_to_file_task.cc Remove webrtc::ProtoString. 2019-02-16 11:11:45 +00:00
write_to_file_task.h Delete almost all includes of platform_file.h 2019-06-28 07:30:15 +00:00