mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-15 14:50:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_processing/aec
History
Alex Loiko e994058eb1 NaNs in Echo Canceller. 
A coherence vector cohxd is computed in
WebRtcAec_ComputeCoherence. The coherence values should theoretically
be 0 <= x <= 1. Due to the way they are computed that is not always
the case.

The coherence values are used to update an error signal
estimate hNl in webrtc::EchoSuppression. 'hNl[i]' should contain an
error magnitude for frequency 'i'.

The error magnitudes are used as a basis for exponentiation. If a
magnitude is negative, the result is NaN.

The NaNs will then spread to the output signal.

This change caps the hNl values at 0. I considered capping the
coherence values at 1. The coherence values are calculated differently
for MIPS, NEON and SSE. Therefore it's simpler to cap the hNl values
instead.

The issue was found by the AudioProcessing fuzzer.

Bug: chromium:804634
Change-Id: I8ebaa441d77c3f79d9c194a850cb2b9eed1c2024
Reviewed-on: https://webrtc-review.googlesource.com/43740
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21761}
2018-01-25 13:30:04 +00:00
..
aec_common.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
aec_core.cc NaNs in Echo Canceller. 2018-01-25 13:30:04 +00:00
aec_core.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
aec_core_mips.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
aec_core_neon.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
aec_core_optimized_methods.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
aec_core_sse2.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
aec_resampler.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
aec_resampler.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
echo_cancellation.cc Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
echo_cancellation.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
echo_cancellation_unittest.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
system_delay_unittest.cc Move some numeric utility code from rtc_base/ to rtc_base/numerics/ 2017-11-22 11:21:47 +00:00