mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-18 08:07:56 +01:00
ab009c27b4
This change refactors existing self-assignments within if clauses across the WebRTC codebase. *Why:* - Bug Prevention: Assignments within conditionals are frequently unintended errors, often mistaken for equality checks. - Clearer Code: Separating assignments from conditionals improves code readability and reduces the risk of misinterpretation. Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b Bug: chromium:361594695 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460 Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42850}
52 lines
1.6 KiB
Text
52 lines
1.6 KiB
Text
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCVideoEncoderSettings+Private.h"
|
|
|
|
#import "helpers/NSString+StdString.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCVideoEncoderSettings)
|
|
(Private)
|
|
|
|
- (instancetype)initWithNativeVideoCodec : (const webrtc::VideoCodec *)videoCodec {
|
|
self = [super init];
|
|
if (self) {
|
|
if (videoCodec) {
|
|
const char *codecName = CodecTypeToPayloadString(videoCodec->codecType);
|
|
self.name = [NSString stringWithUTF8String:codecName];
|
|
|
|
self.width = videoCodec->width;
|
|
self.height = videoCodec->height;
|
|
self.startBitrate = videoCodec->startBitrate;
|
|
self.maxBitrate = videoCodec->maxBitrate;
|
|
self.minBitrate = videoCodec->minBitrate;
|
|
self.maxFramerate = videoCodec->maxFramerate;
|
|
self.qpMax = videoCodec->qpMax;
|
|
self.mode = (RTCVideoCodecMode)videoCodec->mode;
|
|
}
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (webrtc::VideoCodec)nativeVideoCodec {
|
|
webrtc::VideoCodec videoCodec;
|
|
videoCodec.width = self.width;
|
|
videoCodec.height = self.height;
|
|
videoCodec.startBitrate = self.startBitrate;
|
|
videoCodec.maxBitrate = self.maxBitrate;
|
|
videoCodec.minBitrate = self.minBitrate;
|
|
videoCodec.maxBitrate = self.maxBitrate;
|
|
videoCodec.qpMax = self.qpMax;
|
|
videoCodec.mode = (webrtc::VideoCodecMode)self.mode;
|
|
|
|
return videoCodec;
|
|
}
|
|
|
|
@end
|