mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
7fa9057a05
This is part of a large-scale effort to increase adoption of absl::string_view across the WebRTC code base. This CL converts the majority of "const std::string&"s in function parameters under rtc_base/ to absl::string_view. Bug: webrtc:13579 Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Xavier Lepaul <xalep@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36239}
87 lines
3.5 KiB
C++
87 lines
3.5 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "rtc_base/experiments/field_trial_units.h"
|
|
|
|
#include <string>
|
|
|
|
#include "absl/strings/string_view.h"
|
|
#include "absl/types/optional.h"
|
|
#include "rtc_base/experiments/field_trial_parser.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
struct DummyExperiment {
|
|
FieldTrialParameter<DataRate> target_rate =
|
|
FieldTrialParameter<DataRate>("t", DataRate::KilobitsPerSec(100));
|
|
FieldTrialParameter<TimeDelta> period =
|
|
FieldTrialParameter<TimeDelta>("p", TimeDelta::Millis(100));
|
|
FieldTrialOptional<DataSize> max_buffer =
|
|
FieldTrialOptional<DataSize>("b", absl::nullopt);
|
|
|
|
explicit DummyExperiment(absl::string_view field_trial) {
|
|
ParseFieldTrial({&target_rate, &max_buffer, &period}, field_trial);
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
TEST(FieldTrialParserUnitsTest, FallsBackToDefaults) {
|
|
DummyExperiment exp("");
|
|
EXPECT_EQ(exp.target_rate.Get(), DataRate::KilobitsPerSec(100));
|
|
EXPECT_FALSE(exp.max_buffer.GetOptional().has_value());
|
|
EXPECT_EQ(exp.period.Get(), TimeDelta::Millis(100));
|
|
}
|
|
TEST(FieldTrialParserUnitsTest, ParsesUnitParameters) {
|
|
DummyExperiment exp("t:300kbps,b:5bytes,p:300ms");
|
|
EXPECT_EQ(exp.target_rate.Get(), DataRate::KilobitsPerSec(300));
|
|
EXPECT_EQ(*exp.max_buffer.GetOptional(), DataSize::Bytes(5));
|
|
EXPECT_EQ(exp.period.Get(), TimeDelta::Millis(300));
|
|
}
|
|
TEST(FieldTrialParserUnitsTest, ParsesDefaultUnitParameters) {
|
|
DummyExperiment exp("t:300,b:5,p:300");
|
|
EXPECT_EQ(exp.target_rate.Get(), DataRate::KilobitsPerSec(300));
|
|
EXPECT_EQ(*exp.max_buffer.GetOptional(), DataSize::Bytes(5));
|
|
EXPECT_EQ(exp.period.Get(), TimeDelta::Millis(300));
|
|
}
|
|
TEST(FieldTrialParserUnitsTest, ParsesInfinityParameter) {
|
|
DummyExperiment exp("t:inf,p:inf");
|
|
EXPECT_EQ(exp.target_rate.Get(), DataRate::Infinity());
|
|
EXPECT_EQ(exp.period.Get(), TimeDelta::PlusInfinity());
|
|
}
|
|
TEST(FieldTrialParserUnitsTest, ParsesOtherUnitParameters) {
|
|
DummyExperiment exp("t:300bps,p:0.3 seconds,b:8 bytes");
|
|
EXPECT_EQ(exp.target_rate.Get(), DataRate::BitsPerSec(300));
|
|
EXPECT_EQ(*exp.max_buffer.GetOptional(), DataSize::Bytes(8));
|
|
EXPECT_EQ(exp.period.Get(), TimeDelta::Millis(300));
|
|
}
|
|
TEST(FieldTrialParserUnitsTest, IgnoresOutOfRange) {
|
|
FieldTrialConstrained<DataRate> rate("r", DataRate::KilobitsPerSec(30),
|
|
DataRate::KilobitsPerSec(10),
|
|
DataRate::KilobitsPerSec(100));
|
|
FieldTrialConstrained<TimeDelta> delta("d", TimeDelta::Millis(30),
|
|
TimeDelta::Millis(10),
|
|
TimeDelta::Millis(100));
|
|
FieldTrialConstrained<DataSize> size(
|
|
"s", DataSize::Bytes(30), DataSize::Bytes(10), DataSize::Bytes(100));
|
|
ParseFieldTrial({&rate, &delta, &size}, "r:0,d:0,s:0");
|
|
EXPECT_EQ(rate->kbps(), 30);
|
|
EXPECT_EQ(delta->ms(), 30);
|
|
EXPECT_EQ(size->bytes(), 30);
|
|
ParseFieldTrial({&rate, &delta, &size}, "r:300,d:300,s:300");
|
|
EXPECT_EQ(rate->kbps(), 30);
|
|
EXPECT_EQ(delta->ms(), 30);
|
|
EXPECT_EQ(size->bytes(), 30);
|
|
ParseFieldTrial({&rate, &delta, &size}, "r:50,d:50,s:50");
|
|
EXPECT_EQ(rate->kbps(), 50);
|
|
EXPECT_EQ(delta->ms(), 50);
|
|
EXPECT_EQ(size->bytes(), 50);
|
|
}
|
|
|
|
} // namespace webrtc
|