mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-17 23:57:59 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/modules/audio_coding/acm2
History
Henrik Andreassson fc02a793c2 Revert "Piping audio interruption metrics to API layer" 
This reverts commit 299c4e6846.

Reason for revert: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/2753

../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc(539): error: Expected equality of these values:
  "ok-got-stats"
  ExecuteJavascript("verifyLegacyStatsGenerated()", tab)
    Which is: "Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing\n    at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15)\n    at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19"
With diff:
@@ -1,1 +1,3 @@
-ok-got-stats
+Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing
+    at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15)
+    at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19

Original change's description:
> Piping audio interruption metrics to API layer
>
> Bug: webrtc:10549
> Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
> Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27788}

TBR=henrik.lundin@webrtc.org,kwiberg@webrtc.org,ivoc@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10549
Change-Id: I345306ba9758c0a3b1597724fa860d3e3fdb8995
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134464
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27802}
2019-04-29 11:23:16 +00:00
..
acm_receive_test.cc Update ACM to use RTPHeader instead of WebRtcRTPHeader 2019-02-18 08:01:31 +00:00
acm_receive_test.h 2nd reland of https://webrtc-review.googlesource.com/c/src/+/114883 2019-02-22 09:59:01 +00:00
acm_receiver.cc Revert "Piping audio interruption metrics to API layer" 2019-04-29 11:23:16 +00:00
acm_receiver.h Update ACM to use RTPHeader instead of WebRtcRTPHeader 2019-02-18 08:01:31 +00:00
acm_receiver_unittest.cc Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData 2019-04-26 12:58:14 +00:00
acm_resampler.cc [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
acm_resampler.h [Cleanup] Add missing #include. Remove useless ones. 2018-10-23 11:32:56 +00:00
acm_send_test.cc Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData 2019-04-26 12:58:14 +00:00
acm_send_test.h Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData 2019-04-26 12:58:14 +00:00
audio_coding_module.cc Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData 2019-04-26 12:58:14 +00:00
audio_coding_module_unittest.cc Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData 2019-04-26 12:58:14 +00:00
call_statistics.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
call_statistics.h Move NetworkStatistics and AudioDecodingCallStats from common_types.h 2018-11-19 11:55:34 +00:00
call_statistics_unittest.cc Reformat the WebRTC code base 2018-06-19 14:00:39 +00:00