mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-18 08:07:56 +01:00
b2d5577caf
In addition to moving tools/mb -> tools-webrtc/mb, also move webrtc/build/mb_config.pyl into tools-webrtc/mb to match the default location better. Remove Chromium-specific check for 'mb validate' that failed due to doing this (we never cleaned that when we forked the code). BUG=webrtc:5006 TBR=ehmaldonado@webrtc.org NOTRY=True TESTED=Manually ran: tools-webrtc/mb/mb.py gen -m client.webrtc -b 'iOS64 Release' --config-file tools-webrtc/mb/mb_config.pyl //out/Release-iphoneos tools-webrtc/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file tools-webrtc/mb/mb_config.pyl //out/Release-mac Review-Url: https://codereview.webrtc.org/2585743002 . Cr-Commit-Position: refs/heads/master@{#15664}
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
results = []
|
|
|
|
# Run Pylint over the files in the directory.
|
|
pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api)
|
|
results.extend(input_api.RunTests(pylint_checks))
|
|
|
|
# Run the MB unittests.
|
|
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api, output_api, '.', [ r'^.+_unittest\.py$']))
|
|
|
|
# Validate the format of the mb_config.pyl file.
|
|
cmd = [input_api.python_executable, 'mb.py', 'validate']
|
|
kwargs = {'cwd': input_api.PresubmitLocalPath()}
|
|
results.extend(input_api.RunTests([
|
|
input_api.Command(name='mb_validate',
|
|
cmd=cmd, kwargs=kwargs,
|
|
message=output_api.PresubmitError)]))
|
|
|
|
results.extend(
|
|
input_api.canned_checks.CheckLongLines(
|
|
input_api,
|
|
output_api,
|
|
maxlen=80,
|
|
source_file_filter=lambda x: 'mb_config.pyl' in x.LocalPath()))
|
|
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|