mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 22:00:47 +01:00
ffd1f93a8d
This reverts commit 9c31ac2323.
Reason for revert: Breaks downstream project.
Original change's description:
> Tests for multi-stream Opus.
>
> This CL (mainly) adds bit-exactness tests for multi-stream Opus. The
> tests are in audio_coding_unittest.cc. Some refactoring of
> AcmSendTestOldApi, AcmSenderBitExactnessOldApi is done to make it
> possible. A few checks for "channels \in {1, 2}" are replaced with
> "channels \in {1, 2, 4, 6, 8}" in the WebRTC Opus codec wrapper. A few
> other changes are made to be able to write and read multi-channel WAV
> files.
>
> The SDP changes are NOT included; as of this CL there is no way to set
> up a multi-stream opus en/de-coder from SDP strings.
>
> Bug: webrtc:8649
> Change-Id: I1d93a9b8eecc3f6e19896ff2e2ce9b63da77a23c
> Reviewed-on: https://webrtc-review.googlesource.com/c/114883
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
> Commit-Queue: Alex Loiko <aleloi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26742}
TBR=aleloi@webrtc.org,ossu@webrtc.org
Change-Id: I0ac48b7320d31d3e7af33bf8714c3db6c807b82e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8649
Reviewed-on: https://webrtc-review.googlesource.com/c/123385
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26747}
70 lines
2.3 KiB
C++
70 lines
2.3 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/audio_codecs/opus/audio_encoder_opus_config.h"
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
|
|
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) || defined(WEBRTC_ARCH_ARM)
|
|
// If we are on Android, iOS and/or ARM, use a lower complexity setting by
|
|
// default, to save encoder complexity.
|
|
constexpr int kDefaultComplexity = 5;
|
|
#else
|
|
constexpr int kDefaultComplexity = 9;
|
|
#endif
|
|
|
|
constexpr int kDefaultLowRateComplexity =
|
|
WEBRTC_OPUS_VARIABLE_COMPLEXITY ? 9 : kDefaultComplexity;
|
|
|
|
} // namespace
|
|
|
|
constexpr int AudioEncoderOpusConfig::kDefaultFrameSizeMs;
|
|
constexpr int AudioEncoderOpusConfig::kMinBitrateBps;
|
|
constexpr int AudioEncoderOpusConfig::kMaxBitrateBps;
|
|
|
|
AudioEncoderOpusConfig::AudioEncoderOpusConfig()
|
|
: frame_size_ms(kDefaultFrameSizeMs),
|
|
num_channels(1),
|
|
application(ApplicationMode::kVoip),
|
|
bitrate_bps(32000),
|
|
fec_enabled(false),
|
|
cbr_enabled(false),
|
|
max_playback_rate_hz(48000),
|
|
complexity(kDefaultComplexity),
|
|
low_rate_complexity(kDefaultLowRateComplexity),
|
|
complexity_threshold_bps(12500),
|
|
complexity_threshold_window_bps(1500),
|
|
dtx_enabled(false),
|
|
uplink_bandwidth_update_interval_ms(200),
|
|
payload_type(-1) {}
|
|
AudioEncoderOpusConfig::AudioEncoderOpusConfig(const AudioEncoderOpusConfig&) =
|
|
default;
|
|
AudioEncoderOpusConfig::~AudioEncoderOpusConfig() = default;
|
|
AudioEncoderOpusConfig& AudioEncoderOpusConfig::operator=(
|
|
const AudioEncoderOpusConfig&) = default;
|
|
|
|
bool AudioEncoderOpusConfig::IsOk() const {
|
|
if (frame_size_ms <= 0 || frame_size_ms % 10 != 0)
|
|
return false;
|
|
if (num_channels != 1 && num_channels != 2)
|
|
return false;
|
|
if (!bitrate_bps)
|
|
return false;
|
|
if (*bitrate_bps < kMinBitrateBps || *bitrate_bps > kMaxBitrateBps)
|
|
return false;
|
|
if (complexity < 0 || complexity > 10)
|
|
return false;
|
|
if (low_rate_complexity < 0 || low_rate_complexity > 10)
|
|
return false;
|
|
return true;
|
|
}
|
|
} // namespace webrtc
|