mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

pc: Increase timeout for EndToEndCallWithSctpDataChannelFullBuffer

Browse source 
The timeout was not long enough in debug mode on slower machines.

Bug: chromium:40072842
Change-Id: Id82399cd7211abf5dd2e03ffa2ee4bd49f8c492f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/344680
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41971}
This commit is contained in:
Florent Castelli 2024-03-27 10:04:14 +00:00 committed by WebRTC LUCI CQ
parent b16b5808f5
commit 15e46aa358
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pc/data_channel_integrationtest.cc
View file

@ -295,8 +295,10 @@ TEST_P(DataChannelIntegrationTest, EndToEndCallWithSctpDataChannelFullBuffer) {
DataChannelInterface::DataState::kClosing,
DataChannelInterface::DataState::kClosed};
// Debug data channels are very slow, use a long timeout for those slow,
// heavily parallelized runs.
EXPECT_EQ_WAIT(DataChannelInterface::DataState::kClosed,
caller()->data_observer()->state(), kDefaultTimeout);
caller()->data_observer()->state(), kLongTimeout);
EXPECT_THAT(caller()->data_observer()->states(),
::testing::ElementsAreArray(expected_states));

1
pc/test/integration_test_helpers.h
View file

@ -141,6 +141,7 @@ using ::testing::Values;
using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
static const int kDefaultTimeout = 10000;
static const int kLongTimeout = 60000;
static const int kMaxWaitForStatsMs = 3000;
static const int kMaxWaitForActivationMs = 5000;
static const int kMaxWaitForFramesMs = 10000;