mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

[PCLF] In SFU emulation mode check that we have only one codec

Browse source 
Bug: None
Change-Id: I3607159f24529fc05300d850cc4c544978c52413
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231502
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34950}
This commit is contained in:
Artem Titov 2021-09-08 13:16:01 +02:00 committed by WebRTC LUCI CQ
parent 8e99c0160c
commit 32b6bc455c
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
test/pc/e2e/peer_connection_quality_test.cc
View file

@ -103,6 +103,21 @@ class FixturePeerConnectionObserver : public MockPeerConnectionObserver {
std::function<void()> on_connected_callback_; std::function<void()> on_connected_callback_;
}; };
void ValidateP2PSimulcastParams(
const std::vector<std::unique_ptr<PeerConfigurerImpl>>& peers) {
for (size_t i = 0; i < peers.size(); ++i) {
Params* p = peers[i]->params();
for (const VideoConfig& video_config : p->video_configs) {
if (video_config.simulcast_config) {
// When we simulate SFU we support only one video codec.
RTC_CHECK_EQ(p->video_codecs.size(), 1)
<< "Only 1 video codec is supported when simulcast is enabled in "
<< "at least 1 video config";
}
}
}
}
} // namespace } // namespace
PeerConnectionE2EQualityTest::PeerConnectionE2EQualityTest( PeerConnectionE2EQualityTest::PeerConnectionE2EQualityTest(
@ -168,6 +183,7 @@ PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer(
void PeerConnectionE2EQualityTest::Run(RunParams run_params) { void PeerConnectionE2EQualityTest::Run(RunParams run_params) {
SetDefaultValuesForMissingParams(&run_params, &peer_configurations_); SetDefaultValuesForMissingParams(&run_params, &peer_configurations_);
ValidateParams(run_params, peer_configurations_); ValidateParams(run_params, peer_configurations_);
ValidateP2PSimulcastParams(peer_configurations_);
RTC_CHECK_EQ(peer_configurations_.size(), 2) RTC_CHECK_EQ(peer_configurations_.size(), 2)
<< "Only peer to peer calls are allowed, please add 2 peers"; << "Only peer to peer calls are allowed, please add 2 peers";