mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Delete deprecated FecControllerFactoryInterface::CreateFecController variant

Browse source 
Bug: webrtc:10335
Change-Id: Id113133a9bf73830f16ac889e5e80633b5055279
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333841
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41491}
This commit is contained in:
Danil Chapovalov 2024-01-08 18:05:51 +01:00 committed by WebRTC LUCI CQ
parent dda037db07
commit c95ad5fe9d
2 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
api/BUILD.gn
View file

@ -890,7 +890,6 @@ rtc_source_set("fec_controller_api") {
deps = [ deps = [
"../modules:module_fec_api", "../modules:module_fec_api",
"../rtc_base:checks",
"environment", "environment",
"video:video_frame_type", "video:video_frame_type",
] ]

16
api/fec_controller.h
View file

@ -17,7 +17,6 @@
#include "api/environment/environment.h" #include "api/environment/environment.h"
#include "api/video/video_frame_type.h" #include "api/video/video_frame_type.h"
#include "modules/include/module_fec_types.h" #include "modules/include/module_fec_types.h"
#include "rtc_base/checks.h"
namespace webrtc { namespace webrtc {
// TODO(yinwa): work in progress. API in class FecController should not be // TODO(yinwa): work in progress. API in class FecController should not be
@ -91,21 +90,8 @@ class FecControllerFactoryInterface {
public: public:
virtual ~FecControllerFactoryInterface() = default; virtual ~FecControllerFactoryInterface() = default;
// TODO: bugs.webrtc.org/10335 - make pure virtual when implemented by derived
// classes.
virtual std::unique_ptr<FecController> CreateFecController( virtual std::unique_ptr<FecController> CreateFecController(
const Environment& env) { const Environment& env) = 0;
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
return CreateFecController();
#pragma clang diagnostic pop
}
// TODO: bugs.webrtc.org/10335 - delete when implementation is removed from
// the derived classes.
[[deprecated]] virtual std::unique_ptr<FecController> CreateFecController() {
RTC_CHECK_NOTREACHED();
}
}; };
} // namespace webrtc } // namespace webrtc