mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-12 21:30:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reassign TODO from self to bug with more context

Browse source 
No-try: true
Bug: webrtc:14449
Change-Id: Iab1954d4a7a2fd791ad2ac97062ac73d5ce372dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296581
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39501}
This commit is contained in:
Danil Chapovalov 2023-03-07 18:31:07 +01:00 committed by WebRTC LUCI CQ
parent c8c25e5bdf
commit f4dfa1ce01
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
logging/rtc_event_log/rtc_event_log_impl.cc
View file

@ -112,9 +112,9 @@ bool RtcEventLogImpl::StartLogging(std::unique_ptr<RtcEventLogOutput> output,
void RtcEventLogImpl::StopLogging() {
RTC_DLOG(LS_INFO) << "Stopping WebRTC event log.";
// TODO(danilchap): Do not block current thread waiting on the task queue.
// It might work for now, for current callers, but disallows caller to share
// threads with the `task_queue_`.
// TODO(bugs.webrtc.org/14449): Do not block current thread waiting on the
// task queue. It might work for now, for current callers, but disallows
// caller to share threads with the `task_queue_`.
rtc::Event output_stopped;
StopLogging([&output_stopped]() { output_stopped.Set(); });
output_stopped.Wait(rtc::Event::kForever);