Erik Språng
bada9dd30c
Revert "Add mitigation for very long frame drop gaps with vp8"
...
This reverts commit 0d4b350006https://webrtc-review.googlesource.com/c/src/+/322320
> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
> Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
> Auto-Submit: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40866}
Bug: webrtc:15530
Change-Id: I920661835f0e59c0543794222e42b5643017db24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322443
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40871}
2023-10-05 11:00:47 +00:00
Mirko Bonadei
12199b1f96
Roll chromium_revision 1a86984556..de49bd6f22 (1204416:1205695)
...
Change log: 1a86984556..de49bd6f221a86984556..de49bd6f2219c600fca5..858655d3c08a44cdc629..76f5031632c8bee3e69d..c3c28168c6533f961c05..c5c008727486a2370993..73590462a655c4796b77..3799cfa702https://chromium.googlesource.com/catapult.git/+log/b018f901e8..1a33dd1f59
* src/third_party/depot_tools: f90b3b035c..c2e00617230ba3773340..0d75f366d50343396e49..bcb9ef187605fe2a64f5..0eb5ce7284a094e2535c..e0cb589445e8e4eb8f1c..b6e1ac16497608093d21..2ce7927479d44dbe4ad2..8e5b8483f38a2e7818c8..b40f8fd9a81a86984556..de49bd6f221a86984556..de49bd6f22https://webrtc-review.googlesource.com/c/src/+/322424
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40870}
2023-10-05 10:33:16 +00:00
Markus Handell
a84368c3d3
TaskQueueBase: use C++17.
...
Fixed: webrtc:15371
Bug: webrtc:15371
Change-Id: I8bdcd733a7f43eb5e91986dfa478ad41e5074afd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320020
Auto-Submit: Markus Handell <handellm@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40869}
2023-10-05 10:04:47 +00:00
Mirko Bonadei
fd9ac12756
Add more owners to build_overrides.
...
Bug: None
Change-Id: Ie8be9cde1a453003859e6c55db6cbf3dd8038cb5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322441
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40868}
2023-10-05 09:32:59 +00:00
webrtc-version-updater
7c5a35fc30
Update WebRTC code version (2023-10-05T04:12:20).
...
Bug: None
Change-Id: Id475e53ac06c59042a186e08f71a67fa9d9052ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322481
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40867}
2023-10-05 05:57:28 +00:00
Erik Språng
0d4b350006
Add mitigation for very long frame drop gaps with vp8
...
Bug: webrtc:15530
Change-Id: I11f5e3f31f71301700dbff3fc9285236160bee45
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322320
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40866}
2023-10-04 14:22:31 +00:00
Sergey Sukhanov
4b84f01fe2
Change the type of PacedPacketInfo::send_bitrate_bps from int to strongly-typed DataRate.
...
Bug: webrtc:15532
Change-Id: I84a6b9860d582d68beccdcfde4a12923b2cdbe8b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322181
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40865}
2023-10-04 14:20:22 +00:00
Jeremy Leconte
532a11ee72
[PCLF] Add an API to configure field trials.
...
Change-Id: Ic37a4b2f86976b2f2eace225b6eefacd1c3bd046
Bug: b/303192724
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322321
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40864}
2023-10-04 12:08:37 +00:00
webrtc-version-updater
45d8674b45
Update WebRTC code version (2023-10-04T04:04:01).
...
Bug: None
Change-Id: Ifa04cc89b44f35438a7c3e8693477267ac5d0b4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322341
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40863}
2023-10-04 05:45:37 +00:00
Saúl Ibarra Corretgé
4408575d18
Reland "Enable SRTP GCM ciphers by default"
...
This is a reland of commit d8633868b3https://webrtc-review.googlesource.com/c/src/+/305381
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Philipp Hancke <phancke@microsoft.com>
> Reviewed-by: Victor Boivie <boivie@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40828}
Bug: webrtc:15178
Change-Id: I5ea939ed6263547ebc177d9dd1763ba888936866
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321961
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40862}
2023-10-03 22:39:48 +00:00
qwu16
8db8824536
Fix use-of-uninitialized-value and integer-overflow issues reported by chromium fuzz testing
...
Bug: chromium:1485906,chromium:1486414
Change-Id: Ia976926fb08405c1cb03bbcfde07d2076bd6f4c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321545
Reviewed-by: Erik Språng <sprang@google.com>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40861}
2023-10-03 14:17:06 +00:00
henrika
40ed3ff07e
Improved event tracing in FrameCadenceAdapter
...
This CL is a minor cleanup of the work done earlier in [1].
We now remove the arguments which contained the measured delta times
between two TRACE_EVENT_ASYNC_BEGIN and TRACE_EVENT_ASYNC_END events.
Also, the ID for FrameToQueue1 is now unique which was not the case
previously.
The same information can be obtained from the `slice` table and the
`dur` key.
Also renames the events to OnFrameToEncode (total), OnFrameToQueue and
QueueToEncode to match what it measures better.
[1] https://webrtc-review.googlesource.com/c/src/+/322121
Bug: webrtc:15456
Change-Id: Ibe2d7bb53380710671c2c36012dcd573942bae69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322220
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40860}
2023-10-03 12:31:13 +00:00
webrtc-version-updater
9209b50527
Update WebRTC code version (2023-10-03T04:04:07).
...
Bug: None
Change-Id: I5acdb2082667ff186c469b5a5a2b0768e6bc1aa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322260
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40859}
2023-10-03 05:57:11 +00:00
chromium-webrtc-autoroll
3725398e2a
Roll chromium_revision 6a1112fe10..1a86984556 (1204286:1204416)
...
Change log: 6a1112fe10..1a869845566a1112fe10..1a869845560e9e349c40..19c600fca5690dc92b42..8a44cdc62950c348906c..c8bee3e69d50cbb98de4..533f961c0529a09864e6..86a2370993921a7946ae..55c4796b77https://chromium.googlesource.com/catapult.git/+log/4f81c1e295..b018f901e8
* src/third_party/depot_tools: 90a30a5b53..f90b3b035c7cf98622ab..a094e2535c43e5a34c5b..7608093d21a3d4c1de9b..d44dbe4ad26ed8cc384a..8a2e7818c86a1112fe10..1a86984556https://webrtc-review.googlesource.com/c/src/+/322240
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40858}
2023-10-03 02:53:15 +00:00
chromium-webrtc-autoroll
4e5ae32b0d
Roll chromium_revision 45a884046b..6a1112fe10 (1203912:1204286)
...
Change log: 45a884046b..6a1112fe1045a884046b..6a1112fe100a5148acfe..0e9e349c40bc10f9ffb9..690dc92b42350297b9b4..50cbb98de4074ff55a07..29a09864e66b9e7118bf..921a7946ae26cc39e59b..758bd21f10d3bf532f84..a3d4c1de9b33a950a48c..6ed8cc384a45a884046b..6a1112fe10https://webrtc-review.googlesource.com/c/src/+/322166
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40857}
2023-10-02 22:58:41 +00:00
Victor Boivie
a55746808e
dcsctp: Only process meaningful FORWARD-TSN
...
Similar to change I602a8552a9a4c853684fcf105309ec3d8073f2c2, which
ensured that only new DATA chunks would be processed by the reassembly
queue by utilizing the data tracker, the same is done for FORWARD-TSN
chunks.
By having the data tracker gate keeping what is provided to the
reassembly queue, the reassembly queue can be simplified as well, which
is an added bonus, by removing last_assembled_tsn_watermark_ and
reassembled_messages_ as those were protecting the queue from
re-delivering messages it had already delivered, but as now the data
tracker would ensure that it wouldn't re-process DATA/FORWARD-TSNs, that
would have the same effect. In this CL, we will still update those
variables and save to the handover state, but not actually read from
them, and then when this change has been rolled out on the servers, I
can remove the variables as well.
The core change is to move validation from ReassemblyQueue::Handle
to DataTracker::HandleForwardTsn.
Some tests have been moved/replicated into data_tracker_test.cc to
ensure that it catches the issues that the reassembly queue did earlier.
Bug: webrtc:14600
Change-Id: I75c1d5911185d594f73c8b1e6bcf776e88f5b7c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321603
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40856}
2023-10-02 16:05:11 +00:00
Harald Alvestrand
8e007bacda
Remove field trial WebRTC-Turn-AllowSystemPorts
...
There's no trace of it being in use, so let's remove it.
Bug: webrtc:12497
Change-Id: I9e81ef58b459b5a0b9f79b6638231a3a19eb8a0e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322180
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40855}
2023-10-02 15:09:40 +00:00
henrika
bce7ce7ba0
Adds support for tracking OnFrame PostTask delta times
...
Does not change any functionality but improves the ability to look
for (using Perfetto) possible latency issues where a posted task might
be prevented from running.
Bug: webrtc:15456
Change-Id: I522599c646c8de2183074628df9cab337b1cb85d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322121
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40854}
2023-10-02 12:03:36 +00:00
chromium-webrtc-autoroll
4d2d215b73
Roll chromium_revision cd02ca7e29..45a884046b (1203806:1203912)
...
Change log: cd02ca7e29..45a884046bcd02ca7e29..45a884046b4bd1370aa7..0a5148acfe5c9250c64c..bc10f9ffb98326446e62..350297b9b402e36d1497..074ff55a07f27b31bc35..6b9e7118bff95244890e..d3bf532f8476baa86950..33a950a48ccd02ca7e29..45a884046bhttps://webrtc-review.googlesource.com/c/src/+/322162
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40853}
2023-10-02 10:41:42 +00:00
webrtc-version-updater
3272a9926c
Update WebRTC code version (2023-10-02T04:11:24).
...
Bug: None
Change-Id: I09378714121ace25b0738c83dec186757bb39290
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322109
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40852}
2023-10-02 06:03:52 +00:00
chromium-webrtc-autoroll
316c853f0e
Roll chromium_revision b294093253..cd02ca7e29 (1203697:1203806)
...
Change log: b294093253..cd02ca7e29b294093253..cd02ca7e2984c053332c..5c9250c64ccf08af2a02..02e36d1497b294093253..cd02ca7e29https://webrtc-review.googlesource.com/c/src/+/322106
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40851}
2023-10-01 22:27:15 +00:00
webrtc-version-updater
9cefc2418b
Update WebRTC code version (2023-10-01T04:06:57).
...
Bug: None
Change-Id: I9aff101107f548bf6e45143e23607c8ba68ec470
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322080
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40850}
2023-10-01 05:58:33 +00:00
chromium-webrtc-autoroll
cad0bfa566
Roll chromium_revision 7be4bb3958..b294093253 (1203597:1203697)
...
Change log: 7be4bb3958..b2940932537be4bb3958..b294093253db158725fa..4bd1370aa7ece39eb658..50c348906ccb8060928e..8326446e629f6812c5d9..cf08af2a020fa2ea7cfa..f27b31bc358a241ea043..7cf98622ab2a019f0917..76baa869507be4bb3958..b294093253https://webrtc-review.googlesource.com/c/src/+/322062
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40849}
2023-09-30 18:24:26 +00:00
webrtc-version-updater
82120611f8
Update WebRTC code version (2023-09-30T04:13:02).
...
Bug: None
Change-Id: Idfa2ffd3f0768073d229f03e92b7d49bdaea022e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321987
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40848}
2023-09-30 05:51:28 +00:00
chromium-webrtc-autoroll
7d8ef102b5
Roll chromium_revision a53f87ab6b..7be4bb3958 (1203480:1203597)
...
Change log: a53f87ab6b..7be4bb3958a53f87ab6b..7be4bb39586750f0014b..84c053332c5489d4c4ac..cb8060928ea8b80d4a56..9f6812c5d935122c3522..0fa2ea7cfahttps://chromium.googlesource.com/catapult.git/+log/a217ecb5ad..4f81c1e295
* src/third_party/depot_tools: 4c1d6d90bc..90a30a5b53724cd40fb6..43e5a34c5b5773ad947c..f95244890ecdb767e3db..2a019f0917a53f87ab6b..7be4bb3958https://webrtc-review.googlesource.com/c/src/+/322021
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40847}
2023-09-30 03:43:33 +00:00
chromium-webrtc-autoroll
11f087d917
Roll chromium_revision 9b3bfd6cf6..a53f87ab6b (1203365:1203480)
...
Change log: 9b3bfd6cf6..a53f87ab6b9b3bfd6cf6..a53f87ab6bbd63518334..db158725fab169b3adec..6750f0014b7dc833b546..5489d4c4ace153912826..a8b80d4a566fc8d4e7db..35122c3522https://aomedia.googlesource.com/aom.git/+log/96983fe072..0d59418942
* src/tools: 6c4073f340..cdb767e3db9b3bfd6cf6..a53f87ab6bhttps://webrtc-review.googlesource.com/c/src/+/321985
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40846}
2023-09-29 22:49:23 +00:00
chromium-webrtc-autoroll
02d5ba158d
Roll chromium_revision 3882779f44..9b3bfd6cf6 (1203188:1203365)
...
Change log: 3882779f44..9b3bfd6cf63882779f44..9b3bfd6cf68d7feb8c90..bd6351833423812209f6..b169b3adecd816f9909b..7dc833b54643c2f65fcc..e1539128268b6d900c65..6fc8d4e7dbe0e5b838e5..7b308a29dde879b2e2ee..5773ad947c20e01c5666..6c4073f3403882779f44..9b3bfd6cf6https://webrtc-review.googlesource.com/c/src/+/321983
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40845}
2023-09-29 18:58:17 +00:00
Linus Nilsson
dd15070b45
Adopt EglThread in EglRenderer once again.
...
The regression obseverved on Samung devices the last time was caused
by the not detaching the context/surface prior to releasing an
EGLSurface or EGLContext. This was fine on most devices but obviously
not all.
Bug: b/225229697
Change-Id: I1849c772f3ed3e8819c748d997e5261289c4b2bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321842
Commit-Queue: Linus Nilsson <lnilsson@webrtc.org>
Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40844}
2023-09-29 13:37:21 +00:00
chromium-webrtc-autoroll
7d3eb10c7e
Roll chromium_revision 2cd0974cfa..3882779f44 (1202869:1203188)
...
Change log: 2cd0974cfa..3882779f442cd0974cfa..3882779f444df756689b..8d7feb8c907acd4f8b8d..23812209f62c6e20e2ff..ece39eb6589f00f7555b..d816f9909b6026e857ed..43c2f65fccd068a9b509..8b6d900c65https://chromium.googlesource.com/catapult.git/+log/72a5f0b7ef..a217ecb5ad
* src/third_party/depot_tools: 68318472db..4c1d6d90bc055d494c5c..8a241ea043a38d6a9fc0..e879b2e2ee59a54b4003..20e01c56662cd0974cfa..3882779f44https://webrtc-review.googlesource.com/c/src/+/322020
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40843}
2023-09-29 13:25:43 +00:00
Manashi Sarkar
c27034b694
Revert "Expose getCapabilities/setCodecPreferences for objc"
...
This reverts commit a2f30e1a75https://webrtc-review.googlesource.com/c/src/+/305200
> Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
> Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
> Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40841}
Bug: None
Change-Id: I60d65cdb674a7fb535a9f8e91f346f50c396744d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322000
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Manashi Sarkar <manashi@google.com>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40842}
2023-09-29 12:00:49 +00:00
David Liu
a2f30e1a75
Expose getCapabilities/setCodecPreferences for objc
...
Bug: None
Change-Id: I31cf22bae595cf2b995ff648523d25485106fcd5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305200
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40841}
2023-09-29 11:31:43 +00:00
Philipp Hancke
012c5a3419
Remove more Codec-related templating in MediaSession
...
BUG=webrtc:15214
Change-Id: I6b4db5e8ef1523e06fdaaa321f3df10fa19bff86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321841
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40840}
2023-09-29 10:52:27 +00:00
Danil Chapovalov
34ec5c3f20
Clear PacketBuffer on large negative jumps at the start of the video stream
...
PacketBuffer is not designed to store wide range of the rtp sequence numbers
Bug: webrtc:15508
Change-Id: I62b19ba2896a667d795a41c38a60f55ee3f60566
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321845
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@google.com>
Cr-Commit-Position: refs/heads/main@{#40839}
2023-09-29 08:56:15 +00:00
Harald Alvestrand
e9f9c28d48
Set permissions on experiments/field_trials.py
...
Since the previous policy was "anyone can add one", we're allowing
anyone to update this file for the time being.
Bug: webrtc:14154
Change-Id: Ib979797044f5eef014dce427ba6ad98837a98b46
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321960
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40838}
2023-09-29 08:17:15 +00:00
Emil Lundmark
a61b334a12
Relax the field trial policy to not require an open bug
...
Having an associated bug with an owner should be sufficient information
for determining the status of a field trial. See the discussion starting
at [1] for more context.
[1] https://crbug.com/webrtc/14154#c11
Bug: webrtc:14154
No-Try: true
Change-Id: I7054ba25eac2af852a0d08770037938571e38921
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321862
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40837}
2023-09-29 08:03:21 +00:00
Emil Lundmark
5e252b7fa5
Register WebRTC-Bwe-SubtractAdditionalBackoffTerm
...
It was introduced with 98e71f57eahttps://webrtc-review.googlesource.com/c/src/+/321844
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40836}
2023-09-29 07:26:08 +00:00
webrtc-version-updater
191dd8811f
Update WebRTC code version (2023-09-29T04:02:17).
...
Bug: None
Change-Id: I167193be5cfa532ba4eaa199e890d61b868f9aa1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321941
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40835}
2023-09-29 05:55:13 +00:00
chromium-webrtc-autoroll
ea32ab12eb
Roll chromium_revision 2506ef1631..2cd0974cfa (1202675:1202869)
...
Change log: 2506ef1631..2cd0974cfa2506ef1631..2cd0974cfa2bb8ce58b1..4df756689be5b7a93f2c..7acd4f8b8de1a9a453a2..9f00f7555b12e884d1ba..6026e857ed31edcc46d6..d068a9b509https://chromium.googlesource.com/catapult.git/+log/328888ea45..72a5f0b7ef
* src/third_party/depot_tools: 34e0ecf20e..68318472db116a2d5dc0..a38d6a9fc05d69d7e3a9..59a54b40032506ef1631..2cd0974cfahttps://webrtc-review.googlesource.com/c/src/+/321901
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40834}
2023-09-28 23:47:48 +00:00
chromium-webrtc-autoroll
5ee308b449
Roll chromium_revision 116647225e..2506ef1631 (1202523:1202675)
...
Change log: 116647225e..2506ef1631116647225e..2506ef1631226ff96839..2bb8ce58b1ddf84d52d6..e5b7a93f2cd3aa14fe6f..e1a9a453a2a151ef21fd..12e884d1babebeb00015..31edcc46d6d5143d26fa..116a2d5dc0afa4d85c5a..5d69d7e3a9116647225e..2506ef1631https://webrtc-review.googlesource.com/c/src/+/321825
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40833}
2023-09-28 16:47:13 +00:00
Manashi Sarkar
c2bbe4b952
Revert "Enable SRTP GCM ciphers by default"
...
This reverts commit d8633868b3https://webrtc-review.googlesource.com/c/src/+/305381
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Philipp Hancke <phancke@microsoft.com>
> Reviewed-by: Victor Boivie <boivie@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40828}
Bug: webrtc:15178
Change-Id: I88433e899cb4b705eafa3fceff3edc520629f603
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321863
Owners-Override: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Manashi Sarkar <manashi@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40832}
2023-09-28 14:42:18 +00:00
Philipp Hancke
ebe207f71c
Add field trial for enabling SSL client hello extension permutation
...
using WebRTC-PermuteTlsClientHello as a field trial.
This has been launched in Chromium already:
https://groups.google.com/a/chromium.org/g/blink-dev/c/bYZK81WxYBo/m/lKLrZ_P2BwAJ
WebRTC-specific I2S:
https://groups.google.com/a/chromium.org/g/blink-dev/c/1CIKec0W1fg
Chromestatus entry:
https://chromestatus.com/feature/5191245718880256
BUG=webrtc:15467
Change-Id: I18f4065661bbe2db03e1823d7bfba4c9b60046aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318640
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40831}
2023-09-28 13:34:38 +00:00
chromium-webrtc-autoroll
a1475c2210
Roll chromium_revision f7fb707ebb..116647225e (1201480:1202523)
...
Change log: f7fb707ebb..116647225ef7fb707ebb..116647225e7d979505e8..226ff968395f393261bc..ddf84d52d69d9c064e40..2c6e20e2ff74621ea7bd..d3aa14fe6f3c3be88d84..a151ef21fd5005138049..bebeb00015https://boringssl.googlesource.com/boringssl.git/+log/a1843d660b..d24a38200f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0a5cbdd220..328888ea45
* src/third_party/depot_tools: d95084e851..34e0ecf20ehttps://aomedia.googlesource.com/aom.git/+log/82018abee6..96983fe072
* src/third_party/libc++/src: 26cbb86c20..055d494c5cc28dc42f0d..e8e4eb8f1cf2ca661b1d..724cd40fb66da1bd01d6..38a707faeff92196dfb6..d5143d26fa295b391656..afa4d85c5af7fb707ebb..116647225ehttps://webrtc-review.googlesource.com/c/src/+/321784
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40830}
2023-09-28 13:21:39 +00:00
Victor Boivie
a93f581705
dcsctp: Don't generate FORWARD-TSN across stream resets
...
This was a fun bug which proved to be challenging to find a good
solution for. The issue comes from the combination of partial
reliability and stream resetting, which are covered in different RFCs,
and where they don't refer to each other...
Stream resetting (RFC 6525) is used in WebRTC for closing a Data
Channel, and is done by signaling to the receiver that the stream
sequence number (SSN) should be set to zero (0) at some time. Partial
reliability (RFC 3758) - and expiring messages that will not be
retransmitted - is done by signaling that the SSN should be set to a
certain value at a certain TSN, as the messages up until the provided
SSN are not to be expected to be sent again.
As these two functionalities both work by signaling to the receiver
what the next expected SSN should be, they need to do it correctly not
to overwrite each others' intent. And here was the bug. An example
scenario where this caused issues, where we are Z (the receiver),
getting packets from the sender (A):
5 A->Z DATA (TSN=30, B, SID=2, SSN=0)
6 Z->A SACK (Ack=30)
7 A->Z DATA (TSN=31, E, SID=2, SSN=0)
8 A->Z RE_CONFIG (REQ=30, TSN=31, SID=2)
9 Z->A RE_CONFIG (RESP=30, Performed)
10 Z->A SACK (Ack=31)
11 A->Z DATA (TSN=32, SID=1)
12 A->Z FORWARD_TSN (TSN=32, SID=2, SSN=0)
Let's assume that the path Z->A had packet loss and A never really
received our responses (#6 , #9 , #10 ) in time.
At #5 , Z receives a DATA fragment, which it acks, and at #7 the end of
that message. The stream is then reset (#8 ) which it signals that it
was performed (#9 ) and acked (#10 ), and data on another stream (2) was
received (#11 ). Since A hasn't received any ACKS yet, and those chunks
on SID=2 all expired, A sends a FORWARD-TSN saying that "Skip to TSN=32,
and don't expect SID=2, SSN=0". That makes the receiver expect the SSN
on SID=2 to be SSN=1 next time at TSN=32.
But that's not good at all - A reset the stream at #8 and will want to
send the next message on SID=2 using SSN=0 - not 1. The FORWARD-TSN
clearly can't have a TSN that is beyond the stream reset TSN for that
stream.
This is just one example - combining stream resetting and partial
reliability, together with a lossy network, and different variants of
this can occur, which results in the receiver possibly not delivering
packets because it expects a different SSN than the one the sender is
later using.
So this CL adds "breakpoints" to how far a FORWARD-TSN can stretch. It
will simply not cross any Stream Reset last assigned TSNs, and only when
a receiver has acked that all TSNs up till the Stream Reset last
assigned TSN has been received, it will proceed expiring chunks after
that.
Bug: webrtc:14600
Change-Id: Ibae8c9308f5dfe8d734377d42cce653e69e95731
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321600
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40829}
2023-09-28 11:31:02 +00:00
Saúl Ibarra Corretgé
d8633868b3
Enable SRTP GCM ciphers by default
...
Bug: webrtc:15178
Change-Id: I0216ce8f194fffc820723d82b9c04a76573c2f4f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305381
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40828}
2023-09-28 10:18:56 +00:00
Björn Terelius
98e71f57ea
Subtract an additional 5kbps of the bitrate when backing off.
...
Traditionally, we'd back off to 85% of the measured throughput in response to an overuse. However, this backoff doesn't appear to be sufficient to drain the queues in some low-bitrate scenarios, and the problem has gotten a bit worse with the RobustThroughputEstimator. (The new estimate looks more stable. The old estimator had more variation, the lowest points were lower, causing backoffs to lower rates.)
With this change, we back off to 0.85*thoughput-5kbps. The difference is negligible except at low bitrates.
Bug: webrtc:13402,b/298636540
Change-Id: I53328953c056b8ad77f6c7561d6017f171b2dfbc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321701
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40827}
2023-09-28 09:36:36 +00:00
Philipp Hancke
332c56f087
MediaSession: ensure transport description factory exists
...
BUG=None
Change-Id: Ic29526c0c182257331d81ff3e66c5ae91ddf4ce1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321186
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40826}
2023-09-28 08:26:05 +00:00
Florent Castelli
bbc7711878
Reduce log verbosity in codec selection implementation
...
Bug: webrtc:15064
Change-Id: I42a68987842d970437a0e00f318e2a97a80829e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321700
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40825}
2023-09-28 07:57:06 +00:00
Danil Chapovalov
2d508f10d3
Deprecate old names for EncodedImage::RtpTimestamp accessor and setter
...
Replace remaining webrtc usage of the deprecated names.
Bug: webrtc:9378
Change-Id: Ie5bd2d3eaf68316e7c827fc35c7c7d8e2eadeb9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321584
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40824}
2023-09-28 07:29:22 +00:00
Philipp Hancke
f97058e9ed
Move static functions in media_session into anonymous namespace
...
and clean up methods that are now detected as unused.
BUG=None
Change-Id: If5dac3d43d4df6c7c108504c202c2383fe4a3f27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321580
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40823}
2023-09-28 06:47:48 +00:00
Sergey Silkin
21b5ec1cc7
Add AV1 singlecast bitrate limits
...
Bug: b/300060059
Change-Id: I07763632b9fec19dae9d676bb2488cd7d2191e76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321660
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Michael Horowitz <mhoro@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40822}
2023-09-27 22:19:55 +00:00
