mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-14 14:20:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
40253 commits 2 branches 91 tags 415 MiB
Commit graph

40253 commits

This branch
This branch
All branches
Author SHA1 Message Date
Emil Lundmark
d12e75997c Add instructions for adding and removing field trials 
Since the registry now also stores the end date, the bug doesn't have to
specify this.

Bug: webrtc:14154
Change-Id: I94dee43105079607ff9d820e238018304eb441a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321582
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40821}
 2023-09-27 07:41:45 +00:00
Harald Alvestrand
83894d3847 Fire MaybeSignalReadyToSend in a PostTask when recursive 
Speculative fix. Writing the test for it is more complex.

Bug: chromium:1483874
Change-Id: Icfaf1524b0499c609010753e0b6f3cadbd0e98f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321480
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40820}
 2023-09-27 07:36:40 +00:00
Emil Lundmark
4001cc7453 Populate field trial registry 
The lists has been constructed by grepping the code base from commit
bfc2a3553d ("Remove more codec-related templating") using the PCRE
'(?<=")WebRTC-[^\s/"]+' and manually removing some false positives. Each
field trials has then, on a best effort basis, been associated with a
bug by doing a reverse git log lookup and using the corresponding bug
tag that was associated with the commit where the field trial key was
first introduced.

The field trials are divided into active and policy exempt. The latter
are for field trials that were added before commit c4a35898d9 ("Add
documentation for field trials") which introduced the new policy that
field trials henceforth needs to be registered. These field trials may
not have an associated bug nor an end date.

For all field trials that have been deemed experimentational, including
many policy exempt ones, an initial end date of 2024-04-01 has been
chosen. This date was chosen based on that the policy was introduced on
2022-06-23 and will give about 6 month grace period to allow cleanup of
potentially already expired field trials. Owners are of course free to
adjust the end date at a later time.

The lists have been validated by running most tests with the following
GN arg set:

rtc_strict_field_trials = "dcheck"

Bug: webrtc:14154
Change-Id: Ic86d96933fbe0f18393ec57d36719a382855c694
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321581
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40819}
 2023-09-27 07:35:38 +00:00
Emil Lundmark
5543a967cd Add sub-command for validating that field trials conforms to the policy 
Bug: webrtc:14154
Change-Id: I2c12351abaa956ca5a38ab911c8cf887b4453958
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321184
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40818}
 2023-09-27 07:32:35 +00:00
Emil Lundmark
9686a4b580 Add sub-command for listing expired field trials 
Bug: webrtc:14154
Change-Id: I9c5c8c4a177fb863af7e2c0ed7fa99454019cfbe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321183
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40817}
 2023-09-27 07:29:34 +00:00
Emil Lundmark
b7fca15fd4 Refactor global variables to be immutable 
Bug: None
Change-Id: I764018705df668f83e9d8ac90766aa6b06c44614
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321182
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40816}
 2023-09-27 07:23:18 +00:00
Emil Lundmark
7d81e18ac0 Reformat field_trials.py to follow PEP-8 
Bug: None
Change-Id: I29fffef124e3ca54ec2075bbae005fd5fdd75e83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321181
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40815}
 2023-09-27 07:20:45 +00:00
Palak Agarwal
0505115b5c Pass the correct abs_capture_timestamp while cloning audio frame 
This change replaces type of absolute_capture_timestamp_ms_ in
TransformableOutgoingAudioFrame from int to optional uint and makes
the function AbsoluteCaptureTimestamp() inside
TransformableAudioFrameInterface pure virtual.

Bug: webrtc:14949
Change-Id: Id3bdbcba63a5f91105ab198208e4f2b11eb3c7db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319000
Commit-Queue: Palak Agarwal <agpalak@google.com>
Reviewed-by: Tony Herre <herre@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40814}
 2023-09-26 15:57:52 +00:00
chromium-webrtc-autoroll
3218d743be Roll chromium_revision ae93f006ea..f7fb707ebb (1201360:1201480) 
Change log: ae93f006ea..f7fb707ebb
Full diff: ae93f006ea..f7fb707ebb

Changed dependencies
* src/build: 2dca8e553d..5f393261bc
* src/buildtools: d21375885b..9d9c064e40
* src/ios: 45c7179359..74621ea7bd
* src/testing: 51cfed6400..3c3be88d84
* src/third_party: 02772896c1..5005138049
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7c462e0d55..0a5cbdd220
* src/third_party/depot_tools: 0827dd28f1..d95084e851
* src/third_party/freetype/src: 49781ab72b..e0e5b838e5
* src/third_party/perfetto: c478eb8ffb..f92196dfb6
* src/tools: da07715f84..295b391656
DEPS diff: ae93f006ea..f7fb707ebb/DEPS

No update to Clang.

BUG=None

Change-Id: I90551cee8aa835cdf908fc7ddc08fd82cb07f02f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321547
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40813}
 2023-09-26 12:45:07 +00:00
Philipp Hancke
2bf1b99c6d Make CreateOffer/CreateAnswer return RTCErrorOr<SessionDescription> 
BUG=webrtc:15499

Change-Id: I8b128fcd9a1114ae4625777a27f074a8314ef190
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320720
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40812}
 2023-09-26 09:41:30 +00:00
Victor Boivie
06fbe63cbf dcsctp: Exit deferred stream reset on FORWARD-TSN 
https://datatracker.ietf.org/doc/html/rfc6525#section-5.2.2:

E2:  If the Sender's Last Assigned TSN is greater than the cumulative
        acknowledgment point, then the endpoint MUST enter "deferred
        reset processing". ...  until the cumulative
        acknowledgment point reaches the Sender's Last Assigned TSN.

The cumulative acknowledgement point can not only be reached by
receiving DATA chunks, but also by receiving a FORWARD-TSN that
instructs the receiver to skip them. This was only done for DATA and not
for FORWARD-TSN, which is now corrected.

Additionally, an unnecessary implicit sending of SACK after having
received FORWARD-TSN was removed as this is done anyway every time a
packet has been received. This unifies the processing of DATA and
FORWARD-TSN more.

Bug: webrtc:14600
Change-Id: If797d3c46e741074fe05e322d0aebec765a87968
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321400
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40811}
 2023-09-26 07:30:24 +00:00
chromium-webrtc-autoroll
259d95f1f5 Roll chromium_revision 3a03dc546a..ae93f006ea (1201238:1201360) 
Change log: 3a03dc546a..ae93f006ea
Full diff: 3a03dc546a..ae93f006ea

Changed dependencies
* src/base: a511759c88..7d979505e8
* src/ios: e29e22c8e4..45c7179359
* src/testing: b9149c3227..51cfed6400
* src/third_party: b5ef97be2f..02772896c1
* src/third_party/androidx: DqV7MfoS-OdweHanUQqLvihUZG2azL412tGbq3_z7K8C..a9CGOell056bhQij2JhATC4nOCgZpeDXqqwWjr1_ewAC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3c4b5cf37f..7c462e0d55
* src/third_party/depot_tools: f936d540e1..0827dd28f1
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/5f8db64abc..82018abee6
* src/third_party/perfetto: 43ee4b90e3..c478eb8ffb
* src/tools: 258e67d2a8..da07715f84
* src/tools/luci-go: git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1..git_revision:3e49653ac027a003d9ef6cf89068acbf28f5bd9e
* src/tools/luci-go: git_revision:8b73cff3b780a7136c4904103f19124d2be3dee1..git_revision:3e49653ac027a003d9ef6cf89068acbf28f5bd9e
DEPS diff: 3a03dc546a..ae93f006ea/DEPS

No update to Clang.

BUG=None

Change-Id: Ibffde12794cb46062281b131558f5db090823635
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321544
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40810}
 2023-09-26 07:10:50 +00:00
Philipp Hancke
bfc2a3553d Remove more codec-related templating 
BUG=webrtc:15214

Change-Id: I719de4ef2b9c98a01b14f8f292098f19baa0d925
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321341
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40809}
 2023-09-26 06:55:24 +00:00
webrtc-version-updater
7829daf245 Update WebRTC code version (2023-09-26T04:02:19). 
Bug: None
Change-Id: Idfcc4d95fba64ffc75630315bebef51b3fcc7065
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321542
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40808}
 2023-09-26 06:51:20 +00:00
Ying Wang
78c119cbb3 Remove check on last_packet_received_time_ as it's no longer used. 
Bug: webrtc:15377
Change-Id: Ia8181ae5d546e6d6c0e97ef1daf5ab90d1b6a0aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321440
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40807}
 2023-09-26 03:21:34 +00:00
chromium-webrtc-autoroll
9b5d795b01 Roll chromium_revision eb86ccf4cd..3a03dc546a (1201083:1201238) 
Change log: eb86ccf4cd..3a03dc546a
Full diff: eb86ccf4cd..3a03dc546a

Changed dependencies
* src/base: e6be4127dd..a511759c88
* src/build: 07dfe8f568..2dca8e553d
* src/ios: f43276a583..e29e22c8e4
* src/testing: e530d9546a..b9149c3227
* src/third_party: d561ea5ac3..b5ef97be2f
* src/third_party/androidx: hruMK_i8vh9qvHxGsCV7FqycDsk4ggbDeQ89PJ7leTkC..DqV7MfoS-OdweHanUQqLvihUZG2azL412tGbq3_z7K8C
* src/third_party/depot_tools: c5505889cf..f936d540e1
* src/tools: 0629897abc..258e67d2a8
DEPS diff: eb86ccf4cd..3a03dc546a/DEPS

No update to Clang.

BUG=None

Change-Id: I96f94fd134608717e22b93a1aea4637830c4483e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321541
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40806}
 2023-09-26 01:09:11 +00:00
chromium-webrtc-autoroll
0ca4d621f2 Roll chromium_revision ae69785833..eb86ccf4cd (1200919:1201083) 
Change log: ae69785833..eb86ccf4cd
Full diff: ae69785833..eb86ccf4cd

Changed dependencies
* src/build: 8a1136d82d..07dfe8f568
* src/buildtools: b1681a8c6c..d21375885b
* src/ios: 6a1d0bb6a0..f43276a583
* src/testing: 83f665948d..e530d9546a
* src/third_party: ee9272bd24..d561ea5ac3
* src/third_party/libc++/src: 645470002f..26cbb86c20
* src/third_party/libunwind/src: 1f88fff745..f2ca661b1d
* src/third_party/perfetto: d0a7b97ca3..43ee4b90e3
* src/third_party/turbine: NR31kJWll1NZz_scMvMPtPH_P3wOQ5aKBJ-n8XQ7QrYC..yCsGwOtj8SizFXXeS-xmdIaZ3PuyTsy8IJsp411p_uIC
* src/tools: 879a953b9d..0629897abc
DEPS diff: ae69785833..eb86ccf4cd/DEPS

No update to Clang.

BUG=None

Change-Id: I6b5f72b64e9e602ae8d04d8021ab330611ae9c1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321284
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40805}
 2023-09-25 19:13:31 +00:00
Victor Boivie
77df7ffd0b dcsctp: Cleanup use of matchers 
More general matches that can be reused, less specialized ones.

Bug: None
Change-Id: I12ea98caf4f566168566173a509c204bd25e5a13
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321123
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40804}
 2023-09-25 17:39:28 +00:00
Emil Lundmark
7892f05411 Configure Pylint to follow PEP-8 
This is a follow-up on [1] to make presubmit succeed on PEP-8 compliant
code.

[1] https://webrtc-review.googlesource.com/c/src/+/321122

Bug: None
Change-Id: Ie4261cf6c15f22c152a7d5793d7b1f7a71109f33
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321081
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40803}
 2023-09-25 15:56:09 +00:00
Philipp Hancke
7d1aff6eed Unify RTP payload type validity checking 
making the UsedId generator the source of truth.
BUG=webrtc:12197

Change-Id: I4318a1366f8b2e20ea5ae264232437a9006c5103
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321120
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40802}
 2023-09-25 14:54:22 +00:00
Tommi
6bf2d31e71 Change PortInterface::Type to string_view and make type_ member const 
Bug: none
Change-Id: Id1b0298eede5d2ae5010cc450d7bcb9eadd7b874
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318080
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40801}
 2023-09-25 13:48:50 +00:00
chromium-webrtc-autoroll
070d386cfc Roll chromium_revision 286dbc6af0..ae69785833 (1200141:1200919) 
Change log: 286dbc6af0..ae69785833
Full diff: 286dbc6af0..ae69785833

Changed dependencies
* src/base: 0f1d959599..e6be4127dd
* src/build: 9b3f9169a1..8a1136d82d
* src/buildtools: d53d0131e2..b1681a8c6c
* src/ios: 96f3496e68..6a1d0bb6a0
* src/testing: f5159f7d11..83f665948d
* src/third_party: d0eae4649d..ee9272bd24
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/99f2d536fb..3c4b5cf37f
* src/third_party/depot_tools: af369d8962..c5505889cf
* src/third_party/freetype/src: c4073d8251..49781ab72b
* src/third_party/libc++/src: a75061bc37..645470002f
* src/third_party/libc++abi/src: cb9bef1717..c28dc42f0d
* src/third_party/libunwind/src: 4027f4521c..1f88fff745
* src/third_party/perfetto: 6bbbba9c6a..d0a7b97ca3
* src/third_party/r8: qLYuLt4k9raGYbeiaAh3ORseYrHh8pt9WUaeD60Yov4C..w5NK9teKNDuEhU_7rQE8WYwuBzdXA8lVkJwo6VOgWv8C
* src/tools: 498d9223ab..879a953b9d
DEPS diff: 286dbc6af0..ae69785833/DEPS

No update to Clang.

BUG=None

Change-Id: I9b20bd0c332cf3a60d4b5a2db2537a035883b405
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321381
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40800}
 2023-09-25 13:38:39 +00:00
Diep Bui
29d4a013bc Reland: use loss based bwe v2 in the start phase. 
Original CL: https://webrtc-review.googlesource.com/c/src/+/320840

Bug: webrtc:12707
Change-Id: Iff3a0c76c26aeb7cb0ac24c1f7aab3529c4a1659
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321420
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40799}
 2023-09-25 13:26:34 +00:00
Artem Titov
ba97eec127 Add string_view overload for Wrap method 
FileWrapper API is WebRTC private, so exposing absl::string_view overload for thrid-party users.

Bug: b/301228802
Change-Id: Id81775c8078e61eafe9bee53a4cba6ac476b11d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321460
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40798}
 2023-09-25 10:55:05 +00:00
Björn Terelius
b4d4bbcebd Revert "Clean up last_packet_received_time_ as it's no longer used." 
This reverts commit 2f4bc64166.

Reason for revert: Breaks downstream test

Original change's description:
> Clean up last_packet_received_time_ as it's no longer used.
>
> Bug: webrtc:15377
> Change-Id: I5453b9fd572a04dbea3241a2eb1c8ad8bb8b1186
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320560
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Commit-Queue: Ying Wang <yinwa@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40792}

Bug: webrtc:15377
Change-Id: Ifa57671cc479cdd86f543c4edc236221beb76f90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321340
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Ying Wang <yinwa@webrtc.org>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40797}
 2023-09-25 08:49:53 +00:00
Danil Chapovalov
9c58483b5a Rename EncodedImage property Timetamp to RtpTimestamp 
To avoid name collision with Timestamp type,
To avoid confusion with capture time represented as Timestamp

Bug: webrtc:9378
Change-Id: I8438a9cf4316e5f81d98c2af9dc9454c21c78e70
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320601
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40796}
 2023-09-24 20:06:48 +00:00
Johannes Kron
bbf27e0081 Remove NSApplicationActivateIgnoringOtherApps 
NSApplicationActivateIgnoringOtherApps is about to be deprecated.
The default behavior is good enough.

Tested on Chrome using https://wicg.github.io/conditional-focus/demo/

Bug: webrtc:15511
Change-Id: I1f59aea3d4e7c4942d17ee5c4f1b6c2d398016ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321080
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Auto-Submit: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40795}
 2023-09-24 13:55:12 +00:00
Victor Boivie
850296b7a4 Reapply "dcsctp: Negotiate zero checksum" 
The handover state has been added with
commit daaa6ab5a8.

This reverts commit 014cbed9d2.

Bug: webrtc:14997
Change-Id: Ie84f3184f3ea67aaa6438481634046ba18b497a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320941
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40794}
 2023-09-23 21:33:52 +00:00
webrtc-version-updater
63c50f59a6 Update WebRTC code version (2023-09-23T04:12:34). 
Bug: None
Change-Id: I2b5a8ed1987e47ada4bb6da70a75376fd2ad2243
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321108
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40793}
 2023-09-23 05:53:50 +00:00
Ying Wang
2f4bc64166 Clean up last_packet_received_time_ as it's no longer used. 
Bug: webrtc:15377
Change-Id: I5453b9fd572a04dbea3241a2eb1c8ad8bb8b1186
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320560
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40792}
 2023-09-23 00:03:11 +00:00
chromium-webrtc-autoroll
d2f4cf9fd1 Roll chromium_revision c066d24408..286dbc6af0 (1200027:1200141) 
Change log: c066d24408..286dbc6af0
Full diff: c066d24408..286dbc6af0

Changed dependencies
* src/base: 8df65eb6a0..0f1d959599
* src/build: 3a0a70c754..9b3f9169a1
* src/buildtools: e7cf6549b4..d53d0131e2
* src/ios: 9b82c02274..96f3496e68
* src/testing: 7bc5b55fb5..f5159f7d11
* src/third_party: 04ba03d92d..d0eae4649d
* src/third_party/depot_tools: 67e56f6382..af369d8962
* src/third_party/perfetto: ff0bba2e85..6bbbba9c6a
* src/tools: 4e24d4cf36..498d9223ab
DEPS diff: c066d24408..286dbc6af0/DEPS

No update to Clang.

BUG=None

Change-Id: Ib4485c5f9f670bdc2e47dcda599665de6f99af23
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321104
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40791}
 2023-09-23 00:02:08 +00:00
Diep Bui
4aa2b40ffe Revert "Use loss based bwe v2 in the start phase." 
This reverts commit b6c7ddd6a1.

Reason for revert: broken unit test

Original change's description:
> Use loss based bwe v2 in the start phase.
>
> TESTED=manual before:screen/ANtkMApoYczA2V5; after:screen/9kBoSvYKzKZR4sK
>
> Bug: webrtc:12707
> Change-Id: Ic156e363625c4b7476011059f3cd95641972091c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320840
> Commit-Queue: Diep Bui <diepbp@webrtc.org>
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40789}

Bug: webrtc:12707
Change-Id: Ibde45436934707b8e0084aa496dc249bc1c78ab2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321180
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40790}
 2023-09-22 22:51:53 +00:00
Diep Bui
b6c7ddd6a1 Use loss based bwe v2 in the start phase. 
TESTED=manual before:screen/ANtkMApoYczA2V5; after:screen/9kBoSvYKzKZR4sK

Bug: webrtc:12707
Change-Id: Ic156e363625c4b7476011059f3cd95641972091c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320840
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40789}
 2023-09-22 10:53:34 +00:00
Björn Terelius
b6ea0b2d2a Direcly call configure_reclient_cfgs.py instead of indirectly via fetch_reclient_cfgs.py 
Bug: None
Change-Id: I1ba2c4946b30b6cbe09dcd920a9041e54bbb2ec4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321000
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40788}
 2023-09-22 10:34:17 +00:00
Diep Bui
1db39801d3 Remove upper_link_capacity from loss_based_bwe_v2. 
Bug: webrtc:12707
Change-Id: I7909c4ef47239978eb26ad5b9644595e4a415a81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321121
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40787}
 2023-09-22 10:33:14 +00:00
Emil Lundmark
70eec6d760 Configure YAPF to follow PEP-8 altogether 
The Chromium Python style has recently changed to not deviate from
PEP-8 [1].

[1] https://chromium.googlesource.com/chromium/src/+/main/styleguide/python/python.md#our-previous-python-style

Bug: None
Change-Id: I0503ca6e74beed3a0a74397611abc7096da652b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321122
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40786}
 2023-09-22 10:32:11 +00:00
webrtc-version-updater
4b39e8627f Update WebRTC code version (2023-09-22T04:11:01). 
Bug: None
Change-Id: I3df506223d069352187c46773dcd5a2c116e25c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321100
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40785}
 2023-09-22 05:49:43 +00:00
chromium-webrtc-autoroll
8500974a6f Roll chromium_revision 4b9a788892..c066d24408 (1199866:1200027) 
Change log: 4b9a788892..c066d24408
Full diff: 4b9a788892..c066d24408

Changed dependencies
* src/base: 40a12b7ad8..8df65eb6a0
* src/build: 0e892cb251..3a0a70c754
* src/buildtools: fb8823aeb4..e7cf6549b4
* src/ios: d4a69a122a..9b82c02274
* src/testing: 3565f2cc58..7bc5b55fb5
* src/third_party: 8d95ce4197..04ba03d92d
* src/third_party/android_build_tools/manifest_merger: FlwnxEZ1wdjoQfedkF4MiZgo8pD48-_CJNA7RnU6as4C..EPmMtC5CNXQqxByKOxqF9Vk8LURwarA6qy5siWX1kRoC
* src/third_party/depot_tools: a45d2d4c90..67e56f6382
* src/third_party/libc++/src: 316166f499..a75061bc37
* src/third_party/libc++abi/src: 82c3c02548..cb9bef1717
* src/third_party/perfetto: 49ef5c5916..ff0bba2e85
* src/tools: 95263a071a..4e24d4cf36
DEPS diff: 4b9a788892..c066d24408/DEPS

No update to Clang.

BUG=None

Change-Id: Idda09161c70945aa6f9fe5266f8c4ed29c25142c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321062
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40784}
 2023-09-22 05:14:41 +00:00
chromium-webrtc-autoroll
047eeb418f Roll chromium_revision f473cfebae..4b9a788892 (1199635:1199866) 
Change log: f473cfebae..4b9a788892
Full diff: f473cfebae..4b9a788892

Changed dependencies
* src/base: 71c79f2cfe..40a12b7ad8
* src/build: 5bcede7b07..0e892cb251
* src/ios: f912c68abd..d4a69a122a
* src/testing: e0365d5d5b..3565f2cc58
* src/third_party: 9640fcb9f5..8d95ce4197
* src/third_party/perfetto: 90f8e7ccdd..49ef5c5916
* src/tools: 75014e173e..95263a071a
DEPS diff: f473cfebae..4b9a788892/DEPS

No update to Clang.

BUG=None

Change-Id: Ib38c1665c612c54ffce442f99041f367f7b38480
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321061
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40783}
 2023-09-21 23:17:12 +00:00
chromium-webrtc-autoroll
e3e030e54e Roll chromium_revision 54d127d7c9..f473cfebae (1199499:1199635) 
Change log: 54d127d7c9..f473cfebae
Full diff: 54d127d7c9..f473cfebae

Changed dependencies
* src/base: a2c77cd652..71c79f2cfe
* src/build: 480a7a59d8..5bcede7b07
* src/ios: 48daa52263..f912c68abd
* src/testing: 625ab1c17d..e0365d5d5b
* src/third_party: 5a5f4975a8..9640fcb9f5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/43f4530c97..99f2d536fb
* src/third_party/libunwind/src: 244575ffb6..4027f4521c
* src/tools: b476dcface..75014e173e
DEPS diff: 54d127d7c9..f473cfebae/DEPS

No update to Clang.

BUG=None

Change-Id: I0c22b2efd0faf148b11492b8a06b33ebd2858883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321042
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40782}
 2023-09-21 16:43:35 +00:00
chromium-webrtc-autoroll
e887cbefa3 Roll chromium_revision b3921f4990..54d127d7c9 (1198700:1199499) 
Change log: b3921f4990..54d127d7c9
Full diff: b3921f4990..54d127d7c9

Changed dependencies
* fuchsia_version: version:15.20230909.2.1..version:15.20230920.1.1
* src/base: fa650044e2..a2c77cd652
* src/build: 9557d1f6c4..480a7a59d8
* src/buildtools: fc0b88d4a0..fb8823aeb4
* src/ios: 3923802f2a..48daa52263
* src/testing: d7c3af8bd0..625ab1c17d
* src/third_party: bd281380f3..5a5f4975a8
* src/third_party/android_toolchain/ndk: 3vHltFqfgIw8wZ38ggGM9c7Eyw_AHZnwCgFIVtc9gngC..NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC
* src/third_party/androidx: tp63GXhagjuqaueX7s18Dpuf8fE1dvEDPtr1mfnlR1IC..hruMK_i8vh9qvHxGsCV7FqycDsk4ggbDeQ89PJ7leTkC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/3aecf1d00b..a1843d660b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c9ccea1a72..43f4530c97
* src/third_party/depot_tools: 50b27a5308..a45d2d4c90
* src/third_party/freetype/src: babe6af167..c4073d8251
* src/third_party/kotlin_stdlib: 7XCiIAlSi36gvPwOn8N4Q1GE9sMLw6V1RljM9151cWIC..as5vlzFVMpLTCQXVJqs-kifMAEQmjK_fImDy09zQB8AC
* src/third_party/libc++/src: 3e8a3b3c5d..316166f499
* src/third_party/libc++abi/src: f6a17c88dd..82c3c02548
* src/third_party/perfetto: 15336a4d7f..90f8e7ccdd
* src/third_party/r8: f6AwZX-cIa-qdx2fK93cJy9cfTg9ZqO2PkBWDNUMZXQC..qLYuLt4k9raGYbeiaAh3ORseYrHh8pt9WUaeD60Yov4C
* src/third_party/turbine: laSnfZnTgkmZynERrjAlU3yeqB5rN446BctGmKQsZ64C..NR31kJWll1NZz_scMvMPtPH_P3wOQ5aKBJ-n8XQ7QrYC
* src/tools: 46859d25b3..b476dcface
DEPS diff: b3921f4990..54d127d7c9/DEPS

No update to Clang.

BUG=None

Change-Id: I338c406444f3662015b74bb304543c7c36af9644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320881
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40781}
 2023-09-21 10:41:53 +00:00
Diep Bui
7ee64bd9dc Remove the upper link capacity usage in the loss based bwe. 
A follow up cl/ is to remove passing upper link capacity from goog_cc to loss_based_bwe_v2.

Bug: webrtc:12707
Change-Id: I45af8ca6e8ba185700d0b7eb57004d2b61edeb9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320780
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40780}
 2023-09-21 07:43:49 +00:00
Alfred E. Heggestad
c951d1b0f6 audio: fix some typos 
Bug: None
Change-Id: I255a23a893d008dc58c3c9cb3facf61419c88c72
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320620
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40779}
 2023-09-21 05:42:29 +00:00
Greg Thompson
6fc4d9750c Make WEBRTC_UNSAFE_FUZZER_MODE dependent only on use_fuzzing_engine 
The level of optimization is irrelevant -- only whether the build is
targeting a fuzzer or not.

Bug: chromium:1483560, chromium:847106, chromium:844647, chromium:646404
Change-Id: I8784883ed222b08b4d4313782175a9550e3e3ea5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320800
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40778}
 2023-09-20 16:04:17 +00:00
Avi Drissman
46da472f82 Revert "mac: Work around an inccorect availability annotation in the 13.3 SDK" 
This reverts commit 0f87b38535.

This is not needed with the macOS 14 SDK, which has the fix, and which
was landed in https://crrev.com/c/4875713.

Bug: chromium:1484363, chromium:1431897
Change-Id: I1e019ce71b90333d5d1333a3cf8bb510a3dbd212
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320820
Reviewed-by: Tomas Gunnarsson <tommi@google.com>
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40777}
 2023-09-20 12:50:43 +00:00
Philipp Hancke
5551776035 Reject attempts to change the media kind for a m-line with a previously used mid 
which can happen if the remote end reuses a mid.

BUG=webrtc:15471

Change-Id: I38da7dced712400002bc61d616e481a1255aa896
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319460
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40776}
 2023-09-20 12:21:24 +00:00
Emil Lundmark
ec8262788b Look through all candidates before falling back to default packetization 
It's possible that a peer can signal the same payload with multiple
packetization options. As such, we shouldn't try to fall back to default
packetization until we have considered all the alternatives.

Bug: webrtc:15473
Change-Id: I21772b4d8c53819d1c3105988551ebdbea0df045
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320241
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Auto-Submit: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Sergey Sukhanov <sergeysu@webrtc.org>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40775}
 2023-09-20 12:18:02 +00:00
Philipp Hancke
f14dfed72a Move codecs() to MediaContentDescription 
allowing for a lot of de-templating

BUG=webrtc:15214

Change-Id: Ibe1a5f5d704564566f24c496822a4308ba23c4dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/319160
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40774}
 2023-09-20 10:16:36 +00:00
qwu16
ae82df718c Add codec name H265 to support H265 in WebRTC 
Bug: webrtc:13485
Change-Id: I352b15a65867f0d56fc8e9a9e03081bd3258108e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316283
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40773}
 2023-09-20 09:25:32 +00:00
webrtc-version-updater
9596002743 Update WebRTC code version (2023-09-20T04:02:40). 
Bug: None
Change-Id: I38c63765f6a4e19811914107dd40ad470d7bcfe2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/320769
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40772}
 2023-09-20 05:42:19 +00:00