Jeremy Leconte
3d476f2738
Allow to keep old python style for existing files.
...
https://webrtc-review.googlesource.com/c/src/+/321081 made PEP-8 mandatory for WebRTC python file.
This CL allows to keep the old formatting style for existing python files because switching all methods and functions name from PascalCase to snake_case is non trivial.
Change-Id: Id094bbf72ee1c3c32027a49bc9763bc65dfb9ad2
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323860
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#40951}
2023-10-17 13:52:56 +00:00
Danil Chapovalov
c2994790a1
Throttle 'Very high pacing rate' log message
...
By producing new message only when new max is 10% larger than the previous max.
Bug: b/305042040
Change-Id: Id85784939f944de8115b881471b02214c34b3043
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323841
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40950}
2023-10-17 13:01:18 +00:00
Per K
7c612c3074
Default dont probe when BWE estimators detects a limit
...
Cleanup field trials for not probing when BWE limited due to high RTT,
loss.
Bug: webrtc:14754, webrtc:12707
Change-Id: Ib664784e321d9284d842ea42a0dd1d8361000f20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323640
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40949}
2023-10-17 11:48:32 +00:00
Per Kjellander
89fab060e7
Reland "Remove Probe and Trendline integration from LossbasedBwe"
...
This reverts commit be511490b7
.
Reason for revert: Test reland to investigate if this was actually causing AudioMixer tests to fail
Original change's description:
> Revert "Remove Probe and Trendline integration from LossbasedBwe"
>
> This reverts commit 9b3eea8b7c
.
>
> Reason for revert: might cause upstream breakages
>
> Original change's description:
> > Remove Probe and Trendline integration from LossbasedBwe
> >
> > These features are not in use.
> >
> > Bug: webrtc:12707
> > Change-Id: Ibe9fcae5e3fd7cb7ca289af80dad8480288c9ba3
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323601
> > Commit-Queue: Per Kjellander <perkj@webrtc.org>
> > Reviewed-by: Diep Bui <diepbp@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#40938}
>
> Bug: webrtc:12707
> Change-Id: I040b25ea8b4e4bf4cbc7cc91c1cd19d6fcfb5ebb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323680
> Owners-Override: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#40945}
Bug: webrtc:12707
Change-Id: I4f47c141eafc85a519f12f6504cf5b444f9aa6ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323760
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40948}
2023-10-17 10:45:35 +00:00
Rasmus Brandt
c868fd3b3e
Add missing comma in VideoReceiveStreamInterface::Stats::ToString
...
Bug: None
Change-Id: I665fd120bdfe3e93e51f11f9035e30d09381db75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323800
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40947}
2023-10-17 10:42:06 +00:00
Fredrik Hernqvist
5574afc095
Fix AudioMixer histogram test
...
If the tests are run in a different order, the test might fail.
We fix this by resetting the histogram data at the start of the test.
Change-Id: I6fb349609842b55f416cf2ec8cd93d0b4328960e
Bug: chromium:1430806
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323801
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Auto-Submit: Fredrik Hernqvist <fhernqvist@google.com>
Cr-Commit-Position: refs/heads/main@{#40946}
2023-10-17 10:13:54 +00:00
Jeremy Leconte
be511490b7
Revert "Remove Probe and Trendline integration from LossbasedBwe"
...
This reverts commit 9b3eea8b7c
.
Reason for revert: might cause upstream breakages
Original change's description:
> Remove Probe and Trendline integration from LossbasedBwe
>
> These features are not in use.
>
> Bug: webrtc:12707
> Change-Id: Ibe9fcae5e3fd7cb7ca289af80dad8480288c9ba3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323601
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Reviewed-by: Diep Bui <diepbp@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40938}
Bug: webrtc:12707
Change-Id: I040b25ea8b4e4bf4cbc7cc91c1cd19d6fcfb5ebb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323680
Owners-Override: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40945}
2023-10-17 07:20:43 +00:00
Harald Alvestrand
aa653c0d76
Reland "Deprecate all classes related to AsyncResolver"
...
This reverts commit 08d431ec34
.
Reason for revert: Last (hopefully) Chrome blocker removed
Original change's description:
> Revert "Deprecate all classes related to AsyncResolver"
>
> This reverts commit 61a442809c
.
>
> Reason for revert: Breaks roll into Chromium
>
> Original change's description:
> > Deprecate all classes related to AsyncResolver
> >
> > and remove internal usage.
> >
> > Bug: webrtc:12598
> > Change-Id: Ie208682bfa0163f6c7a8e805151cfbda76324496
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322860
> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> > Auto-Submit: Harald Alvestrand <hta@webrtc.org>
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#40919}
>
> Bug: webrtc:12598
> Change-Id: I8aef5e062e19a51baec75873eddfca2a10467d3c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322901
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40927}
Bug: webrtc:12598
Change-Id: I3c7b07c831eb9ff808368433d9b9ae8ec4b2afb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323720
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40944}
2023-10-17 07:08:57 +00:00
Mirko Bonadei
573bb8552a
Revert "Set optimize_for_size for iOS perf tests."
...
This reverts commit f83da9dddd
.
Reason for revert: Culprit has been found.
Original change's description:
> Set optimize_for_size for iOS perf tests.
>
> No-Try: True
> Bug: webrtc:15524
> Change-Id: I525f014f5c321000d520ef68a682f8ca1395bebd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323002
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40915}
Bug: webrtc:15524
Change-Id: I6785bf448f62d39a9eafe04bce6c778ba638c9ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323660
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40943}
2023-10-16 18:35:58 +00:00
Björn Terelius
5502de6ee9
Fix missing include.
...
Bug: webrtc:15556
Change-Id: I18d0010333c4e5bb2ee9bb07a4320101e87cc0b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323641
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40942}
2023-10-16 16:14:52 +00:00
Jeremy Leconte
49dcb200ab
Export FieldTrialBasedConfig in order to use it in Chromium.
...
Goal is to initialize peerconnections in Chromium using this based
field trial config until a proper config that doesn't rely on the
global field trial string can be used (https://crrev.com/c/4936314 ).
Change-Id: I3d006e2445ccc4880b73b564c8ad4408242d3696
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323621
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40941}
2023-10-16 16:13:48 +00:00
Jeremy Leconte
23bee61dc7
Remove unused variables in ip_address_unittest.
...
Change-Id: I99bb6b5b8ea3ad813d31ca4995e38125fd1e93b1
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323620
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40940}
2023-10-16 14:04:28 +00:00
Florent Castelli
1adea9806d
Return error when requested codec is preferred but not negotiated
...
Because of our asymmetrical codec situation, it's possible to have
send only codecs that we cannot negotiate even with ourselves.
This means that we should not have a DCHECK, but just a plain error.
Bug: webrtc:15064
Change-Id: I0c170e5c7f356197bcb04bcecb8259c344423ccb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323183
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40939}
2023-10-16 13:59:13 +00:00
Per K
9b3eea8b7c
Remove Probe and Trendline integration from LossbasedBwe
...
These features are not in use.
Bug: webrtc:12707
Change-Id: Ibe9fcae5e3fd7cb7ca289af80dad8480288c9ba3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323601
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40938}
2023-10-16 13:11:20 +00:00
Diep Bui
9f9b8e0b88
Default enable NotUseAckedBitrateInAlr in loss basd bwe.
...
Its finch/chrome experiment got approved in May.
Bug: webrtc:12707
Change-Id: I843dece38f32e844285b71575f6a04b63865f1b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323600
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40937}
2023-10-16 11:25:06 +00:00
Dor Hen
6113e199ff
Replace RTC_DCHECK with EXPECT_TRUE in time estimator UT code
...
Replacing RTC_DCHECK code with EXPECT_TRUE in the remote ntp time estimator unittest code.
This to prevent test failures when building and testing in non-debug mode.
Bug: webrtc:15572
Change-Id: I372fcd6ee29a4ddc07d6b27ddd492dcea13d399f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323181
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40936}
2023-10-16 09:42:19 +00:00
Jeremy Leconte
137c3bfacb
Remove unused variable kIPv4MappedRFC1918AddrString.
...
https://ci.chromium.org/ui/p/webrtc/builders/try/android_compile_arm_rel/51821/overview
Change-Id: Id7650d95d3576d2fbc9b89b717d91fd3ab5c005c
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323462
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40935}
2023-10-16 09:34:41 +00:00
Danil Chapovalov
a3ce407023
Cleanup Call construction
...
Return unique_ptr to clearly communicate ownership is transfered.
Remove Call::Config alias
Bug: None
Change-Id: Ie3aa1da383ad65fae490d218fced443d44961eab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323160
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40934}
2023-10-16 06:34:26 +00:00
webrtc-version-updater
9254df0f11
Update WebRTC code version (2023-10-16T04:06:36).
...
Bug: None
Change-Id: Iccba8f56e83962becbaebd178aabbb6501da9efd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323423
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40933}
2023-10-16 05:19:37 +00:00
webrtc-version-updater
9fdde5b3d2
Update WebRTC code version (2023-10-15T04:07:38).
...
Bug: None
Change-Id: I19e228287bcc3e5ec00aa09415701901e4e28c54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323420
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40932}
2023-10-15 05:37:41 +00:00
henrika
5f78ed6eaf
Minor change in comment for use of an IGraphicsCaptureSession3 API
...
Makes it more clear that a certain API is only supported in Windows 11.
Bug: webrtc:15451
Change-Id: Ic3abfb2cbf0e30f9cb722ac843876f41279bf200
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323161
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40931}
2023-10-14 15:20:11 +00:00
webrtc-version-updater
d80d993247
Update WebRTC code version (2023-10-14T04:02:57).
...
Bug: None
Change-Id: I58a749120736a09776c87ed27e66cd6ae3368f54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323056
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40930}
2023-10-14 05:39:34 +00:00
Jeremy Leconte
31cb99fcf4
Upgrade ios bot builder xcode version.
...
Change-Id: I098f978a6d839d7d50d004b93e1df3eada6fd010
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323180
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40929}
2023-10-13 13:54:06 +00:00
Philipp Hancke
635061b65e
Add test for m-line recycling
...
which adds test coverage for the offer path.
Removes a DCHECK which is no longer required as the error
is handled in the individual handlers.
BUG=webrtc:15471
Change-Id: I982d517a313cd84574c57974e9d8390a6b78012c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321840
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40928}
2023-10-13 11:37:22 +00:00
Harald Alvestrand
08d431ec34
Revert "Deprecate all classes related to AsyncResolver"
...
This reverts commit 61a442809c
.
Reason for revert: Breaks roll into Chromium
Original change's description:
> Deprecate all classes related to AsyncResolver
>
> and remove internal usage.
>
> Bug: webrtc:12598
> Change-Id: Ie208682bfa0163f6c7a8e805151cfbda76324496
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322860
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Auto-Submit: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40919}
Bug: webrtc:12598
Change-Id: I8aef5e062e19a51baec75873eddfca2a10467d3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322901
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40927}
2023-10-13 11:20:51 +00:00
Danil Chapovalov
c9880805ed
Delete deprecated Timestamp accessor and setter in EncodedImage
...
Bug: webrtc:9378
Change-Id: I5c67cca733f2fd646e73694524abf6b33438e8a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321860
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40926}
2023-10-13 10:22:28 +00:00
Diep Bui
636c3f24b8
Add outgoing TWCC loss and missing packet feedback plots to event log analyzer.
...
Bug: webrtc:12707
Change-Id: I737177e6b6737c8c2e7d8803a68e29e9998ba9f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321140
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40925}
2023-10-13 09:54:00 +00:00
Sergey Sukhanov
ec48886da9
Fix pointer overflow in neon implemenation of audio filters
...
Use signed arithmetic for indexes that can be negative
Bug: webrtc:15523
Change-Id: I41ea47a679242c8febe70373529173733058c479
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322120
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40924}
2023-10-13 06:41:08 +00:00
webrtc-version-updater
637bd1c9bb
Update WebRTC code version (2023-10-13T04:07:14).
...
Bug: None
Change-Id: Ia16bde987f4ddefb6ff592b3774a54c93e9ead1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323101
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40923}
2023-10-13 05:48:02 +00:00
chromium-webrtc-autoroll
08d6197b9e
Roll chromium_revision 30be5dc6df..01dc2965ca (1208960:1209117)
...
Change log: 30be5dc6df..01dc2965ca
Full diff: 30be5dc6df..01dc2965ca
Changed dependencies
* src/base: 50c1375ce0..535e730300
* src/build: 6b8862e73f..b0d25e8dad
* src/ios: 1b4a1ab136..22678d3aca
* src/testing: 3618be3ee5..77870d2f05
* src/third_party: b0e671bdcf..16e0426d42
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/897e3d48d8..171b75b883
* src/third_party/depot_tools: 0b943400a4..a51863b2f8
* src/third_party/libunwind/src: 9ebf30f2a4..7b1593d5ca
* src/tools: 5a4eedaab2..c3738e7bc8
DEPS diff: 30be5dc6df..01dc2965ca
/DEPS
No update to Clang.
BUG=None
Change-Id: I581f86451fa98166965821b9d633c227cb17dc8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323049
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40922}
2023-10-12 22:55:29 +00:00
chromium-webrtc-autoroll
e6c4507d0a
Roll chromium_revision 05f3934693..30be5dc6df (1208764:1208960)
...
Change log: 05f3934693..30be5dc6df
Full diff: 05f3934693..30be5dc6df
Changed dependencies
* src/base: 3841cd2118..50c1375ce0
* src/build: 1de43c2610..6b8862e73f
* src/ios: 274966acfb..1b4a1ab136
* src/testing: 25d5ed3d10..3618be3ee5
* src/third_party: c8b96fdfa6..b0e671bdcf
* src/third_party/androidx: rmHTIvq0ZcpO2SLGZ62OzCmZLi_-iLI0USquMgUITeoC..3L7I6q8o1bbOW7cqtQniR8B2nq4B-HrOOaoN7dh5dvYC
* src/third_party/perfetto: 747df2371b..58e677929f
* src/third_party/r8: tr-hYTpA4Gomi1_TTF1Hvbc0Rwy8guQ4OMLc90Gw0uQC..VYa4qKw_r1a1mfMoihb-HEf076o6wCzkBmi4mPjKrkQC
* src/tools: 4ad32b9ce9..5a4eedaab2
DEPS diff: 05f3934693..30be5dc6df
/DEPS
No update to Clang.
BUG=None
Change-Id: Ide9b4bd155fa631b1e2a83f0cbc18999dd4e5f15
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323067
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40921}
2023-10-12 18:38:33 +00:00
Philipp Hancke
19fe2437b7
Remove more codec-related templating
...
BUG=webrtc:15214
Change-Id: Ia597f674e5650dad31796c9a13769fbe873554fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322122
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40920}
2023-10-12 15:36:42 +00:00
Harald Alvestrand
61a442809c
Deprecate all classes related to AsyncResolver
...
and remove internal usage.
Bug: webrtc:12598
Change-Id: Ie208682bfa0163f6c7a8e805151cfbda76324496
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322860
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40919}
2023-10-12 14:07:37 +00:00
chromium-webrtc-autoroll
dc8f81652b
Roll chromium_revision 12a1bdba49..05f3934693 (1208649:1208764)
...
Change log: 12a1bdba49..05f3934693
Full diff: 12a1bdba49..05f3934693
Changed dependencies
* src/base: 27ce87dd23..3841cd2118
* src/ios: a3b4f5efda..274966acfb
* src/testing: 569bfa6df5..25d5ed3d10
* src/third_party: 1ed2e049ff..c8b96fdfa6
* src/third_party/androidx: n-49vMsfeUdbL-4uiGFCKiXPdIOzcg6-aFmLL64c2foC..rmHTIvq0ZcpO2SLGZ62OzCmZLi_-iLI0USquMgUITeoC
* src/third_party/depot_tools: 69e597f8e5..0b943400a4
* src/third_party/perfetto: fdbd437367..747df2371b
* src/tools: d7757d197a..4ad32b9ce9
DEPS diff: 12a1bdba49..05f3934693
/DEPS
No update to Clang.
BUG=None
Change-Id: I6a35da83dac48c0a17f177c1ff8604befc5282d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323046
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40918}
2023-10-12 12:39:13 +00:00
Palak Agarwal
af74dff19e
Allow streams to be sent without |source_| being initially set
...
This makes it consistent with how things are done in webrtc_video_engine.cc
This will improve the JS code by not having to initialize an audio
track every time frames need to be sent over, especially from another
peer connection in case of encoded transforms.
Bug: chromium:1477192
Change-Id: I3f938ad812ff377599a3799d4c2d2cd85149189e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322702
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tony Herre <herre@google.com>
Commit-Queue: Palak Agarwal <agpalak@google.com>
Cr-Commit-Position: refs/heads/main@{#40917}
2023-10-12 10:08:26 +00:00
Jeremy Leconte
5f4efcf303
Update test_flags visibility.
...
Change-Id: Ic18fea850d77fce90316c4b7118331c459a15685
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323080
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40916}
2023-10-12 09:59:33 +00:00
Mirko Bonadei
f83da9dddd
Set optimize_for_size for iOS perf tests.
...
No-Try: True
Bug: webrtc:15524
Change-Id: I525f014f5c321000d520ef68a682f8ca1395bebd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323002
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40915}
2023-10-12 08:00:24 +00:00
chromium-webrtc-autoroll
973705e5be
Roll chromium_revision 98790ba2de..12a1bdba49 (1208444:1208649)
...
Change log: 98790ba2de..12a1bdba49
Full diff: 98790ba2de..12a1bdba49
Changed dependencies
* src/base: 8e17c67f0d..27ce87dd23
* src/build: bb7ea33697..1de43c2610
* src/ios: a82b42786d..a3b4f5efda
* src/testing: 39050aaaca..569bfa6df5
* src/third_party: 45f0407cbe..1ed2e049ff
* src/third_party/androidx: llw7NnkIwN-OjAy6_WPZG9irDybN6NJP7t9NNkHzV04C..n-49vMsfeUdbL-4uiGFCKiXPdIOzcg6-aFmLL64c2foC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/30e34f3dc1..897e3d48d8
* src/third_party/depot_tools: aabd869daf..69e597f8e5
* src/third_party/icu: 995db880cf..a622de35ac
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/0d59418942..11693fd86d
* src/third_party/libvpx/source/libvpx: 38a707faef..3fbd1dca6a
* src/tools: 1a84f2c801..d7757d197a
DEPS diff: 98790ba2de..12a1bdba49
/DEPS
No update to Clang.
BUG=None
Change-Id: I3b4a219f42cdd84f2b3032ae799c4301dc253268
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323044
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40914}
2023-10-12 05:21:17 +00:00
chromium-webrtc-autoroll
f286c902a6
Roll chromium_revision 52b4062c6d..98790ba2de (1208231:1208444)
...
Change log: 52b4062c6d..98790ba2de
Full diff: 52b4062c6d..98790ba2de
Changed dependencies
* src/base: f9cf79db91..8e17c67f0d
* src/build: 2dccc3874f..bb7ea33697
* src/buildtools/linux64: git_revision:991530ce394efb58fcd848195469022fa17ae126..git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53
* src/buildtools/mac: git_revision:991530ce394efb58fcd848195469022fa17ae126..git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53
* src/buildtools/win: git_revision:991530ce394efb58fcd848195469022fa17ae126..git_revision:182a6eb05d15cc76d2302f7928fdb4f645d52c53
* src/ios: be8c1b24bd..a82b42786d
* src/testing: 96049486fa..39050aaaca
* src/third_party: ea4ee25d4b..45f0407cbe
* src/third_party/android_build_tools/bundletool: 2RPwohwtc6on0_96oFxokeEvnC1LbLrGuyCAw00k62AC..xOeKyLIaK_RRHU0Qv0EdxTrRlq_22HAwoOr1xn5yoOcC
* src/third_party/androidx: DFIp2weQcjP-sciQ_WkYq9G7Y_YS0Eh_VIUHSgqEJgMC..llw7NnkIwN-OjAy6_WPZG9irDybN6NJP7t9NNkHzV04C
* src/third_party/kotlin_stdlib: as5vlzFVMpLTCQXVJqs-kifMAEQmjK_fImDy09zQB8AC..QwS-YZL_N4g1SjI1Ngely1WPNxLh-kfYpFZhKaEXGawC
* src/third_party/libunwind/src: 2ce7927479..9ebf30f2a4
* src/third_party/perfetto: ad2927387e..fdbd437367
* src/tools: a6b74f74b5..1a84f2c801
DEPS diff: 52b4062c6d..98790ba2de
/DEPS
No update to Clang.
BUG=None
Change-Id: I1af1984098c1cad697fc23826875a2950f0c63f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323041
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40913}
2023-10-11 20:54:53 +00:00
chromium-webrtc-autoroll
e30dd5c10c
Roll chromium_revision f9691c6faf..52b4062c6d (1208122:1208231)
...
Change log: f9691c6faf..52b4062c6d
Full diff: f9691c6faf..52b4062c6d
Changed dependencies
* src/base: f99a440717..f9cf79db91
* src/ios: 8268c9143f..be8c1b24bd
* src/testing: 3d87dab413..96049486fa
* src/third_party: d488884559..ea4ee25d4b
* src/third_party/androidx: fT5pz2yH4irycAN03PGWg7WhP9YI8WplHi8GsnRTL0IC..DFIp2weQcjP-sciQ_WkYq9G7Y_YS0Eh_VIUHSgqEJgMC
* src/third_party/perfetto: 8e5b8483f3..ad2927387e
* src/tools: aaf8d9da72..a6b74f74b5
DEPS diff: f9691c6faf..52b4062c6d
/DEPS
No update to Clang.
BUG=None
Change-Id: I65724174c3d7fe73142c0125981b512f129575a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323020
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40912}
2023-10-11 14:43:38 +00:00
Per K
0b554e7004
Upper limit pacer send bursts to about 63Kbyte
...
The purpose is to ensure send socket buffers are not overfilled at high
pacing rates.
Bug: chromium:1354491
Change-Id: Ic6f473080292f84a2a099b85fb5817f7e14e7355
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/323000
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40911}
2023-10-11 14:22:44 +00:00
Philipp Hancke
dde1cb6212
Add note about two-byte extension to VLA docs
...
since the extension can be too large to fit the 16 bytes available
to one-byte extensions
https://www.rfc-editor.org/rfc/rfc8285#section-4.2
when including the width and height fields.
Also document when those fields are sent.
BUG=webrtc:12000
Change-Id: If17f57d40c0bde9b060f223c548e407d6c124b82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321200
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40910}
2023-10-11 11:20:19 +00:00
Jeremy Leconte
1a8d5292c2
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 19/inf
...
Convert most field trials used in PCLF tests.
Change-Id: I26c0c4b1164bb0870aae1a488942cde888cb459d
Bug: webrtc:10335
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322703
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40909}
2023-10-11 11:09:35 +00:00
Danil Chapovalov
c941579e95
Move field trial check WebRTC-DisableRtxRateLimiter
...
Checking in sending classes avoids using global field trial string in favor of the injected one.
In addition to that RateLimiter looks wrong layer for check that field trial:
checking inside RateLimiter class might be surprising if it is used for limiting something else than RTX bitrate.
evaluating field trial for each retransmitting packet might be expensive
Bug: webrtc:15184, webrtc:10335
Change-Id: I87bae3522bbd9692629d4f9b6caa119be03f2bd6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322720
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40908}
2023-10-11 10:34:17 +00:00
Jonas Oreland
c4f3919fdd
Add RTC_DCHECK that port_ is always valid in Connection.
...
This patch is a follow up to https://webrtc-review.googlesource.com/c/src/+/260943
which made it possible to destroy a Port before a Connection (on that
port).
This patch "reverses" this, by adding RTC_DHECK, and fixes the Port
destructor to release the Connections before invalidating the WeakPtr<>.
Currently there are no known occurrences where a Connection is destroyed after it's Port is. But prior to the change in Port destructor, a bunch unit tests failed on the newly added DCHECKs.
In addition:
a) modify StunReqquestManager to remove entry from hash before calling callback. This makes it possible for callback to modify (clear) hash.
b) clear pending requests when disconnecting from port, "should not be needed", depends on a)
c) add a getter for pending_delete()
Bug: webrtc:13892, webrtc:13865
Change-Id: I5d18f2db8d93b7cc25d18bd620063589ee9257c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322861
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40907}
2023-10-11 10:16:15 +00:00
chromium-webrtc-autoroll
ddd6b69572
Roll chromium_revision 0e603da34a..f9691c6faf (1207996:1208122)
...
Change log: 0e603da34a..f9691c6faf
Full diff: 0e603da34a..f9691c6faf
Changed dependencies
* src/base: ad4178be5f..f99a440717
* src/build: 7f9fca9931..2dccc3874f
* src/buildtools: ab80d634ec..67cee5ecfd
* src/ios: 092658ad22..8268c9143f
* src/testing: 2c0323c714..3d87dab413
* src/third_party: 898664ec97..d488884559
* src/third_party/androidx: ubPprrWxHA0qqDaHt15loHyEFma5qJ5_nZ5SY4oHLewC..fT5pz2yH4irycAN03PGWg7WhP9YI8WplHi8GsnRTL0IC
* src/third_party/depot_tools: 4566632822..aabd869daf
* src/third_party/icu: 985b9a6f70..995db880cf
* src/tools: c828b4a078..aaf8d9da72
DEPS diff: 0e603da34a..f9691c6faf
/DEPS
No update to Clang.
BUG=None
Change-Id: I41cb5211be43f649ad616caa67a95299a52d72c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322981
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40906}
2023-10-11 09:07:50 +00:00
webrtc-version-updater
33419cadc3
Update WebRTC code version (2023-10-11T04:12:21).
...
Bug: None
Change-Id: I3c22f47d4b83d6f65da201d7c2d6660ae978abe8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322963
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40905}
2023-10-11 06:15:43 +00:00
chromium-webrtc-autoroll
cedabf3e2e
Roll chromium_revision 61241f96d3..0e603da34a (1207859:1207996)
...
Change log: 61241f96d3..0e603da34a
Full diff: 61241f96d3..0e603da34a
Changed dependencies
* src/base: 1d92c44f33..ad4178be5f
* src/build: a1230ba9e1..7f9fca9931
* src/ios: 8a03469b90..092658ad22
* src/testing: d390ec41bd..2c0323c714
* src/third_party: 55454ff69e..898664ec97
* src/third_party/r8: ZQH8yoO1Ol5rCFRL2hzp4_mcdq23Fk19Z_gVHn5pzk8C..tr-hYTpA4Gomi1_TTF1Hvbc0Rwy8guQ4OMLc90Gw0uQC
* src/tools: 027a0872ea..c828b4a078
DEPS diff: 61241f96d3..0e603da34a
/DEPS
No update to Clang.
BUG=None
Change-Id: Ic71cca508752ae1349a72934ff16874ff75493ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322960
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40904}
2023-10-11 00:46:24 +00:00
chromium-webrtc-autoroll
5afdc10c1e
Roll chromium_revision b38457816f..61241f96d3 (1207700:1207859)
...
Change log: b38457816f..61241f96d3
Full diff: b38457816f..61241f96d3
Changed dependencies
* src/base: 1cd98077e5..1d92c44f33
* src/build: 7019612497..a1230ba9e1
* src/buildtools: 657ac241f8..ab80d634ec
* src/ios: 71c4ff7e2e..8a03469b90
* src/testing: 604a153a42..d390ec41bd
* src/third_party: 8e52b48387..55454ff69e
* src/third_party/androidx: OaH5bHMp_S6FsqKAhEI9qI-0aMFnozdmCwqRK9b8ULgC..ubPprrWxHA0qqDaHt15loHyEFma5qJ5_nZ5SY4oHLewC
* src/third_party/depot_tools: 4d6298fabb..4566632822
* src/third_party/libc++/src: 8fc17971d6..e07dcc1eaa
* src/tools: ad4df51148..027a0872ea
DEPS diff: b38457816f..61241f96d3
/DEPS
No update to Clang.
BUG=None
Change-Id: If85840b6668dc2cf68555be16fbf501b0761ea74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322940
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40903}
2023-10-10 21:00:44 +00:00
chromium-webrtc-autoroll
756911644f
Roll chromium_revision 4ba7b4a5c4..b38457816f (1207541:1207700)
...
Change log: 4ba7b4a5c4..b38457816f
Full diff: 4ba7b4a5c4..b38457816f
Changed dependencies
* src/build: 6ae7603574..7019612497
* src/ios: 923647f8ef..71c4ff7e2e
* src/testing: 910b1725b1..604a153a42
* src/third_party: 115d822afe..8e52b48387
* src/third_party/androidx: zUlqegt7mTpkaIkH0An0OHhHMxUEu2Ocnd8D_a9WcmYC..OaH5bHMp_S6FsqKAhEI9qI-0aMFnozdmCwqRK9b8ULgC
* src/third_party/depot_tools: 92d8c4e0cf..4d6298fabb
* src/third_party/freetype/src: 7b308a29dd..322e580bd0
* src/tools: 96d415300d..ad4df51148
DEPS diff: 4ba7b4a5c4..b38457816f
/DEPS
No update to Clang.
BUG=None
Change-Id: I0224083ef305595853e55e743650b65f5c5fda2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322881
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40902}
2023-10-10 16:46:36 +00:00